From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41844: 26.3; Compilation mode keybindings inconsistent with Grep mode Date: Sun, 30 Aug 2020 12:15:25 -0700 Message-ID: References: <4179197.mvXUDI8C0e@laptop.coltonlewis.name> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7835"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41844@debbugs.gnu.org To: Colton Lewis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 30 21:18:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kCSqQ-0001uM-TV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 21:18:26 +0200 Original-Received: from localhost ([::1]:39374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCSqP-0003cZ-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Aug 2020 15:18:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCSo7-0002eZ-OE for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 15:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCSo6-0003c2-7R for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 15:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCSo6-0002di-2K for bug-gnu-emacs@gnu.org; Sun, 30 Aug 2020 15:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Aug 2020 19:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41844 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41844-submit@debbugs.gnu.org id=B41844.159881493310105 (code B ref 41844); Sun, 30 Aug 2020 19:16:02 +0000 Original-Received: (at 41844) by debbugs.gnu.org; 30 Aug 2020 19:15:33 +0000 Original-Received: from localhost ([127.0.0.1]:50761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCSnd-0002cu-69 for submit@debbugs.gnu.org; Sun, 30 Aug 2020 15:15:33 -0400 Original-Received: from mail-yb1-f195.google.com ([209.85.219.195]:34537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCSnb-0002cc-Ak for 41844@debbugs.gnu.org; Sun, 30 Aug 2020 15:15:32 -0400 Original-Received: by mail-yb1-f195.google.com with SMTP id u6so2812875ybf.1 for <41844@debbugs.gnu.org>; Sun, 30 Aug 2020 12:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=NnxHJFDWFb7PT2wRpO++/DaGydKVQCCuruOFcHsLrVk=; b=Wu/SylcsFzR9LzCYcbWdjbf2RU79RNZ+wrErgusppGHCabCuBh5E86nJMVeNTsCfYa LpHjgTFDDxF0c6R8UO1d59lzIjpItceVaO57/IFZsLdrTOXmaIMHKRMNcbRdyL8jiVOS 5DDsjQIFtNkvN3t9Eu6YaLyj2SEHUz4RdS5pEPIw0+jEwe9cvSQfp4ZNDpyPodTHiPye A0Bc5aApazH5KWLxoTCa7O/IUmwfxSJM5ZkVZRis9JhG3TluX/R7FNZ2lnnG3Eb6z0MU 99DmBjijhqyI0NL5cKjd2Qn0lgcjvPmAwDJkAXf+aW2C25lgoF4qO/GF+EmVrTMoF2C4 qHOA== X-Gm-Message-State: AOAM533W3l45svMFie6Sdd1FQqFvmfcaKTuLo6O2yyUlLNTPb1nEnkrB iXSeZUHVadD84SkK87EBjOhVfaiwuWlZziALRxM= X-Google-Smtp-Source: ABdhPJwQKLy7SbRt/bu8GyP6BtWRrOrHHc9QzgjPTOxhl6OYbus1MK4as7bHcAcETCYfVQhK3jx74hJiWsaQUu0si5A= X-Received: by 2002:a25:9843:: with SMTP id k3mr15723846ybo.466.1598814925943; Sun, 30 Aug 2020 12:15:25 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 30 Aug 2020 12:15:25 -0700 In-Reply-To: (Stefan Kangas's message of "Thu, 20 Aug 2020 07:54:05 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186720 Archived-At: close 41844 28.1 thanks Stefan Kangas writes: > Colton Lewis writes: > >> When in Grep mode, 'n' and 'p' respectively go to the next and previous >> match in the buffer. >> >> However, Compilation mode leaves 'n' and 'p' unbound. This inconsistency >> is annoying. > > Sounds like a good idea to me. I've attached a patch which does this. > > Any other opinions? I've been testing this for a week and a half, and I think the new behavior is useful and makes sense. Since there have been no other comments, I have now pushed the patch to master branch as commit 886ba068c8, and I'm closing this bug.