From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#64574: [PATCH] Support not jumping to bol in beginning-of-defun Date: Sun, 3 Sep 2023 04:44:30 -0700 Message-ID: References: <83edle704t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30415"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 64574@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 13:44:59 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qclXH-0007g3-FX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 13:44:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qclXD-0001oY-Uf; Sun, 03 Sep 2023 07:44:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qclXA-0001n8-Ca for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:44:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qclXA-0007iK-4Z for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:44:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qclXK-0004Xg-Ed for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 07:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64574-submit@debbugs.gnu.org id=B64574.169374148917428 (code B ref 64574); Sun, 03 Sep 2023 11:45:02 +0000 Original-Received: (at 64574) by debbugs.gnu.org; 3 Sep 2023 11:44:49 +0000 Original-Received: from localhost ([127.0.0.1]:39841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qclX7-0004X1-D9 for submit@debbugs.gnu.org; Sun, 03 Sep 2023 07:44:49 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]:60424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qclX5-0004Wg-Ac for 64574@debbugs.gnu.org; Sun, 03 Sep 2023 07:44:48 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-500a398cda5so1018235e87.0 for <64574@debbugs.gnu.org>; Sun, 03 Sep 2023 04:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693741471; x=1694346271; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=QHaCsudUza42Gqvn8vrQMeNB5U+nLSeRjo8BT0eqTHs=; b=FSsqcsQH5o4HY7lUYOaofJo2uoD7jZh7UqCWgJTrq5EtRLO89HxT8fiYt5nZEEcdQN ZICl/eT37NeUX9m/bhtPVnI3tK76M9Ina5Fpep/woYVwIpicYeI63q4X6NwtvEzretJT LGmffv8wmyA82h9y2s7jJjd/VzrHRqEJ7YKTbpqiMlbDfpdfRg+WUm3JnVt1E2l5D/SY jQ6k+TNK5aC9mTka3guygN2ynSNJupB84YI1eZ+svOnnwjHC8ytrF7Bhh60y57qXnyKw 8RRdQLQ0Pdrr+PT260vUDjXH6K41taI5iPIMtqvyRJJb8UskKMmd1dJqbRUuAFoKHKaF 3e5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693741471; x=1694346271; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QHaCsudUza42Gqvn8vrQMeNB5U+nLSeRjo8BT0eqTHs=; b=HvMQ01hvqt8k9ZbpVfKpBq/hBvWZAu9hdX9ONEVuJbjVQFnCemMAuwVni3uvJNKzNp QB6cjdrEc1uTlyB8qShezmHUO1OfZcrwTw3MPDZZppe+PYcfNXeklMDTzbCTFOeha6Kz HeZF1Tbck3aLl/fOC9+vdMbWnfBu2j9Qtrq+q6qXqKnM9wdRBTKNyHQ6QN4kjEZnZTVE 2xg9TlSW2z9G/MTUIKuIU0JBPznO15SOqOtOMpuLC2ROoXB7gak4R112cXIk03uZWDK3 I/fvxdsPF3xcN33q/ryNRxgag2MYqb7shnzE2E0vx4HkRKSaSxuRn7jnOHo3YrxhDBJs rwxw== X-Gm-Message-State: AOJu0Yx3s04n7ZfMn4xA5nDs0HzRgDNgpC3gV1iz07Zm7YbgdpJ0qhVf m1bAJaGNC2ezLk4R1y/roWhqePWmZIFd39qxsqI= X-Google-Smtp-Source: AGHT+IHfQDg+Xb+4rLCYgRJs3IabiHfK+K2O8r+r38n/5Ua+u2tHokgFKdeurTZRhDcO1+zZZU3ieMrGvR0D3/9l3rg= X-Received: by 2002:a05:6512:4845:b0:4f8:74b5:b4ec with SMTP id ep5-20020a056512484500b004f874b5b4ecmr4994338lfb.41.1693741470890; Sun, 03 Sep 2023 04:44:30 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 04:44:30 -0700 In-Reply-To: (Spencer Baugh's message of "Wed, 12 Jul 2023 10:57:50 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269150 Archived-At: Spencer Baugh writes: > Users at my site have expressed a preference for this (including me, > once I thought about it enough to realize I don't like the default > behavior). And Jim Porter just mentioned that they would prefer this > too. I'd use it too. >>> +(defvar beginning-of-defun-go-beginning-of-line t >> >> Why not defcustom? >> >> And I would use a shorter name, like beginning-of-defun-go-bol. > > Can do. Perhaps `beginning-of-defun-jumps-to-bol'? >>>From be03d6e994303c3f32d676194f6f31e89917013e Mon Sep 17 00:00:00 2001 > From: Spencer Baugh > Date: Tue, 11 Jul 2023 14:14:34 -0400 > Subject: [PATCH] Support not jumping to bol in beginning-of-defun > > As mentioned in the commit, this default behavior by > beginning-of-defun may be undesirable in some languages and major > modes. I'm thinking of OCaml in particular here, but it's also > arguably unwanted in Python and C++ as well, where defs may be > indented inside class definitions. Let's let the user make this > decision. Your patch still lacks a NEWS item before it can be installed.