all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 43499@debbugs.gnu.org, Jeff Norden <jnorden@tntech.edu>
Subject: bug#43499: 27.1; It is possible for (forward-comment -1) to crash emacs
Date: Thu, 12 Nov 2020 22:40:17 -0500	[thread overview]
Message-ID: <CADwFkmmQD+6k52OpQTHkOFzErcYbM90FWLTdkPZz7RDKfPM3Xw@mail.gmail.com> (raw)
In-Reply-To: <835z893dtc.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Sep 2020 19:56:47 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Jeff Norden <jnorden@tntech.edu>
>> Cc: 43499@debbugs.gnu.org
>> Date: Sat, 19 Sep 2020 11:24:23 -0500
>>
>> > Thanks.  I propose a slightly different change below.  I think it's
>> > somewhat better, because it does the comparison only once, and the
>> > while loop can then run at full speed without testing on each
>> > iteration.  (It looks like a large change, but almost all of it is
>> > just whitespace changes due to re-indentation of the loop.)  Do you
>> > agree?
>>
>> I think either change will work fine.  It doesn't seem to me that either
>> one would be faster, unless I'm missing something.  My suggestion was to
>> move the test from the body of the loop (where from == stop is checked
>> each iteration) to the clause of the while statement (as from > stop
>> instead).  But, maybe a test before the loop starts makes the code more
>> clear - that is entirely your call.
>
> Thanks, I installed my changes.

Did that fix the issue?  Does that mean that this bug can be closed?





  reply	other threads:[~2020-11-13  3:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-19  1:25 bug#43499: 27.1; It is possible for (forward-comment -1) to crash emacs Jeff Norden
2020-09-19  9:08 ` Eli Zaretskii
2020-09-19 16:24   ` Jeff Norden
2020-09-19 16:56     ` Eli Zaretskii
2020-11-13  3:40       ` Stefan Kangas [this message]
2020-11-13  8:18         ` Eli Zaretskii
2020-09-19  9:10 ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmmQD+6k52OpQTHkOFzErcYbM90FWLTdkPZz7RDKfPM3Xw@mail.gmail.com \
    --to=stefan@marxist.se \
    --cc=43499@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jnorden@tntech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.