Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap.

[Stefan Kangas <stefan@marxist.se>]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> 2) The temptation to rewrite a map when doing adding a key or two is
> great, but it makes that single commit harder to read.  So converting
> maps as a separate commit makes things easier to read, not harder.

Agreed.

(IMHO, often it is better to first make the cleanup, and then the
logical change in a separate commit.  My impression is that this style
is not often used in Emacs development.)

> While doing conversion to defvar-keymap, we'd also convert to #', which
> gives us byte compilation support for mis-spelled commands.  I found a
> couple of bindings that pointed to commands that doesn't exist when
> doing the few conversions that I've done.

In addition to this, and keeping in mind also the other points you make,
I think getting some experience with defvar-keymap will help stabilize
and work out any problems in its interface well in advance of Emacs 29.

For example, Bug#52374 was found by me poking at the keymaps in
re-builder.el.  Although presumably that bug would have been eventually
been found anyways, it's always nice to discover such things early.
I have the feeling that there might exist more bugs and opportunities
for improvement that we haven't yet noticed.