From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master d995429e7bc: Use SBYTES instead of strlen in treesit.c Date: Mon, 22 Jul 2024 04:06:30 -0700 Message-ID: References: <172164369582.30827.14373383262408294645@vcs2.savannah.gnu.org> <20240722102136.6C9D6C3534A@vcs2.savannah.gnu.org> <87o76pyb5h.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33775"; mail-complaints-to="usenet@ciao.gmane.io" To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 22 13:07:08 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sVqsm-0008hd-QR for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jul 2024 13:07:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sVqsI-0004Vn-LM; Mon, 22 Jul 2024 07:06:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sVqsF-0004KE-Mk for emacs-devel@gnu.org; Mon, 22 Jul 2024 07:06:35 -0400 Original-Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sVqsD-0002tw-A8 for emacs-devel@gnu.org; Mon, 22 Jul 2024 07:06:35 -0400 Original-Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-52efd855adbso2085059e87.2 for ; Mon, 22 Jul 2024 04:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721646391; x=1722251191; darn=gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=Wqb90xgDqTydT3bMLBzPH/JQjq47s7XMqzkiGDUzbXU=; b=QCsSEG1LAy8GrFF2g3fI9Vd4rw3vR/VaPtzzGaS8fn91xUbZOW5cUHVu+2ZLBQ/5Yt d5HRpts5u0o7P2Ofb4Gac+ZbByOLB69Oc4L72aAuKS7lGGcyUn53WeAxXN9tVegHRuce 4Db3wJM6HD21d52n0FYkNSYPsJBW/VDJN+s0kBXyX3xEEuqgLKQmeu52tz1fSKFKw4RX Zgyk+Cym/fStaYFK567MxJ5kxAd85SxXeifuFT2htOcvPAuKj/nNBZjIszV7pZDWGl4P Z5Alk1Xwd7dXe/synt+e/0DS6hBZ2TBqHgBgJvXvSPnLvFPM5Y/mQQiA5Bed/oXmsG64 F5Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721646391; x=1722251191; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wqb90xgDqTydT3bMLBzPH/JQjq47s7XMqzkiGDUzbXU=; b=HOmP9odMy/NAtX8HMHOTwzeWbTUSGuqkt8MQpaFr1vC79WrmkDZPW70KclwoboRnnP ryFqp8i48OLitEImjXSgdSJIK6yBPQuCUeYgaffYSaINDjKOR4VMUPc+gw3LjmUdiNDa cWTW+HSOuNhJkl9HbNS3YGn9TVI52SZo+k5DPUsoOvWcGPQA042C/BNk82/HFmRW5iZE TgumxP76FJb6p5oSWZyclhhTo9kPGG67FtMrxh5xAI8B1IxDyt22tDMSww6FyYq6S4+s b6677L4Uym46Rtx1ghQZgxHfUr7YAkOWrMTKPnabzFVRQxCwC6cXkcJ5XMi8IBaERR1s cZPQ== X-Forwarded-Encrypted: i=1; AJvYcCU4fjugveEboHMa6T8DgYoFW5gDvvmxpDoTJesHzse+906C5BdsxY2GN9kt2VOTJUupxGj+gQGwFjt/ZZjsLnQfYKH3 X-Gm-Message-State: AOJu0YyFVQJwyqiwSK+F4Oa1q80oareqnKF9D14gXJkKYZ4Vx9HXuMzW fxwgpdI7VsCwVI3htvhJDsYvACWzSmnW3V2Awp+Rpk7yJcshRjIYjTzoRsaHzWqUSR4j+/SFHh3 mslyROXFlc+pWxliC+sjWqmI0KkM= X-Google-Smtp-Source: AGHT+IGesdUVFHDmZvuJpbixLXLMvs0GOXnKAg0fTIDnJ6jUFMCeTeLTnb7PYhk67hkUZm07bKfWBvNcePtBDwE3en8= X-Received: by 2002:a05:6512:1114:b0:52c:e050:452a with SMTP id 2adb3069b0e04-52efb77aab7mr4220107e87.37.1721646391305; Mon, 22 Jul 2024 04:06:31 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 22 Jul 2024 04:06:30 -0700 In-Reply-To: <87o76pyb5h.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=stefankangas@gmail.com; helo=mail-lf1-x134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321928 Archived-At: Po Lu writes: > Have you verified that these functions accept strings holding '\0'? AFAIK, SBYTES returns the string length excluding '\0', same as strlen.