all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Robert Brown <robert.brown@gmail.com>, 59138@debbugs.gnu.org
Cc: joaotavora@gmail.com
Subject: bug#59138: Eglot support for java-language-server
Date: Wed, 9 Nov 2022 07:14:54 -0800	[thread overview]
Message-ID: <CADwFkmmNfJsy8yR__yf=hCtO-6uRZAKnrrudiORsP2kdr7Hv9w@mail.gmail.com> (raw)
In-Reply-To: <CAPNkkpmZ8RVKzts_HYk-s3e4=ym8nHG-F++zLVaDuAX9142yBw@mail.gmail.com>

Robert Brown <robert.brown@gmail.com> writes:

> The attached patch adds Eglot support for Java LSP server
> https://github.com/georgewfraser/java-language-server
> From 8c874c0f277e2e1b85126120da9dcc54e4a938f8 Mon Sep 17 00:00:00 2001
> From: Robert Brown <robert.brown@gmail.com>
> Date: Tue, 8 Nov 2022 19:23:10 -0500
> Subject: [PATCH] Support for java-language-server
>
>  * lisp/progmodes/eglot.el (eglot-server-programs): Add support for
>    Java server https://github.com/georgewfraser/java-language-server
> ---
>  lisp/progmodes/eglot.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index ce989b5611..199c832f6b 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -209,7 +209,8 @@ eglot-server-programs
>                                  (go-mode . ("gopls"))
>                                  ((R-mode ess-r-mode) . ("R" "--slave" "-e"
>                                                          "languageserver::run()"))
> -                                (java-mode . ("jdtls"))
> +                                (java-mode
> +                                 . ,(eglot-alternatives '("jdtls" "java-language-server")))

Thanks for the patch.

Is there any particular reason why we should prefer jdtls to
java-language-server?

>                                  (dart-mode . ("dart" "language-server"
>                                                "--client-id" "emacs.eglot-dart"))
>                                  (elixir-mode . ("language_server.sh"))
> --
> 2.25.1





  reply	other threads:[~2022-11-09 15:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09  0:34 bug#59138: Eglot support for java-language-server Robert Brown
2022-11-09 15:14 ` Stefan Kangas [this message]
     [not found]   ` <CAPNkkp=1Yk08Qk2zhDKuqyAWCebRKOVJs-vzFWCFeXQw9zPomQ@mail.gmail.com>
2022-11-09 16:07     ` Stefan Kangas
2022-11-09 16:25       ` Robert Brown
2022-11-09 16:58         ` João Távora
2022-11-09 17:00         ` Eli Zaretskii
2022-11-25  8:15           ` Stefan Kangas
2022-12-03  1:06             ` Robert Brown
2022-12-03  3:14               ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmNfJsy8yR__yf=hCtO-6uRZAKnrrudiORsP2kdr7Hv9w@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=59138@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=robert.brown@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.