all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: master updated (18e7bc87521 -> c71a520d1da)
Date: Mon, 7 Aug 2023 04:12:49 +0200	[thread overview]
Message-ID: <CADwFkmmNR-7rL27=0sdYci=xhc9i+e1d3WbDVPCSK7=+MreccQ@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmnC9t11ykxg8EJvnqdmtP0VG4xbqRmEiQ8UL6+ZbWvWg@mail.gmail.com>

[ Resent with emacs-devel in Cc, sorry. ]

Did you follow the procedure documented in
admin/doc/git-merge-workflow when doing this merge? It looks to me
like you merged master into feature/android and then pushed that to
master, or something along those lines?

I'm seeing that files have their

     git log <filename>

 littered with incorrect (and distracting) commits saying

    Merge remote-tracking branch 'origin/master' into feature/android

This has not happened for any other feature branch (well, except pgtk,
but it is too late to change that).

AFAICT, we see commits like the above when the merge takes place after
the files were first changed on features/android and then [every time
they are changed] on master. In other words, they are displayed on
master now in the way you would expect on feature/android. See "git
log lisp/startup.el" for an example of what it looks like - not good.

Merge commits _from_ master should not be displayed, as they only
serve to make history less readable. That's why git hides them there
by default after you merge said branch to master. On the other hand we
are, of course, interested in when feature/android was merged into
master. But that is _not_ currently visible in "git log <filename>".

I recommend force pushing a correct merge to master before it is too
late to reverse this.



       reply	other threads:[~2023-08-07  2:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <169136956945.2149.648813436805504636@vcs2.savannah.gnu.org>
     [not found] ` <CADwFkmmnC9t11ykxg8EJvnqdmtP0VG4xbqRmEiQ8UL6+ZbWvWg@mail.gmail.com>
2023-08-07  2:12   ` Stefan Kangas [this message]
2023-08-07  2:24     ` master updated (18e7bc87521 -> c71a520d1da) Stefan Kangas
     [not found]   ` <87wmy737ld.fsf@yahoo.com>
2023-08-07  2:35     ` Po Lu
2023-08-07  2:58       ` Stefan Kangas
2023-08-07  3:52         ` Po Lu
2023-08-09  8:24         ` Robert Pluim
2023-08-09  8:35           ` Po Lu
2023-08-09  8:58             ` Robert Pluim
2023-08-09  9:16               ` Po Lu
2023-08-09 12:47                 ` Robert Pluim
2023-08-09 11:59           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmNR-7rL27=0sdYci=xhc9i+e1d3WbDVPCSK7=+MreccQ@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.