From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44746: 28.0.50; [feature/native-comp] Noisy "*Warnings*" buffer shown on start Date: Thu, 25 Feb 2021 17:59:18 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10064"; mail-complaints-to="usenet@ciao.gmane.io" To: akrl@sdf.org, 44746@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 26 01:00:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFQYH-0002Vh-WD for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Feb 2021 01:00:14 +0100 Original-Received: from localhost ([::1]:52230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFQYG-0004gW-UT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Feb 2021 19:00:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFQY7-0004gC-Hk for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 19:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56433) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFQY7-0005qX-3F for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 19:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lFQY7-0004fK-2L for bug-gnu-emacs@gnu.org; Thu, 25 Feb 2021 19:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Feb 2021 00:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44746 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Andrea Corallo , "Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: 44746@debbugs.gnu.org Original-Received: via spool by 44746-submit@debbugs.gnu.org id=B44746.161429756817832 (code B ref 44746); Fri, 26 Feb 2021 00:00:03 +0000 Original-Received: (at 44746) by debbugs.gnu.org; 25 Feb 2021 23:59:28 +0000 Original-Received: from localhost ([127.0.0.1]:39740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFQXX-0004dX-H4 for submit@debbugs.gnu.org; Thu, 25 Feb 2021 18:59:27 -0500 Original-Received: from mail-pj1-f52.google.com ([209.85.216.52]:39227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lFQXV-0004dD-L3 for 44746@debbugs.gnu.org; Thu, 25 Feb 2021 18:59:26 -0500 Original-Received: by mail-pj1-f52.google.com with SMTP id d2so4609250pjs.4 for <44746@debbugs.gnu.org>; Thu, 25 Feb 2021 15:59:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=FmewCXfVMp7Xc8h1lEDPWN90PZjheUWLn2qLUJmV9nE=; b=klgO+EL0F8eGo2gWS7GWMst82XUgvS4BNEv0kNYa+D/89klBNCAqm1USgH8PxLPjte 9OQSw+wYqVf/qQ6iIvegXns6iUzLX4MHsPl/YVp8brs7kuJ4qoSleKoSaZHuiryFm+y3 sr2w2zO12CaCKcUDreJSMGQftWyvI/ycLpgN25/f45a8Uy9CS9agulpT5fZCQmYtX3Kw 7bRs10/Un9UGLcjhXdsKC3U/STGaYrR35FwOvRwEI33D/8zaFl0NY3jj+CZjANe3cDdt cEqtRREAZBsgABe1RGLUH9YMnBrhUO58pNxANO8flY/nssv+Z058mLiW3ddGFUL34m8f J8PQ== X-Gm-Message-State: AOAM5306aI0agSC136fQG3c2iqMQuh7SRfXn9z4GKd8pIPa/w/iCu0Vt ufL0rI85PR85RECFpQA4Q81T0U+KfeN2c4VlJew= X-Google-Smtp-Source: ABdhPJxdSWJg1H8qMBPBsi8W01YkREvJVs6eNLF64qsQYk6Iq6Goctd+9X8XSYOP1oBWJwWnBwsX0yF1bboSChHeZOs= X-Received: by 2002:a17:90a:bd84:: with SMTP id z4mr379691pjr.179.1614297559517; Thu, 25 Feb 2021 15:59:19 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 25 Feb 2021 17:59:18 -0600 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200823 Archived-At: Andrea Corallo writes: >> The byte compiler does not complain because when it compiles these >> definitions happen to be present in the compilation environment (read >> the file defining these variables was by chance already loaded). Each >> file should be consistent and compilable regardless the load history of >> the Emacs used to compile (read specify the correct requires). >> >> Given async compilation start from a fresh Emacs it's more sensitive >> into spotting these errors or warnings. >> >> Reporting these messages to the user as warnings was the result of >> #44168. Before #44168 these messages where only reported into the >> *Async-native-compile-log*. >> >> This was requested by a number of people because more than one package >> missed requiring the feature containing some macro definition. This >> indeed resulted in miscompilations with the diagnostic message being >> "hidden" in *Async-native-compile-log*. >> >> Compilation units should *not* rely on the compiler environment for >> their definitions. >> >> So yeah these are real warnings or errors and package developers need to >> get them somehow. They could manifest also on non nativecomp builds if >> the compilation order or something else chance. So this is not only a >> nice clean-up but also a real fix IMO. (Sorry I didn't reply properly the last time around.) The above reasoning is correct and valid for any ELisp package, I think. But most of the warnings I see are actually from my init files. There, I specifically do not want to `require' everything I need as that would slow down startup. It also places undue burden on mere users that want to customize this or that option from their init file. And users can and do customize pretty much anything. This is Emacs after all. So we can't really auto load stuff either... Perhaps we need some special casing to detect what is an init file and what is a package? I have no idea how to do that reliably though, so it might be a pipe dream. Or maybe this will all be fixed, for some definition of fixed, when we flip the default? >> I'm not sure what's the best action we can take to reduce the verbosity >> but keep developers informed at the same time. >> >> Andrea > > To complete this answer, ATM is possible to gate all warnings reported > by async native compilations leveraging the > `comp-async-report-warnings-errors' customize. > > Is this sufficient to close this bug or do we like to discuss this > default? > > My opinion (got it from the discussion on emacs-devel) is that at least > for now would be good to keep `comp-async-report-warnings-errors' to t > for the reason I've explained in the mail I'm quoting. Perhaps we could > think about revisiting this default but probably in the future. Yes, I agree with the plan to leave the default for now and think about changing it closer to release. It is your decision to close this bug or not. As far as I'm concerned, I think the necessary clarifications have been made and it is clear that you are on top of things. The other option is to mark it as blocking Emacs 28.1 (Bug#39202) as a reminder. Thanks again for your hard work on this branch! I've been using it daily since August and it is running just fine here.