From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#58840: 29.0.50; Make scheduled reconnects friendlier in ERC Date: Sat, 12 Nov 2022 20:11:34 -0800 Message-ID: References: <87lep0nkmb.fsf@neverwas.me> <87cz9t4ma3.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="685"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-erc@gnu.org, 58840@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 13 05:12:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ou4MI-000AYg-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Nov 2022 05:12:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ou4Lk-0002vh-OG; Sat, 12 Nov 2022 23:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ou4Lj-0002vC-FJ for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 23:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ou4Lj-0004Xb-6i for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 23:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ou4Lh-0008Ff-JK for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 23:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Nov 2022 04:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58840-submit@debbugs.gnu.org id=B58840.166831270331668 (code B ref 58840); Sun, 13 Nov 2022 04:12:01 +0000 Original-Received: (at 58840) by debbugs.gnu.org; 13 Nov 2022 04:11:43 +0000 Original-Received: from localhost ([127.0.0.1]:49756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou4LP-0008Eh-3c for submit@debbugs.gnu.org; Sat, 12 Nov 2022 23:11:43 -0500 Original-Received: from mail-oa1-f53.google.com ([209.85.160.53]:37516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ou4LM-0008ER-E7 for 58840@debbugs.gnu.org; Sat, 12 Nov 2022 23:11:40 -0500 Original-Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-12c8312131fso9383917fac.4 for <58840@debbugs.gnu.org>; Sat, 12 Nov 2022 20:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=I4kM3WdRSMD3/CPPHpg+MC3peAuHuVYFQLdR+Go/weA=; b=UwINSSMPlDI8hWkdPfMnV0IYpmgVXjwpLJUk1J2nNFT4x2Avz4+idcW/Eu3JZbwIVm a3ZSI3+xWJhkBibcFHHjBvL1V2bzDPFzSbgTSZ6VwrTJW/h1amILCGQ3TsHUTT6hJJyT Oa3Te3iLXL6zvYkaJv4vB+y5agZul+qFfffy9TG4giXq/iU+4Njn9BgLz+IqpRD56qZe bHYtGRaLPWdK5Kmnr1RRWyyc9vE70Vpl54T+p6ZTRbnURPpfZTVTDGI08iQLOjgpBurU G1HQQAbdfXtn3LRf2yjGxA8OBy7qyA0djjWvYmQar3yG1zPEGKNnn4+6ossbgIK0FEBA 3RyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I4kM3WdRSMD3/CPPHpg+MC3peAuHuVYFQLdR+Go/weA=; b=YgPlbhdbhWfXzFFFBQfmIqGFMq83iRE9Q/Arq/iU71HmbScB6oZBor4Fs+X7ft32N/ OcR811gzrGaogzQlbA5ZrWpcOLbhKGZCI9k8MZdpXCOjm7V4uAVScXN1DFRVnWTEkdmN HI49TEDKQuCWYlsyFVeKSiprksvShcLfl2/BIgdDJ1P6G5OUnGFTGzCTd+fUHZuHz2us f8gQzpkjfpVZSdAWRfdjJ37W16gqGCMOxFRYDuJCDXJ8TXBsqaNcjQEOBHulv/k795yK V5i2b6J0sY3IMHIkjQaPIZehueqjhjWKYKLYnTcqiHwu3qoO/SXXIf8w2wof2FlWfJjU WsDQ== X-Gm-Message-State: ANoB5plqwjZiN4iDjhoyuO9kY1gFcA5viwvK6sa7pWqz2hcio86QSlHY 9HncRjQBvlyZr6a2eE1CPBfvnNy4LYjG91B4Wa31TP6SDkI= X-Google-Smtp-Source: AA0mqf7hok5lp4uK7toJ4kwteeYn0B+jQAPD9t2WYPt4jdV3bukCJdJmY9+5xjbwE2xQc2nyUx3+sE8JAq1vXk2M2GA= X-Received: by 2002:a05:6870:6c15:b0:13b:8a07:2a1f with SMTP id na21-20020a0568706c1500b0013b8a072a1fmr4414428oab.199.1668312694994; Sat, 12 Nov 2022 20:11:34 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Nov 2022 20:11:34 -0800 In-Reply-To: <87cz9t4ma3.fsf@neverwas.me> (J. P.'s message of "Fri, 11 Nov 2022 06:07:48 -0800") X-Hashcash: 1:20:221113:jp@neverwas.me::P5QFO2PQvSqeWS8W:1O7v X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247733 Archived-At: "J.P." writes: > v2. Added user option to specify function run by reconnect timer. > Factored out reconnect scheduling for use in user code. Looks good to me after a cursory read. I didn't test it, but if you feel confident about it, I think it should go in. Bonus points for the regression tests, as always. Don't forget to add the bug number to the commit message.