Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations

Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations

[Arash Esbati]

Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> diff --git a/lisp/avoid.el b/lisp/avoid.el
> index b53d84d2e8..c97e51a6f7 100644
> --- a/lisp/avoid.el
> +++ b/lisp/avoid.el
> @@ -300,12 +300,14 @@ has an integer value is a valid cursor shape.  You might want to
>  redefine this function to suit your own tastes."
>    (if (null mouse-avoidance-pointer-shapes)
>        (progn
> -	(setq mouse-avoidance-pointer-shapes
> -	      (mapcar (lambda (x) (symbol-value (intern x)))
> -		      (all-completions "x-pointer-" obarray
> -				       (lambda (x)
> -					  (and (boundp x)
> -                                               (integerp (symbol-value x)))))))))
> +	(dolist (i (all-completions "x-pointer-" obarray
> +				    (lambda (x)
> +				      (and (boundp x)
> +                                           (integerp (symbol-value x))))))
> +          (ignore-errors
> +            (let ((value (symbol-value (intern i))))
> +              (when (< value x-pointer-invisible)
> +                (push value mouse-avoidance-pointer-shapes)))))))
>    (seq-random-elt mouse-avoidance-pointer-shapes))

I think this change leads to:

  In mouse-avoidance-random-shape:
  avoid.el:309:30: Warning: reference to free variable `x-pointer-invisible'

when building Emacs (aeefa3a732, on Win10).

Best, Arash

Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations

[Po Lu]

Arash Esbati <arash@gnu.org> writes:

> I think this change leads to:
>
>   In mouse-avoidance-random-shape:
>   avoid.el:309:30: Warning: reference to free variable `x-pointer-invisible'
>
> when building Emacs (aeefa3a732, on Win10).
>
> Best, Arash

Hmm, does adding (defvar x-pointer-invisible) to the top of that file
fix the problem?

Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations

[Arash Esbati]

Po Lu <luangruo@yahoo.com> writes:

> Hmm, does adding (defvar x-pointer-invisible) to the top of that file
> fix the problem?

Yes, it does.

Best, Arash

Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations

[Arash Esbati]

Arash Esbati <arash@gnu.org> writes:

> Po Lu <luangruo@yahoo.com> writes:
>
>> Hmm, does adding (defvar x-pointer-invisible) to the top of that file
>> fix the problem?
>
> Yes, it does.

To avoid confusion: Was the idea that I install the fix above?  I can do
it, just let me know.

Best, Arash

Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations

[Stefan Kangas]

Arash Esbati <arash@gnu.org> writes:

> Arash Esbati <arash@gnu.org> writes:
>
> > Po Lu <luangruo@yahoo.com> writes:
> >
> >> Hmm, does adding (defvar x-pointer-invisible) to the top of that file
> >> fix the problem?
> >
> > Yes, it does.
>
> To avoid confusion: Was the idea that I install the fix above?  I can do
> it, just let me know.

I've installed the above fix to silence the warning.

It's not immediately clear to me if this means that
mouse-avoidance-mode will still work on macOS and Windows.  Maybe
someone could take a look; I don't use that mode myself but it seems
okay to me after some cursory testing.

Re: master 95717db1e8: Fix mouse pointer avoidance in some configurations

[Po Lu]

Stefan Kangas <stefan@marxist.se> writes:

> It's not immediately clear to me if this means that
> mouse-avoidance-mode will still work on macOS and Windows.  Maybe
> someone could take a look; I don't use that mode myself but it seems
> okay to me after some cursory testing.

All modes except `proteus' should work fine on Macs and MS Windows,
but that specific mode only works on X and Haiku.

The feature doesn't work on PGTK at all.