From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips Date: Sun, 25 Aug 2019 13:03:06 +0200 Message-ID: References: <871rxagv91.fsf@linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="173577"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36156@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 25 13:04:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1qJl-000iyQ-Hp for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 13:04:17 +0200 Original-Received: from localhost ([::1]:41818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1qJk-0007vd-2W for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Aug 2019 07:04:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54152) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1qJX-0007vX-B9 for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 07:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1qJW-0000UY-GL for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 07:04:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34839) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1qJW-0000UR-DU for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 07:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1qJW-0001UE-6b for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2019 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2019 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36156-submit@debbugs.gnu.org id=B36156.15667310055664 (code B ref 36156); Sun, 25 Aug 2019 11:04:02 +0000 Original-Received: (at 36156) by debbugs.gnu.org; 25 Aug 2019 11:03:25 +0000 Original-Received: from localhost ([127.0.0.1]:43660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1qIv-0001TI-1k for submit@debbugs.gnu.org; Sun, 25 Aug 2019 07:03:25 -0400 Original-Received: from mail-pg1-f194.google.com ([209.85.215.194]:34496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1qIt-0001T5-Ll for 36156@debbugs.gnu.org; Sun, 25 Aug 2019 07:03:24 -0400 Original-Received: by mail-pg1-f194.google.com with SMTP id n9so8651067pgc.1 for <36156@debbugs.gnu.org>; Sun, 25 Aug 2019 04:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xV2IRoPxNvkZGQUntg/hDQdbJ1eRO/zCvz//wh0vFfE=; b=Qq4xQy+uLfHi2n52pDYd30+SJM7vjo/7L16/ChhcTarKUmjrCwY0IASrDLiwR/DBFZ AnKjGpfwqDhDauC7DYTYk3f0HX0vzCMf5P9DFUOCfyOX8UE06y/Ad743ZMlhMGjcBRUO ugIsKiSV9Wr7IAuuhU99TuRRfzI2D4FZgn2ZptpygpZL+z8F67unnUmCRKSx9k1uJiUZ W8qkLAGQhKLFduJc7IfNNtvxFyfBC8/DIZgIuI0cauedINMQW8Emh0ADyI5BSwovXVgc jyE1XWF6Hl9wvrf8rMffLu8/kzsnsFi4YUZi9jE2ugsKday52nWEws10eCd7iu0spNmC 8Fxw== X-Gm-Message-State: APjAAAWTlIOibyILKCu+OQ9IGMt4c3kX9O+2DPV3B2xENsoFjZA8gISJ IK6jGchV/CLHMIgOdlTRV1rEekAEZ25l/kDYt34= X-Google-Smtp-Source: APXvYqxinMkyfpUZLcEbDYtPM1je/BaVRMhDGQIHOIZHXoh03mZpvxoL9OU0nNBJBtv8H+U/ScjpSZ01xkjY48Q+C94= X-Received: by 2002:a63:69c1:: with SMTP id e184mr11211855pgc.198.1566730997808; Sun, 25 Aug 2019 04:03:17 -0700 (PDT) In-Reply-To: <871rxagv91.fsf@linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165822 Archived-At: Juri Linkov writes: > Today I found a regression in this change: when a tool-bar item > doesn't use a :help keyword (like e.g. in gud-menu-map) then > the tooltip displays just keyboard equivalents in its tooltip. > It used to display the caption in previous Emacs versions. > I believe it could be fixed by this patch: I can reproduce this regression in the gud toolbar on current master. Your patch fixes it and looks good to me. Thanks for finding and resolving this. Best regards, Stefan Kangas