From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: About the new frame title Date: Fri, 13 Nov 2020 15:10:27 -0800 Message-ID: References: <963461223.1300042.1600072070148@mail1.libero.it> <83sgbk9ylm.fsf@gnu.org> <152448855.1272757.1600098758378@mail1.libero.it> <83imc93k5d.fsf@gnu.org> <83sgb7tepo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000062a7d305b40522a6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33861"; mail-complaints-to="usenet@ciao.gmane.io" Cc: angelo.g0@libero.it, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 14 00:11:47 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdiEM-0008hX-LG for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Nov 2020 00:11:46 +0100 Original-Received: from localhost ([::1]:58022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdiEL-00014V-Ib for ged-emacs-devel@m.gmane-mx.org; Fri, 13 Nov 2020 18:11:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdiDA-0000dR-LB for emacs-devel@gnu.org; Fri, 13 Nov 2020 18:10:32 -0500 Original-Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:43007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdiD8-0001Yo-Qq; Fri, 13 Nov 2020 18:10:32 -0500 Original-Received: by mail-ej1-x62c.google.com with SMTP id i19so16060894ejx.9; Fri, 13 Nov 2020 15:10:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=66e1HasIa73rLyQkFhfLyh5+/CeR4gdty6aNR4BQlzU=; b=oygxX5w5m9KBastRnPG+6eyyIMuRoLjFKxHP4vLkyzturDU6ysmYn8EZU6GNs+AAjv T1/AISIWQNoyK5EVdWKYQLrZHPQAXwqWFrHrZgav6dcwGLXadXBXzhrAPaIcS2BdjYtb d+wZaT6dxAMrgAfkaBnA/v9hZO1GCebIky9YzLkAkKR34Ax/GDCHug1vdsq1LFEkMXSM 8mntH3R4IsVL3H7lGUa5XUSgXQU8bfxS2uO0kRxGCfRvIj2ycFRnidqXo9Us7fuoE/WC Re6QCGrZEcfpcFRwcun7S08/uEb4JD5iJiP+kehEGdB0EpJj+iR5MYia6voeowu0KYe6 pE2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=66e1HasIa73rLyQkFhfLyh5+/CeR4gdty6aNR4BQlzU=; b=i16vpn6GQwLqezFigAJSi4CeGpV2z2JyJ+VR8h0IpfBJ/UgM5PQ4NkG9dQAXPbZWar e0dm57K3kpt1xvMoe6KdmyxPpIDkpXOBRIPFPN5l6OKWuLEnCG0+WZASvCl+APFgr65w 5Wri0uqFuYf1v3B1ApsN8Y+jq5whQGNfx2BkjbJ31yYGD74y/gtE9mgMjIwvHlD8rUFB L0EwhsWPmDP1MhwGB0G0PQKU6ZTto4J4dc/uw51vKVkRSpGKj8j4LuCuv6hz9HIpO3Rc c3jRKNwLQmO8zH2qVgglXJNeaO5RsVqpD1ubsx+z59SBsnVg7Iilk7njslUBrWsxeHt8 nxVg== X-Gm-Message-State: AOAM531HHhfUt3AKgt3c6Ae+QoRZQ9zQpp6Nc5CJXsSFxuvv/J+8iPP0 VednszC+bxDV6pG+4Vy/xEt7aadl6qCS9hX40oUAyZ/5 X-Google-Smtp-Source: ABdhPJzJq5Vv49JaT1rRdjXA8iJViSGEuVn+X4dfEXrFNiLkeJ+lv6/QgZ+2mhwtBNA6Zrfb62HfTQ/Df7bwZF6Qpwo= X-Received: by 2002:a17:906:7797:: with SMTP id s23mr4199409ejm.312.1605309028257; Fri, 13 Nov 2020 15:10:28 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 13 Nov 2020 15:10:27 -0800 In-Reply-To: <83sgb7tepo.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=stefankangas@gmail.com; helo=mail-ej1-x62c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259158 Archived-At: --00000000000062a7d305b40522a6 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Thu, 24 Sep 2020 01:57:38 -0700 >> Cc: angelo.g0@libero.it, emacs-devel@gnu.org >> >> + const char *title; >> if (STRINGP (system_name)) >> { >> - *nametail++ = '@'; >> - lispstpcpy (nametail, system_name); >> + title = "GNU Emacs at "; >> + ptrdiff_t nbytes = sizeof (title); > > Does this work? AFAIK, 'sizeof (char *)' returns 8 on a 64-bit system > and 4 on a 32-bit system, regardless of the length of the text string > it points to. Please find attached a fixed patch. --00000000000062a7d305b40522a6 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Make-initial-frame-match-frame-title-format.patch" Content-Disposition: attachment; filename="0001-Make-initial-frame-match-frame-title-format.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 740ad846151329a1_0.1 RnJvbSBiMzczZDc5NjMwYmM2YjQxOWM0NmQ3ODJmMTNjNGM0YmZiNjI1ZjBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogU2F0LCAxOSBTZXAgMjAyMCAxNDoxMzo1MiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2Ug aW5pdGlhbCBmcmFtZSBtYXRjaCBmcmFtZS10aXRsZS1mb3JtYXQKCiogc3JjL3h0ZXJtLmMgKHhf dGVybV9pbml0KToKKiBzcmMvdzMydGVybS5jICh3MzJfaW5pdGlhbGl6ZV9kaXNwbGF5X2luZm8p OiBTeW5jIGluaXRpYWwgZnJhbWUKdGl0bGUgd2l0aCBuZXcgdmFsdWUgb2YgVmZyYW1lX3RpdGxl X2Zvcm1hdC4KUHJvYmxlbSByZXBvcnRlZCBieSBBbmdlbG8gR3Jhemlvc2kgPGFuZ2Vsby5nMEBs aWJlcm8uaXQ+LgotLS0KIHNyYy93MzJ0ZXJtLmMgfCAxMyArKysrKysrKy0tLS0tCiBzcmMveHRl cm0uYyAgIHwgMjQgKysrKysrKysrKysrKystLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIy IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy93MzJ0ZXJt LmMgYi9zcmMvdzMydGVybS5jCmluZGV4IGUwNjE4ZTRmNTIuLjg5ZmEyNmVkOWYgMTAwNjQ0Ci0t LSBhL3NyYy93MzJ0ZXJtLmMKKysrIGIvc3JjL3czMnRlcm0uYwpAQCAtNzE2NywxMyArNzE2Nywx NiBAQCB3MzJfaW5pdGlhbGl6ZV9kaXNwbGF5X2luZm8gKExpc3BfT2JqZWN0IGRpc3BsYXlfbmFt ZSkKICAgZHB5aW5mby0+bmFtZV9saXN0X2VsZW1lbnQgPSBGY29ucyAoZGlzcGxheV9uYW1lLCBR bmlsKTsKICAgaWYgKFNUUklOR1AgKFZzeXN0ZW1fbmFtZSkpCiAgICAgewotICAgICAgZHB5aW5m by0+dzMyX2lkX25hbWUgPSB4bWFsbG9jIChTQ0hBUlMgKFZpbnZvY2F0aW9uX25hbWUpCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICsgU0NIQVJTIChWc3lzdGVtX25hbWUp ICsgMik7Ci0gICAgICBzcHJpbnRmIChkcHlpbmZvLT53MzJfaWRfbmFtZSwgIiVzQCVzIiwKLSAg ICAgICAgICAgICAgIFNEQVRBIChWaW52b2NhdGlvbl9uYW1lKSwgU0RBVEEgKFZzeXN0ZW1fbmFt ZSkpOworICAgICAgc3RhdGljIGNoYXIgY29uc3QgdGl0bGVbXSA9ICJHTlUgRW1hY3MgYXQgIjsK KyAgICAgIGRweWluZm8tPnczMl9pZF9uYW1lID0geG1hbGxvYyAoc2l6ZW9mIHRpdGxlICsgU0NI QVJTIChWc3lzdGVtX25hbWUpKTsKKyAgICAgIHNwcmludGYgKGRweWluZm8tPnczMl9pZF9uYW1l LCAiJXMlcyIsIHRpdGxlLCBTREFUQSAoVnN5c3RlbV9uYW1lKSk7CiAgICAgfQogICBlbHNlCi0g ICAgZHB5aW5mby0+dzMyX2lkX25hbWUgPSB4bGlzcHN0cmR1cCAoVmludm9jYXRpb25fbmFtZSk7 CisgICAgeworICAgICAgc3RhdGljIGNoYXIgY29uc3QgdGl0bGVbXSA9ICJHTlUgRW1hY3MiOwor ICAgICAgZHB5aW5mby0+dzMyX2lkX25hbWUgPSB4bWFsbG9jIChzaXplb2YgdGl0bGUpOworICAg ICAgc3ByaW50ZiAoZHB5aW5mby0+dzMyX2lkX25hbWUsICIlcyIsIHRpdGxlKTsKKyAgICB9CiAK ICAgLyogRGVmYXVsdCBDb25zb2xlIG1vZGUgdmFsdWVzIC0gb3ZlcnJpZGRlbiB3aGVuIHJ1bm5p bmcgaW4gR1VJIG1vZGUKICAgICAgd2l0aCB2YWx1ZXMgb2J0YWluZWQgZnJvbSBzeXN0ZW0gbWV0 cmljcy4gICovCmRpZmYgLS1naXQgYS9zcmMveHRlcm0uYyBiL3NyYy94dGVybS5jCmluZGV4IDk4 YmIwZWE4OTEuLmM2NTU4OGNmZGEgMTAwNjQ0Ci0tLSBhL3NyYy94dGVybS5jCisrKyBiL3NyYy94 dGVybS5jCkBAIC0xMjkyOCwxOSArMTI5MjgsMjMgQEAgI2RlZmluZSBOVU1fQVJHViAxMAogI2Vu ZGlmCiAKICAgTGlzcF9PYmplY3Qgc3lzdGVtX25hbWUgPSBGc3lzdGVtX25hbWUgKCk7Ci0KLSAg cHRyZGlmZl90IG5ieXRlcyA9IFNCWVRFUyAoVmludm9jYXRpb25fbmFtZSkgKyAxOwotICBpZiAo U1RSSU5HUCAoc3lzdGVtX25hbWUpCi0gICAgICAmJiBJTlRfQUREX1dSQVBWIChuYnl0ZXMsIFNC WVRFUyAoc3lzdGVtX25hbWUpICsgMSwgJm5ieXRlcykpCi0gICAgbWVtb3J5X2Z1bGwgKFNJWkVf TUFYKTsKLSAgZHB5aW5mby0+eF9pZCA9ICsreF9kaXNwbGF5X2lkOwotICBkcHlpbmZvLT54X2lk X25hbWUgPSB4bWFsbG9jIChuYnl0ZXMpOwotICBjaGFyICpuYW1ldGFpbCA9IGxpc3BzdHBjcHkg KGRweWluZm8tPnhfaWRfbmFtZSwgVmludm9jYXRpb25fbmFtZSk7CiAgIGlmIChTVFJJTkdQIChz eXN0ZW1fbmFtZSkpCiAgICAgewotICAgICAgKm5hbWV0YWlsKysgPSAnQCc7Ci0gICAgICBsaXNw c3RwY3B5IChuYW1ldGFpbCwgc3lzdGVtX25hbWUpOworICAgICAgc3RhdGljIGNoYXIgY29uc3Qg dGl0bGVbXSA9ICJHTlUgRW1hY3MgYXQgIjsKKyAgICAgIHB0cmRpZmZfdCBuYnl0ZXMgPSBzaXpl b2YgdGl0bGU7CisgICAgICBpZiAoSU5UX0FERF9XUkFQViAobmJ5dGVzLCBTQllURVMgKHN5c3Rl bV9uYW1lKSwgJm5ieXRlcykpCisJbWVtb3J5X2Z1bGwgKFNJWkVfTUFYKTsKKyAgICAgIGRweWlu Zm8tPnhfaWRfbmFtZSA9IHhtYWxsb2MgKG5ieXRlcyk7CisgICAgICBzcHJpbnRmIChkcHlpbmZv LT54X2lkX25hbWUsICIlcyVzIiwgdGl0bGUsIFNEQVRBIChzeXN0ZW1fbmFtZSkpOwogICAgIH0K KyAgZWxzZQorICAgIHsKKyAgICAgIHN0YXRpYyBjaGFyIGNvbnN0IHRpdGxlW10gPSAiR05VIEVt YWNzIjsKKyAgICAgIGRweWluZm8tPnhfaWRfbmFtZSA9IHhtYWxsb2MgKHNpemVvZiB0aXRsZSk7 CisgICAgICBzcHJpbnRmIChkcHlpbmZvLT54X2lkX25hbWUsICIlcyIsIHRpdGxlKTsKKyAgICB9 CisKKyAgZHB5aW5mby0+eF9pZCA9ICsreF9kaXNwbGF5X2lkOwogCiAgIC8qIEZpZ3VyZSBvdXQg d2hpY2ggbW9kaWZpZXIgYml0cyBtZWFuIHdoYXQuICAqLwogICB4X2ZpbmRfbW9kaWZpZXJfbWVh bmluZ3MgKGRweWluZm8pOwotLSAKMi4yOS4yCgo= --00000000000062a7d305b40522a6--