bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Stefan Kangas]

Severity: wishlist

On GNU ELPA, we have the package modus-operandi-theme and
modus-vivendi-theme.  I've been using them for a while now, and find
they are of high quality and with good coverage of faces also in
third-party packages.

Please consider bundling them with Emacs by default.

Best regards,
Stefan Kangas

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 24 Aug 2020 07:33:35 -0400
> Cc: info@protesilaos.com
> 
> On GNU ELPA, we have the package modus-operandi-theme and
> modus-vivendi-theme.  I've been using them for a while now, and find
> they are of high quality and with good coverage of faces also in
> third-party packages.
> 
> Please consider bundling them with Emacs by default.

Why are they on ELPA to begin with?

There should be no problem adding this to Emacs, but the author needs
to explicitly say he donates the code to Emacs.

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Protesilaos Stavrou]

Eli Zaretskii <eliz@gnu.org> [2020-08-24, 14:47 +0300]:

>> From: Stefan Kangas <stefan@marxist.se>
>> Date: Mon, 24 Aug 2020 07:33:35 -0400
>> Cc: info@protesilaos.com
>> 
>> On GNU ELPA, we have the package modus-operandi-theme and
>> modus-vivendi-theme.  I've been using them for a while now, and find
>> they are of high quality and with good coverage of faces also in
>> third-party packages.
>> 
>> Please consider bundling them with Emacs by default.
>
> Why are they on ELPA to begin with?

They are on GNU ELPA to make it easier for users to install them without
having to configure their package archives.

> There should be no problem adding this to Emacs, but the author needs
> to explicitly say he donates the code to Emacs.

I am fine with contributing them to Emacs.  Thanks!  Do I need to sign
some extra paper or something?

In technical terms, how would this affect their development?  Do I need
to change their git repo to some other source?  How will new
commits/releases be synced with Emacs?  Would development be shared with
emacs-devel or some other mailing list?

Sorry for the questions: I am just fairly new to this.  At any rate, I
am willing to contribute them and will adapt accordingly.

Best regards,
Prot

-- 
Protesilaos Stavrou
protesilaos.com

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Eli Zaretskii]

> From: Protesilaos Stavrou <info@protesilaos.com>
> Cc: Stefan Kangas <stefan@marxist.se>,  43019@debbugs.gnu.org
> Date: Mon, 24 Aug 2020 15:03:46 +0300
> 
> > There should be no problem adding this to Emacs, but the author needs
> > to explicitly say he donates the code to Emacs.
> 
> I am fine with contributing them to Emacs.  Thanks!  Do I need to sign
> some extra paper or something?

No, I think this email message is enough.  Thanks.

> In technical terms, how would this affect their development?  Do I need
> to change their git repo to some other source?  How will new
> commits/releases be synced with Emacs?  Would development be shared with
> emacs-devel or some other mailing list?

From my POV, the ideal arrangement would be for you to tell us when to
sync the version in Emacs, or maybe even push the changes yourself.

> Sorry for the questions: I am just fairly new to this.

No need to apologize, the questions are all well taken.

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> In technical terms, how would this affect their development?  Do I need
>> to change their git repo to some other source?  How will new
>> commits/releases be synced with Emacs?  Would development be shared with
>> emacs-devel or some other mailing list?
>
> From my POV, the ideal arrangement would be for you to tell us when to
> sync the version in Emacs, or maybe even push the changes yourself.

Here's my understanding of how this would work:

- We start with just reviewing and then installing the currently
  released ELPA version on the master branch.

- When Protesilaos thinks it's time (for example, when he tags a new
  version), he opens a bug report with an email to bug-gnu-emacs@gnu.org
  letting us know that we should please merge the new version.  Attached
  to that email is a patch against emacs.git, where the commit message
  follows the format of commit 99f8a1c91733 in emacs.git.

- Other than that, the workflow stays the same with regards to GNU ELPA.
  This is a good thing to maintain, since that means that users can
  easily install the latest version of the theme should they want or
  need to.

Eli, please correct me if anything above is incorrect or unsatisfactory.

(In the future, the easiest would probably be if Protesilaos requested
commit access on Savannah to just push any changes directly to emacs.git
himself.  But there is no particular need to do this immediately.)

Best regards,
Stefan Kangas

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 24 Aug 2020 09:13:58 -0400
> Cc: 43019@debbugs.gnu.org
> 
> - We start with just reviewing and then installing the currently
>   released ELPA version on the master branch.
> 
> - When Protesilaos thinks it's time (for example, when he tags a new
>   version), he opens a bug report with an email to bug-gnu-emacs@gnu.org
>   letting us know that we should please merge the new version.  Attached
>   to that email is a patch against emacs.git, where the commit message
>   follows the format of commit 99f8a1c91733 in emacs.git.
> 
> - Other than that, the workflow stays the same with regards to GNU ELPA.
>   This is a good thing to maintain, since that means that users can
>   easily install the latest version of the theme should they want or
>   need to.
> 
> Eli, please correct me if anything above is incorrect or unsatisfactory.

The above is okay, but Protesilaos could just tell us in an email,
there's no need for so much "red tape" for a simple request.

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> The above is okay, but Protesilaos could just tell us in an email,
> there's no need for so much "red tape" for a simple request.

Agreed.

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Protesilaos Stavrou]

Stefan Kangas <stefan@marxist.se> [2020-08-24, 09:53 -0400]:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> The above is okay, but Protesilaos could just tell us in an email,
>> there's no need for so much "red tape" for a simple request.
>
> Agreed.

Very well!

I was already planning a tagged release for the end of this week
(version 0.12.0).  Either you wait a little longer while expecting a
notification from my side in response to this thread, or you can already
use what is in GNU ELPA.

For future releases I can just post a note on emacs-devel.

-- 
Protesilaos Stavrou
protesilaos.com

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> The above is okay, but Protesilaos could just tell us in an email,
> there's no need for so much "red tape" for a simple request.

One more question Eli, do you think that we should announce these new
themes in NEWS?  I tried grepping for "theme" in NEWS.* and couldn't
find any examples of when we've done that.

(I feel that we might as well announce it, even if we didn't usually do
so in the past.)

Best regards,
Stefan Kangas

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 25 Aug 2020 05:33:03 -0700
> Cc: 43019@debbugs.gnu.org
> 
> One more question Eli, do you think that we should announce these new
> themes in NEWS?  I tried grepping for "theme" in NEWS.* and couldn't
> find any examples of when we've done that.

Yes, let's announce them.  I don't know why we didn't announce new
themes in the past.

Thanks.

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Stefan Kangas]

Protesilaos Stavrou <info@protesilaos.com> writes:

> I was already planning a tagged release for the end of this week
> (version 0.12.0).  Either you wait a little longer while expecting a
> notification from my side in response to this thread, or you can already
> use what is in GNU ELPA.

Great, thank you!  Please let us know when the new version is released.

> For future releases I can just post a note on emacs-devel.

Yes, or to bug-gnu-emacs@gnu.org, whichever you prefer.

(A bug report has the benefit of not getting lost as easily since it is
assigned a specific number and has to be explicitly closed.)

Best regards,
Stefan Kangas

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Protesilaos Stavrou]

Stefan Kangas <stefan@marxist.se> [2020-08-25, 07:21 -0700]:

>> I was already planning a tagged release for the end of this week
>> (version 0.12.0).  Either you wait a little longer while expecting a
>> notification from my side in response to this thread, or you can already
>> use what is in GNU ELPA.
>
> Great, thank you!  Please let us know when the new version is released.

I published version 0.12.0 earlier today.  The new packages are already
available in GNU ELPA.

>> For future releases I can just post a note on emacs-devel.
>
> Yes, or to bug-gnu-emacs@gnu.org, whichever you prefer.
>
> (A bug report has the benefit of not getting lost as easily since it is
> assigned a specific number and has to be explicitly closed.)

Very well!  Next time I will notify you via a bug report.

Please let me know if you need anything else from my side.  And thank
you for doing this!

-- 
Protesilaos Stavrou
protesilaos.com

bug#43019: Bundle modus-operandi-theme and modus-vivendi-theme with Emacs

[Stefan Kangas]

close 43019 28.1
thanks

Protesilaos Stavrou <info@protesilaos.com> writes:

> I published version 0.12.0 earlier today.  The new packages are already
> available in GNU ELPA.

Thank you.  I have pushed this to master in your name including a
NEWS-entry (commit c1b0515952), and I'm closing this bug.

The only change I made was in the header of those files, to say:

;; This file is part of GNU Emacs.

To simplify future merges, I suggest that you make that change in your
development repository as well.

> Very well!  Next time I will notify you via a bug report.
>
> Please let me know if you need anything else from my side.  And thank
> you for doing this!

Sounds good.  Thanks for the great themes!

Best regards,
Stefan Kangas