From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) : Set to 64. Date: Wed, 7 Feb 2024 12:01:14 -0800 Message-ID: References: <170727415485.32408.11264518274307262467@vcs2.savannah.gnu.org> <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40457"; mail-complaints-to="usenet@ciao.gmane.io" To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 07 21:02:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rXo7g-000ANW-6I for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Feb 2024 21:02:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXo6r-0001ow-AH; Wed, 07 Feb 2024 15:01:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXo6o-0001og-UW for emacs-devel@gnu.org; Wed, 07 Feb 2024 15:01:27 -0500 Original-Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXo6l-0003Dr-Fx for emacs-devel@gnu.org; Wed, 07 Feb 2024 15:01:26 -0500 Original-Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-55ad2a47b7aso1490960a12.3 for ; Wed, 07 Feb 2024 12:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707336075; x=1707940875; darn=gnu.org; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=jqAsBcGvoy3U8Nh6YOgVs3miD1s2wZgKFWlQ3R6OboU=; b=CHj82/C6MNj/aVZPBlIT6awiWn3YBfykX3kYIQ4kMke0Ybr3O6hqOHUN2MOn3JbJ7u o7+t80Tm0QDTWBoNuL2txmNKUOocEe5PDQ0tlWKh8mNb6jnUH8LvDH7Ikz6z97DR30Li rvBaQftQ3IqA2Mmn/UJX87DkWGJh9v02zLGmWG3eTFCy7toFB6BOWSAu7bESq2pmEX2v S0kwg/Z6TfIVmPqYw8U2p/b75eQhGsidXEozkIsahoO0dmsPmSNH6jZb887FUcQdRsWe Ey09Hq55Wc8VCW0rJ5yZYrUbihodVf1eIKYq2oOUE4ev5x+YGfxyA2JyjZQOOz4pnS+Z efHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707336075; x=1707940875; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jqAsBcGvoy3U8Nh6YOgVs3miD1s2wZgKFWlQ3R6OboU=; b=FYam0d7xDJ+yFSzLXRCuBzYOdeasps2Xq0LFzuAe6/eLNp6aOQfZAyUUwdFI8/W1XP hg/Tb8duoYk1gliJSitLfDW/VTpF3/82PY3roqp8a/dpbqMTynkGQAEbNPIhpddkivXH aT8TWptoiqTRzeQxChdypxD9BJNZjIH7In7rMZYkQkOFli1fbks7Ug51XQym53p82QlA WjPeMh492qi35oQw+o5G4y6ivSrdwm8Ib1nokOnJnx1EkXoi4ihzww3WEtt8rA/73px3 QT9cJb01AlPdnAxgFVPnYKqtC1pWBrMeBnzNrUFi2W2ULki8WcfWXXHdO09NUv/jWNoJ DnlA== X-Gm-Message-State: AOJu0YyrzXiqehW4OPm1d0RrQolKzJeXDdOGqb+cFn+bg3bKE2yjX6Q4 Ucs5XaTAuZ2mTKZQX94mAiO9SN6TujqL4/FGK+30mM3cb7lM4d187BTfoF2Oipj+UVh5eipRQgc tAZVAZuSdQW7Xz5DekypbREylK9z/GsDyoHI= X-Google-Smtp-Source: AGHT+IEZIGHEtLvDuWqTNNLsdkgcuLkccBSCGd7gCSIusXcMi2LLPgv3An64yHoMFpM4FjcAgTjeQzrRBkGGU4Pq/n0= X-Received: by 2002:a05:6402:8d6:b0:560:4e6:c442 with SMTP id d22-20020a05640208d600b0056004e6c442mr4460511edz.1.1707336075291; Wed, 07 Feb 2024 12:01:15 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 7 Feb 2024 12:01:14 -0800 In-Reply-To: <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315996 Archived-At: Po Lu via Mailing list for Emacs changes writes: > ; .dir-locals.el (log-edit-mode) : Set to 64. > --- > .dir-locals.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.dir-locals.el b/.dir-locals.el > index 1f08c882e0b..89fb76a55f3 100644 > --- a/.dir-locals.el > +++ b/.dir-locals.el > @@ -32,7 +32,8 @@ > (mode . bug-reference-prog))) > (log-edit-mode . ((log-edit-font-lock-gnu-style . t) > (log-edit-setup-add-author . t) > - (vc-git-log-edit-summary-target-len . 50))) > + (vc-git-log-edit-summary-target-len . 50) > + (fill-column . 64))) > (change-log-mode . ((add-log-time-zone-rule . t) > (fill-column . 74) > (mode . bug-reference))) This change breaks with our conventions and historical practice, and makes both commit messages and ChangeLogs take up much more vertical space for no practical benefit. I think we should revert this change, leaving `fill-column' in `log-edit' at the value it was at.