From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format Date: Sun, 26 Dec 2021 08:39:54 -0800 Message-ID: References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8247"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52523@debbugs.gnu.org To: Lars Ingebrigtsen , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 26 17:41:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1Wa5-00020i-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 17:41:09 +0100 Original-Received: from localhost ([::1]:40170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1Wa3-0003CT-RY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Dec 2021 11:41:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1WZy-0003CJ-4J for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 11:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58065) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1WZx-00083j-R1 for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 11:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1WZx-0002oi-LJ for bug-gnu-emacs@gnu.org; Sun, 26 Dec 2021 11:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Dec 2021 16:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52523 X-GNU-PR-Package: emacs Original-Received: via spool by 52523-submit@debbugs.gnu.org id=B52523.164053680310725 (code B ref 52523); Sun, 26 Dec 2021 16:41:01 +0000 Original-Received: (at 52523) by debbugs.gnu.org; 26 Dec 2021 16:40:03 +0000 Original-Received: from localhost ([127.0.0.1]:41378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1WZ0-0002mv-MB for submit@debbugs.gnu.org; Sun, 26 Dec 2021 11:40:02 -0500 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:45038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1WYy-0002mK-Ma for 52523@debbugs.gnu.org; Sun, 26 Dec 2021 11:40:02 -0500 Original-Received: by mail-pj1-f44.google.com with SMTP id k6-20020a17090a7f0600b001ad9d73b20bso12435389pjl.3 for <52523@debbugs.gnu.org>; Sun, 26 Dec 2021 08:40:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=nEucWPCiiSapSYO4OWLBBEfZwvWIvafNPIzxhy0fZmg=; b=KkgU00r+BznDTDP8F9UTm5gRZCR3RuJq/+wODXu/TqnZB6/VzFlPp8zbywBSrjy3iF F4WCUUyFr/4iNHebhvjbPY2FIqQuYKl0aas5nsT3KDfZiiAXASfUX3ZByK1nvKq6wJOc NUrrb5ZP6203Vb8rRdz5FeJPh8bSeNDJ+Po53dBNPewza8FWfYyiYP/9Nlbfr7xjoR04 5Ya48J8T5lVlhYFaG0WyqsVdqYpoB0W29ZzI5ZBpQoN0Wn23CSigAbDMEuaUreuUsjzF S5MKplSqbERpTwhKZFwHMwi+z1TOhQtWQGLO79ZhI0qMBYsDlBjsEp2z43Aw3S/dxmkE sMmQ== X-Gm-Message-State: AOAM532y7oyH+pcXD01icDn2aSkzFPnmLdQ9JyVXooC2OeZ7PFqOtyvk k2tRTMHidYW24fcW4LXXblSFqXt05qrkt/ehayE= X-Google-Smtp-Source: ABdhPJxM3Rw2NyJgeEtCw4yZn2tBiN36AZUauobK2Kdl8fYwRxrZhMrFxQWadoYxKKKv32fZ3WDyYupwZvAaV1syoCQ= X-Received: by 2002:a17:902:d512:b0:149:3070:48ec with SMTP id b18-20020a170902d51200b00149307048ecmr13925479plg.66.1640536794911; Sun, 26 Dec 2021 08:39:54 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 26 Dec 2021 08:39:54 -0800 In-Reply-To: <87pmpoerrm.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223154 Archived-At: Lars Ingebrigtsen writes: >> I still see no problem with 'kbd', or even 'kbd-sequence'. > > The problem is that we don't use the name "kbd" anywhere in the new > keymap functions, so it'd be confusing to use them in defcustom. I started looking into this but noticed that the docstring for `key-valid-p' says: Say whether KEYS is a valid =E2=80=98kbd=E2=80=99 sequence. A =E2=80=98kbd=E2=80=99 sequence is a string consisting of one and more= key strokes. The key strokes are separated by a space character. I guess that docstring should be updated if we don't want to settle for the terminology "`kbd' sequence". However, if we do that the problem is that we then risk having two definitions of "key sequence": both the old and the new style. See also (info "(elisp) Key Sequences"), that uses the old style. --- Relatedly, the `define-keymap' docstring currently says: Create a new keymap and define KEY/DEFINITION pairs as key sequences. Should that say "key bindings" instead of "key sequences"? Otherwise, it doesn't seem clear what it does. --- `keymap-set' says: Set key sequence KEY to DEFINITION in KEYMAP. So here is again the "new" style used as the definition of a key sequence, which seems to contradict the Elisp manual.