From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#75192: [PATCH] Update fontification for attribute values in heex-ts-mode Date: Thu, 2 Jan 2025 02:41:12 -0600 Message-ID: References: <86zfk9k3xr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40447"; mail-complaints-to="usenet@ciao.gmane.io" Cc: wkirschbaum@gmail.com, casouri@gmail.com, 75192@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 09:42:41 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTGmu-000AOT-VU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 09:42:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTGmK-0007cm-9V; Thu, 02 Jan 2025 03:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTGmJ-0007cb-1U for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 03:42:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTGmI-0008Jt-OW for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 03:42:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=IeIkZeJnzlOWM3kIIRlZbiD4g4YQDdGrl0ktcr03GjU=; b=OC2YfbLICBj1e6Jj1RSkRso2cMezTy+Wp+D8iUKVe2P5p87vSLFEGf086Zv3H6/ztCZcJz24W6vxqBl3sXwGYHDyOfJyvcniIXrD6YwoKrQAJm1wBD60RhghgXUBRwqoQoMlyuQD11KYFOtnzsrSsb24w82H749SltWO2uhl5+R3R2x9OOOvxEV9RzlbILMqrU+spKnczstKXIJIRhS47IfkB2qpNrfihId2OKyMUbuU0xfoyaYHdfxxSxnWyyuXREJmFAo4S4TrGX/E8ZWHEqOc6S/o9Hjhs9bHrV4E8zZdmWw03PLBJFCg99Bk8sXATnaGZQcPYoH855kus8ncHQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTGmI-0004cV-Dk for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 03:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 08:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75192 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 75192-submit@debbugs.gnu.org id=B75192.173580728117698 (code B ref 75192); Thu, 02 Jan 2025 08:42:02 +0000 Original-Received: (at 75192) by debbugs.gnu.org; 2 Jan 2025 08:41:21 +0000 Original-Received: from localhost ([127.0.0.1]:42705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTGld-0004bO-FQ for submit@debbugs.gnu.org; Thu, 02 Jan 2025 03:41:21 -0500 Original-Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]:43479) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTGlb-0004b9-Og for 75192@debbugs.gnu.org; Thu, 02 Jan 2025 03:41:20 -0500 Original-Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so21368409a12.1 for <75192@debbugs.gnu.org>; Thu, 02 Jan 2025 00:41:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735807273; x=1736412073; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=IeIkZeJnzlOWM3kIIRlZbiD4g4YQDdGrl0ktcr03GjU=; b=V9oFMrRXO/p512xynE0p+n07Rn4EdeNmaHdT3ApXpz0VP1N/lFurte7IPOdbXIckbw IldD+ijPDwCk4DUQdMX5hc3fZCJOTUkrkX8Kc7zovsRAfQm1cxgxUZIZd94Tz/cQrvQF dlTqLYWbPiBxoBnDQR+jlWB/hBT0c/bwVpMAlSiweQ5u1c1pNTPscFUnsyqjRM9U2GqT unRNoabaDt7NrP+3aMOknHBG5lgT5bdIzLbSkYwirGMZjarXgBM/bElltdUwuXBsNPNO xs7Vvh9tcuM28jmXNTqS1XDzc6bFstXc96zsUACgTSaX9OJGNDr/bMoJqQw9gJUFHh7g TCOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735807273; x=1736412073; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IeIkZeJnzlOWM3kIIRlZbiD4g4YQDdGrl0ktcr03GjU=; b=MZk6TJ6scdrkJc52c+ox/kk3B94zNmy75zsapRRUWAJjtLTeKqTZv0dJ0qPjZKwhIt 890SaKckY9gexyokFG6DYykc1axDq8YW5SIXT0fTSnCj2p+HUvEbS63s3He2y9f+CUFa +mAUjPRm5AOrUPLkgHFnk7eJi0d0CRZzC4XRGqzN9uGBEe6QZ5xJapIANZPIsbEHsdb8 sX3TMxP9X7fb129H9JxcQqhv08TBvtvRuj7DUUfOwV+JgQG7skQOxOqSMzxvP22tgYG1 gBA+RZPv8EAe+EtNhPPca3ycSCbdGNSy7s82jBciled9f7JL4pBZHN5vfxSLiriVHJZc usGg== X-Forwarded-Encrypted: i=1; AJvYcCVWaHXSjTG+TcpfX2uevosFsiLi64CwfFmxulQQQK80RbwaOzWpldScim3k+QjEJvQN387ZkQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy9c6TJ0OTSNc4Wf0HM0ahRzJGHLc/Ms0Hdo8egcwUfqG2zqUu9 JrM6N8ioJwcS7vaWhK73fOgKrrmYoL5azV7tFz1Z5e9baZ5/SjkImhufmYsrSyTUOX1iFx6gy6o /10dKTYgsiPWBnQclTdKLCcEpmGQ= X-Gm-Gg: ASbGncvgAk7M00THSVedLIoVii3APb0Aw01JNQ/uaU6R9PJgGr0yCZY5jlmt4zSs5+N TSqN+zkO17xxfvWFr14/SNyxC7oU1bEJtGuoBqm7j X-Google-Smtp-Source: AGHT+IH1C/vJR66+z2anFGBgmnT/wsF1s1zcOVmMjdDsXYmA7o6Audt1TQB1UtdfAHZJL6+dr8qBwBAXUOwXfVpFdac= X-Received: by 2002:a05:6402:3513:b0:5d3:e9fd:9a16 with SMTP id 4fb4d7f45d1cf-5d80245b6e8mr42876476a12.12.1735807273525; Thu, 02 Jan 2025 00:41:13 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 2 Jan 2025 02:41:12 -0600 In-Reply-To: <86zfk9k3xr.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298149 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Thu, 2 Jan 2025 01:45:22 -0600 >> Cc: Eli Zaretskii , Yuan Fu >> >> Wilhelm Kirschbaum writes: >> >> > This updates heex-ts-mode to use font-lock-string-face to be consistent >> > with html-ts-mode on attribute values. >> >> Should we install this change on master or emacs-30? Eli, Yuan, WDYT? > > Are we all in agreement with the change itself? Why should an > attribute be highlighted as a string? I'm not familiar with HEEx and can't share a useful opinion, but FWIW, I simply noted that the code directly above the change said :feature 'heex-string which is why I assumed that using a string face should make sense. I'll let others chime in here.