From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Date: Mon, 19 Oct 2020 15:41:48 -0700 Message-ID: References: <955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at> <83mu553e0x.fsf@gnu.org> <953c6df9-59b4-8b57-0be3-600d147fe9c7@ims.co.at> <83y2k2pabb.fsf@gnu.org> <83wnzmnioj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11826"; mail-complaints-to="usenet@ciao.gmane.io" Cc: thomas.hisch@ims.co.at, 41852@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 20 00:42:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUdr1-0002tl-D7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Oct 2020 00:42:11 +0200 Original-Received: from localhost ([::1]:33264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUdr0-0004Gr-5z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 18:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUdqs-0004FT-59 for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 18:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUdqr-0003lM-S4 for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 18:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUdqr-00059p-NU for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 18:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2020 22:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41852-submit@debbugs.gnu.org id=B41852.160314731619812 (code B ref 41852); Mon, 19 Oct 2020 22:42:01 +0000 Original-Received: (at 41852) by debbugs.gnu.org; 19 Oct 2020 22:41:56 +0000 Original-Received: from localhost ([127.0.0.1]:42707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUdql-00059T-T7 for submit@debbugs.gnu.org; Mon, 19 Oct 2020 18:41:56 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:39404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUdql-000594-2f for 41852@debbugs.gnu.org; Mon, 19 Oct 2020 18:41:55 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id t21so960157eds.6 for <41852@debbugs.gnu.org>; Mon, 19 Oct 2020 15:41:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=t12ZMErT6MINcxk8Zq7JAFFHjEGq78hyiP5b8Qh3TeE=; b=B3QUXWRF+pQ2+TYt6Y9R+gNbnGuOomUmL8j70iYF4/lO8zoFSXtAde+ZThegG4jj0Z WHEspJDEfXsQmW6qP0di6AO4iEkWf3c/M4Ps4GKtT9TwcU7Uoi4S0iJ2+4+873r+SO8U X2BQjJeXP/+Fw3KDaPoKBNtuhXkFI4cWDQrS+E8eKRsRKANDUjt6bSlECgmYLSNcoJyV LFtzjKR8RuDyFfs93xt9RXw94s20K6iEooVzNrBdAIFZbWJ9009jjVFDFNVONWnmBWHN kkm5aHXz0AJQsBIjfSqhbQssuMV2IwiyUxMOlIeJH6TYOZT88mSpGL9A0vjK7COMfatr eBQQ== X-Gm-Message-State: AOAM5316Xw8X1sWUbij77LEsv/DTMhPxqebyr9gsU4uo6HQXw1KRLhdO 1lDzrZrKTnOxOQuHLUoqS9XZ0gZ2Q2tRB2ja53OFEQtWAUE= X-Google-Smtp-Source: ABdhPJyj3emIk2v/hWwUI2Va7sW8tToupg62n1Zi6KH4XsMvNljObL/wz48g9LcgDxApwikn/WP8JZZTgsIZQfsj0jo= X-Received: by 2002:aa7:c259:: with SMTP id y25mr2041871edo.249.1603147309429; Mon, 19 Oct 2020 15:41:49 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Oct 2020 15:41:48 -0700 In-Reply-To: <83wnzmnioj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191052 Archived-At: Eli Zaretskii writes: > Can we continue supporting text-scale-mode-remapping in > text-scale-mode--remappings? I'd like to avoid backward-incompatible > changes if possible. Do you mean something like this? diff --git a/lisp/face-remap.el b/lisp/face-remap.el index 4d7be7d65a..377976782f 100644 --- a/lisp/face-remap.el +++ b/lisp/face-remap.el @@ -219,7 +219,8 @@ text-scale-mode-step ;; current remapping cookie for text-scale-mode (defvar text-scale-mode-remapping nil) -(make-obsolete-variable 'text-scale-mode-remapping "no longer used." "28.1") +(make-obsolete-variable 'text-scale-mode-remapping + 'text-scale-mode--remappings "28.1") (defvar text-scale-mode--remappings nil "List of current remapping cookies for `text-scale-mode'.") @@ -239,8 +240,10 @@ text-scale-remap-header-line-face (make-variable-buffer-local 'text-scale-header-line) (defun face-remap--clear-remappings () - (dolist (remapping text-scale-mode--remappings) + (dolist (remapping (cons text-scale-mode-remapping ; backwards-compatibility + text-scale-mode--remappings)) (face-remap-remove-relative remapping)) + (setq text-scale-mode-remapping nil) ; backwards-compatibility (setq text-scale-mode--remappings nil)) (defun face-remap--remap-face (sym) > Do mouse clicks work well, even if you click close to the edges of a > much-enlarged header-line? This seems to work as expected, yes. I've tested with both very large and very small text sizes. > Otherwise the changes look fine to me, thanks. Thank you for reviewing.