all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: 36610@debbugs.gnu.org
Subject: bug#36610: [PATCH] Make finder-exit use quit-window
Date: Fri, 12 Jul 2019 00:53:34 +0200	[thread overview]
Message-ID: <CADwFkmmG4EPaDg-SfW_A4XW=F+gKG21D51L8RbBqzS87VyGRPw@mail.gmail.com> (raw)
In-Reply-To: <CADwFkmmon3upMW006bO2HiQ1bULErJWPeV36V=a7zOkU9FiPcQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Stefan Kangas <stefan@marxist.se> writes:
> (I'll send the patch in a separate message once this is assigned a bug
> number.)

Patch attached.

Thanks,
Stefan Kangas

[-- Attachment #2: 0001-Make-finder-exit-use-quit-window-Bug-33610.patch --]
[-- Type: application/octet-stream, Size: 1004 bytes --]

From cb96a793c793489727b168ddc237743410f95deb Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Fri, 12 Jul 2019 00:43:12 +0200
Subject: [PATCH] Make finder-exit use quit-window (Bug#33610)

* lisp/finder.el (finder-exit): Quit window instead of
deleting.
---
 lisp/finder.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/finder.el b/lisp/finder.el
index ad9441210c..89706cf7db 100644
--- a/lisp/finder.el
+++ b/lisp/finder.el
@@ -465,11 +465,12 @@ finder-summary
 
 (defun finder-exit ()
   "Exit Finder mode.
-Delete the window and kill all Finder-related buffers."
+Quit the window and kill all Finder-related buffers."
   (interactive)
-  (ignore-errors (delete-window))
   (let ((buf "*Finder*"))
-    (and (get-buffer buf) (kill-buffer buf))))
+    (if (equal (current-buffer) buf)
+        (quit-window t)
+      (and (get-buffer buf) (kill-buffer buf)))))
 
 (defun finder-unload-function ()
   "Unload the Finder library."
-- 
2.21.0


  reply	other threads:[~2019-07-11 22:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 22:48 bug#36610: [PATCH] Make finder-exit use quit-window Stefan Kangas
2019-07-11 22:53 ` Stefan Kangas [this message]
2019-07-20  9:24   ` Eli Zaretskii
2019-07-11 22:57 ` Stefan Kangas
2019-07-12  6:34   ` Eli Zaretskii
2019-07-12  7:20     ` Stefan Kangas
2019-07-12  7:57       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmmG4EPaDg-SfW_A4XW=F+gKG21D51L8RbBqzS87VyGRPw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=36610@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.