From: Stefan Kangas <stefan@marxist.se>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 21521@debbugs.gnu.org, Stefano Pacifico <github@pacifico.cc>
Subject: bug#21521: 24.5; pdb default suggested command
Date: Thu, 8 Aug 2019 04:40:32 +0200 [thread overview]
Message-ID: <CADwFkmmFECLKFSteEECDRT5z297LH_CiU7406xe4BWGDRBUpcQ@mail.gmail.com> (raw)
In-Reply-To: <878ssry6b8.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
Noam Postavsky <npostavs@gmail.com> writes:
>
> Stefan Kangas <stefan@marxist.se> writes:
>
> > +(defcustom gud-pdb-command-name
> > + (if (executable-find "pdb") "pdb" "python -m pdb")
> > "File name for executing the Python debugger.
> > This should be an executable on your path, or an absolute file name."
> > :type 'string
>
> "python -m pdb" doesn't seem to be "an executable on your path, or an
> absolute file name", so I think the docstring needs updating too
> (assuming this setting does actually work).
You are correct. The attached patch fixes this and adds a version tag.
Thanks,
Stefan Kangas
[-- Attachment #2: 0001-Use-python-m-pdb-when-pdb-is-missing-in-M-x-pdb.patch --]
[-- Type: application/octet-stream, Size: 992 bytes --]
From 8aed28a72c08e6b6585792341bce159249426381 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Thu, 11 Jul 2019 05:51:18 +0200
Subject: [PATCH] Use "python -m pdb" when "pdb" is missing in M-x pdb
* lisp/progmodes/gud.el (gud-pdb-command-name): Use "python -m pdb"
when "pdb" is missing. (Bug#21521)
---
lisp/progmodes/gud.el | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lisp/progmodes/gud.el b/lisp/progmodes/gud.el
index b6a4ad3cd0..30d4b19911 100644
--- a/lisp/progmodes/gud.el
+++ b/lisp/progmodes/gud.el
@@ -1673,9 +1673,10 @@ gud-pdb-marker-filter
output))
-(defcustom gud-pdb-command-name "pdb"
- "File name for executing the Python debugger.
-This should be an executable on your path, or an absolute file name."
+(defcustom gud-pdb-command-name
+ (if (executable-find "pdb") "pdb" "python -m pdb")
+ "Command that executes the Python debugger."
+ :version "27.1"
:type 'string
:group 'gud)
--
2.22.0
next prev parent reply other threads:[~2019-08-08 2:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-20 1:41 bug#21521: 24.5; pdb default suggested command Stefano Pacifico
2015-09-22 2:16 ` Stefano Pacifico
2015-09-22 7:54 ` Eli Zaretskii
2015-09-22 19:20 ` Stefano Pacifico
2015-09-23 6:28 ` Eli Zaretskii
2015-09-24 18:24 ` Stefano Pacifico
2019-07-11 4:08 ` Stefan Kangas
2019-07-21 11:29 ` Noam Postavsky
2019-08-08 2:40 ` Stefan Kangas [this message]
2019-08-09 0:09 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmmFECLKFSteEECDRT5z297LH_CiU7406xe4BWGDRBUpcQ@mail.gmail.com \
--to=stefan@marxist.se \
--cc=21521@debbugs.gnu.org \
--cc=github@pacifico.cc \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.