From: Stefan Kangas <stefan@marxist.se>
To: Gabriel <gabriel376@hotmail.com>
Cc: 47124@debbugs.gnu.org
Subject: bug#47124: 28.0.50; [PATCH] Init archive and add noconfirm to 'package-install-selected-packages'
Date: Sat, 13 Mar 2021 13:01:14 -0600 [thread overview]
Message-ID: <CADwFkmmEAPkX9XU3-N93GpPY5=x1nL9KC5kw-VLDphuSUx9Tbw@mail.gmail.com> (raw)
In-Reply-To: <CH2PR01MB5879A39A2A2A8F81521BEA728B6E9@CH2PR01MB5879.prod.exchangelabs.com> (Gabriel's message of "Sat, 13 Mar 2021 14:15:07 -0300")
Gabriel <gabriel376@hotmail.com> writes:
> This patch adds the following to 'package-install-selected-packages':
> - a call to 'package--archives-initialize', to initialize the archive
> contents, similar to how 'package-install' works;
> - a new optional argument NOCONFIRM, to don't ask for confirmation when
> installing new packages.
LGTM, with one minor nit:
> ;;;###autoload
> -(defun package-install-selected-packages ()
> +(defun package-install-selected-packages (&optional noconfirm)
> "Ensure packages in `package-selected-packages' are installed.
> -If some packages are not installed propose to install them."
> +If some packages are not installed, propose to install them.
> +If optional argument NOCONFIRM is non-nil, don't ask for
> +confirmation to install packages."
> (interactive)
> ;; We don't need to populate `package-selected-packages' before
> ;; using here, because the outcome is the same either way (nothing
> ;; gets installed).
> + (package--archives-initialize)
I would put this new line above the comment, as the comment relates to
this next line:
> (if (not package-selected-packages)
> (message "`package-selected-packages' is empty, nothing to install")
> (let* ((not-installed (seq-remove #'package-installed-p package-selected-packages))
> @@ -2220,10 +2223,11 @@ package-install-selected-packages
> (difference (- (length not-installed) (length available))))
> (cond
> (available
> - (when (y-or-n-p
> - (format "Packages to install: %d (%s), proceed? "
> - (length available)
> - (mapconcat #'symbol-name available " ")))
> + (when (or noconfirm
> + (y-or-n-p
> + (format "Packages to install: %d (%s), proceed? "
> + (length available)
> + (mapconcat #'symbol-name available " "))))
> (mapc (lambda (p) (package-install p 'dont-select)) available)))
> ((> difference 0)
> (message "Packages that are not available: %d (the rest is already installed), maybe you need to `M-x package-refresh-contents'"
next prev parent reply other threads:[~2021-03-13 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 17:15 bug#47124: 28.0.50; [PATCH] Init archive and add noconfirm to 'package-install-selected-packages' Gabriel
2021-03-13 19:01 ` Stefan Kangas [this message]
2021-03-13 19:16 ` Gabriel
2021-03-15 2:29 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmmEAPkX9XU3-N93GpPY5=x1nL9KC5kw-VLDphuSUx9Tbw@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=47124@debbugs.gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.