Re: [NonGNU ELPA] New package: eldoc-diffstat

[Stefan Kangas <stefankangas@gmail.com>]

Tassilo Horn <tsdh@gnu.org> writes:

>> I would like to submit a new package to NonGNU ELPA: eldoc-diffstat.
>>
>>   https://github.com/kljohann/eldoc-diffstat/
>
> I'm using it since a couple of days using package-vc and like it very
> much, so I took the liberty to add it to NonGNU ELPA.

Thanks, this seems pretty useful.  I can see myself wanting to have it
on sometimes, but not always, so I'd appreciate it being a minor mode
that I could toggle, instead of just a function.

When the mode is toggled on, it could detect automatically that it's in
a magit buffer, and do the `eldoc-add-command` setup for users
automatically.

Should we have something like this built-in?

Here are some more wishlist items:

- An option to use a maximum (or fixed) number of lines
- Caching the results for the current buffer to get instant results

> I think you could add a bit more configuration hints to the README.md,
> e.g., where you say that one should call eldoc-diffstat-setup in the
> desired buffer or mode hook, provide some typical examples like:
>
>   (add-hook 'log-view-mode-hook #'eldoc-diffstat-setup)
>   (add-hook 'vc-annotate-mode-hook #'eldoc-diffstat-setup)
>   (add-hook 'magit-status-mode-hook #'eldoc-diffstat-setup)
>   (add-hook 'magit-log-mode-hook #'eldoc-diffstat-setup)

+1

There could also be a global minor mode that would enable this in as
many places as possible.