From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#28385: ert "should" macros to not be globally visible Date: Sun, 29 Sep 2019 03:26:17 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="87651"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 28385@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 29 03:27:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iENzV-000MgD-Kw for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 03:27:13 +0200 Original-Received: from localhost ([::1]:35832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iENzU-0000U4-C4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Sep 2019 21:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54443) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iENzN-0000Ti-Su for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 21:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iENzK-0005Fm-C5 for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 21:27:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iENzK-0005Fi-9C for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 21:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iENzK-0001q5-2Y for bug-gnu-emacs@gnu.org; Sat, 28 Sep 2019 21:27:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2019 01:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28385 X-GNU-PR-Package: emacs Original-Received: via spool by 28385-submit@debbugs.gnu.org id=B28385.15697203997037 (code B ref 28385); Sun, 29 Sep 2019 01:27:02 +0000 Original-Received: (at 28385) by debbugs.gnu.org; 29 Sep 2019 01:26:39 +0000 Original-Received: from localhost ([127.0.0.1]:51724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iENyx-0001pQ-5p for submit@debbugs.gnu.org; Sat, 28 Sep 2019 21:26:39 -0400 Original-Received: from mail-pf1-f171.google.com ([209.85.210.171]:33559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iENys-0001p6-Er for 28385@debbugs.gnu.org; Sat, 28 Sep 2019 21:26:36 -0400 Original-Received: by mail-pf1-f171.google.com with SMTP id q10so3567881pfl.0 for <28385@debbugs.gnu.org>; Sat, 28 Sep 2019 18:26:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=VuPapug1E2nuCM2xGrBGyvcep1/c3InrvvzRVDVD+PI=; b=sSnkaR/jVkjod+RJi6ct+UGgzQEIToQfCGO/TXBaxKw7qSVisM6muGMg2CMYM2yfuz E9l23JFeQqA1A+cone3yxftp+e3PiOURmTxWLVyuIw2oMZ/BEDnaWUGQDkdcd2co4qRl a7unYE2PBepC3bVC6zwJM2ht4JF7XAsMVhwcPmk9eqT41Nj6Wrc825qJCJhneTaepHcB 0iNSJG85PRACmgZetsjVjSrqYsFiBCMp0jdmNEIvasIBleWfd0Ny5DmhlHagktBkr2tk ll5FodHoHlfkF76RfVC9kI+b3WpmGDWGCMKR5ABE18vP9d6p5p600Fs831a2GjObBFJS Lk5w== X-Gm-Message-State: APjAAAU8m8ccgyh66L6VZ44MAkyMrvZr8+M8sU/4iUQBzI081O4q5O6R s9A6sBOZG3UM3G8eToBsj0EV7GY6/LNwwFQXc2s= X-Google-Smtp-Source: APXvYqz62hWXQIM/ZgqoxtJdtPikRVVpeUJe8+uHitpw44CiB2F//mYU1MELj/EBrxywxqjUfYL8fqLo8McWoty/nes= X-Received: by 2002:a63:720f:: with SMTP id n15mr16605218pgc.198.1569720388649; Sat, 28 Sep 2019 18:26:28 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167567 Archived-At: Lars Ingebrigtsen writes: > Glenn Morris writes: > >> Now "should", "should-not", and "should-error" are globally defined as >> macros (with no "ert-" prefix). They are only useful inside ert-deftests. >> Perhaps they should steal a trick from the similar "skip-unless", which >> is not globally visible. The global definition is "ert--skip-unless", >> and the ert-deftest macro basically makes "skip-unless" an alias for >> this inside the body of a test. This seems cleaner. > > When writing tests, I find it convenient that I can `C-x C-e' > > (should ...) > > terms. I mean, I could just `C-x C-e' the insides of the form instead, > but still... I agree; I do this all the time when developing tests. C-x C-e inside the form doesn't help much e.g. when you have a let form doing some setup that contains multiple should statements. (See test/lisp/bookmark-tests.el for an example.) With all due respect to Glenn, I would suggest to close this as wontfix. Best regards, Stefan Kangas