From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2 Date: Wed, 10 Jan 2024 06:55:30 -0800 Message-ID: References: <87o7dtmi17.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33227"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii To: Stephen Berman , 68367@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 15:56:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNa0G-0008Nc-Oq for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 15:56:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNZzx-0007dk-DX; Wed, 10 Jan 2024 09:56:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNZzw-0007dM-7b for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 09:56:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNZzv-0002mV-VT for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 09:56:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNZzu-0007je-Iq for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 09:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68367 X-GNU-PR-Package: emacs Original-Received: via spool by 68367-submit@debbugs.gnu.org id=B68367.170489853829063 (code B ref 68367); Wed, 10 Jan 2024 14:56:02 +0000 Original-Received: (at 68367) by debbugs.gnu.org; 10 Jan 2024 14:55:38 +0000 Original-Received: from localhost ([127.0.0.1]:39888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZzW-0007Yg-Df for submit@debbugs.gnu.org; Wed, 10 Jan 2024 09:55:38 -0500 Original-Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:45459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNZzT-0007YR-M0 for 68367@debbugs.gnu.org; Wed, 10 Jan 2024 09:55:36 -0500 Original-Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50ea9e189ebso4409806e87.3 for <68367@debbugs.gnu.org>; Wed, 10 Jan 2024 06:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704898531; x=1705503331; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=ODZyM2izkMUcZg/3n/DggVBkIitU+glZc25KzSqb2dA=; b=SCA2MPYypsqo3MQUogj1gubCzFpoEhXotMoNtYj7UXp6013S1CtD3e1xOWz3I692fB 1ddkI4oFVmupV4+AW+OjoojlnPcyv3Bcmrui+YQEhKigib71SIHKnYNVe9erzHNbp307 H42snCjW4BvP4rgcnBS0J0srw4wYTlYmC++J2qJZp34++vHby0Qx4FEHTschjam22dRV Lil1y32HzqfHhtHm2weQYJHej64L0tp3Z7870TJkQjgQDRz+8OZy1QX+6OamiaEYmsIu r/ldSG8hKwOzJiqGOsu06Qcm7BjclWTqssPfxfSZRCIHtTnNu5PsOOobyu/OC2OQc61w 6OJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704898531; x=1705503331; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ODZyM2izkMUcZg/3n/DggVBkIitU+glZc25KzSqb2dA=; b=ZMkYqs3R1CZlMMBN6ODNbZlZUsOaIEvIuFekwwYYQF9qXyyFlo+F/l78Zk7GgwXor5 9guds2zEKIfeed9iCvcXmLYBUex7XJjOc2Q5sUT5lqgaggMtW3MmT8/7uC+aEYD1Mf1F 4tPZrGSDeZNgDQsQjn4qCG2BdN/4t+vAbtoWRW8yqCzdJ37YOeyoVMcuWtYEBmKW4yQk wQBstxc2CTChLgQmF99gg0KDssDdPQ3EzWDz44CuECqDuoqA7Ik7eBZ9DXmqlifmURTB NATHSKWGOaWpEFTDtNXshPQEorNImAiEsZOk1Z5TwtuEYafCc678M2OrmKv13LEHE6/A ecVg== X-Gm-Message-State: AOJu0Yy9BwXjWPlRYfQFZ3yW76SEV3XH/E2wSPE04nUMN3mr7Z5hD52p DDjlp50IEf6tRTPZI9xKHfm6zRtsAo3t4WYmoP4= X-Google-Smtp-Source: AGHT+IFHibqa53wfIbh5w07B1bPT44RfQTKKVsgErICEGkl+D4XxXR0ijhjhJe0dTuYQ5fTk4wH0lQFOXxiyfWtGYwg= X-Received: by 2002:ac2:4959:0:b0:50e:6bf0:49c9 with SMTP id o25-20020ac24959000000b0050e6bf049c9mr438710lfi.53.1704898530778; Wed, 10 Jan 2024 06:55:30 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 06:55:30 -0800 In-Reply-To: <87o7dtmi17.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277754 Archived-At: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > My /etc/fstab file contains a line for the file system cgroup2 (i.e. for > cgroup v2 instead of cgroup for cgroup v1). I just learned about > etc-fstab-generic-mode and after loading generic-x and visiting > /etc/fstab, I saw that in the line for cgroup2, the entry in the type > column is fontified in the default face, not in font-lock-keyword-face, > unlike all other file system types in my /etc/fstab file. This patch > fixes the misfontification: > > diff --git a/lisp/generic-x.el b/lisp/generic-x.el > index b4ae0225943..373bfad92dd 100644 > --- a/lisp/generic-x.el > +++ b/lisp/generic-x.el > @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode > "cd9660" > "cfs" > "cgroup" > + "cgroup2" > "cifs" > "coda" > "coherent" Thanks, but could you please reformat this using `git format-patch -1`? > While the misfontification isn't a regression -- the support for cgroups > (but only for cgroup v1) in etc-fstab-generic-mode was added in January > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e., > omitting cgroup2 was presumably an oversight in that commit. I don't really have an opinion, but sounds good to me. Eli?