Re: master c669afc: Add term/st.el (Bug#33182)

Re: master c669afc: Add term/st.el (Bug#33182)

[Stefan Monnier]

> +;;; st.el --- terminal initialization for st  -*- lexical-binding:t -*-
> +;; Copyright (C) 2020 Free Software Foundation, Inc.
> +
> +(require 'term/xterm)
> +
> +(defun terminal-init-st ()
> +  "Terminal initialization function for st."
> +  (tty-run-terminal-initialization (selected-frame) "xterm"))

Could you add the customary `;;; Code:` and more importantly some
information (description and/or URL) of what is `st`?


        Stefan

Re: master c669afc: Add term/st.el (Bug#33182)

[Stefan Kangas]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +;;; st.el --- terminal initialization for st  -*- lexical-binding:t -*-
>> +;; Copyright (C) 2020 Free Software Foundation, Inc.
>> +
>> +(require 'term/xterm)
>> +
>> +(defun terminal-init-st ()
>> +  "Terminal initialization function for st."
>> +  (tty-run-terminal-initialization (selected-frame) "xterm"))
>
> Could you add the customary `;;; Code:` and more importantly some
> information (description and/or URL) of what is `st`?

Why not, but several files in lisp/term are lacking such headers.
Including lisp/term/konsole.el which I based this addition on.

I had assumed that there was some reason for that (e.g. they are too
insignificant).  If there isn't, should we then add these headers to the
rest of them too?  And if yes, should we add all the verbiage, or just
parts of it?  It seems like many are currently lacking the GPL notice,
for example.

Best regards,
Stefan Kangas

Re: master c669afc: Add term/st.el (Bug#33182)

[Stefan Monnier]

> Why not, but several files in lisp/term are lacking such headers.

I don't care very much about the headers, to be honest, tho I think it's
good to have the "Code:" (it's what?  12 bytes?).

What I'm more interested in is a description/link because `st` is a bit
too short not to risk being ambiguous.


        Stefan

Re: master c669afc: Add term/st.el (Bug#33182)

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> What I'm more interested in is a description/link because `st` is a bit
> too short not to risk being ambiguous.

Good point.  How about the attached?

Best regards,
Stefan Kangas

[-- Attachment #2: 0001-Avoid-ambiguity-about-what-st-refers-to.patch --]
[-- Type: text/x-patch, Size: 765 bytes --]

From e2d0944bb42a86799bb5cd038df858b502ebceda Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Tue, 11 Aug 2020 09:23:40 +0200
Subject: [PATCH] Avoid ambiguity about what st refers to

* lisp/term/st.el: Add link to website.
---
 lisp/term/st.el | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/lisp/term/st.el b/lisp/term/st.el
index 3a15576ecc..617664bb26 100644
--- a/lisp/term/st.el
+++ b/lisp/term/st.el
@@ -1,6 +1,14 @@
 ;;; st.el --- terminal initialization for st  -*- lexical-binding:t -*-
+
 ;; Copyright (C) 2020 Free Software Foundation, Inc.
 
+;;; Commentary:
+
+;; Support for the st terminal emulator.
+;; https://st.suckless.org/
+
+;;; Code:
+
 (require 'term/xterm)
 
 (defun terminal-init-st ()
-- 
2.28.0

Re: master c669afc: Add term/st.el (Bug#33182)

[Lars Ingebrigtsen]

Stefan Kangas <stefankangas@gmail.com> writes:

> +;;; Commentary:
> +
> +;; Support for the st terminal emulator.
> +;; https://st.suckless.org/
> +
> +;;; Code:
> +

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master c669afc: Add term/st.el (Bug#33182)

[Stefan Monnier]

>> What I'm more interested in is a description/link because `st` is a bit
>> too short not to risk being ambiguous.
> Good point.  How about the attached?

LGTM, thanks,


        Stefan