all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: 20148@debbugs.gnu.org
Subject: bug#20148: 24.4: function `bookmark-get-bookmark'
Date: Sun, 26 May 2019 12:12:33 +0200	[thread overview]
Message-ID: <CADwFkmm=DtwiJo1nDFoos1fnAH=Z9+1zRRQM24BCekAiJq9kuw@mail.gmail.com> (raw)
In-Reply-To: <550BA52D.1080805@gmx.com>


[-- Attachment #1.1: Type: text/plain, Size: 178 bytes --]

The attached patch fixes the docstring as suggested above.

From the above discussion, I believe this bug report can be closed once
this has
been applied.

Thanks,
Stefan Kangas

[-- Attachment #1.2: Type: text/html, Size: 298 bytes --]

[-- Attachment #2: fix-docstring-of-bookmark-get-bookmark.patch --]
[-- Type: text/x-patch, Size: 987 bytes --]

From a874f231ba0216ca2c3feedaae8ddb32f378f80e Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sun, 26 May 2019 12:04:56 +0200
Subject: [PATCH] Fix docstring of bookmark-get-bookmark

* bookmark.el (bookmark-get-bookmark): Fix docstring.
---
 lisp/bookmark.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index b1fe690dac..5c14f705eb 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -334,7 +334,9 @@ bookmark-get-bookmark
 If BOOKMARK-NAME-OR-RECORD is a string, look for the corresponding
 bookmark record in `bookmark-alist'; return it if found, otherwise
 error.  Else if BOOKMARK-NAME-OR-RECORD is already a bookmark record,
-just return it."
+just return it.
+Signal an error if bookmark is invalid.  If optional argument
+NOERROR is non-nil, return nil instead."
   (cond
    ((consp bookmark-name-or-record) bookmark-name-or-record)
    ((stringp bookmark-name-or-record)
-- 
2.11.0


  parent reply	other threads:[~2019-05-26 10:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20  4:42 bug#20148: 24.4: function `bookmark-get-bookmark' Boruch Baum
2015-03-20  5:04 ` Drew Adams
2015-03-20 11:04   ` Boruch Baum
2015-03-20 14:31     ` Stefan Monnier
2015-03-20 14:44       ` Boruch Baum
2019-05-26 10:12 ` Stefan Kangas [this message]
2019-05-30 12:38   ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkmm=DtwiJo1nDFoos1fnAH=Z9+1zRRQM24BCekAiJq9kuw@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=20148@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.