From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51262: [PATCH] Don't use color escape sequences in `vc-git-expanded-log-entry' Date: Mon, 18 Oct 2021 22:16:11 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51262@debbugs.gnu.org To: Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 07:17:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mchUu-0003Tg-1O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 07:17:12 +0200 Original-Received: from localhost ([::1]:38164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mchUs-0005YV-8p for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 01:17:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mchUl-0005Xn-6F for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 01:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37541) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mchUk-00061a-UN for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 01:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mchUk-0003qz-HL for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 01:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 05:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51262 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51262-submit@debbugs.gnu.org id=B51262.163462058114758 (code B ref 51262); Tue, 19 Oct 2021 05:17:02 +0000 Original-Received: (at 51262) by debbugs.gnu.org; 19 Oct 2021 05:16:21 +0000 Original-Received: from localhost ([127.0.0.1]:49086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mchU4-0003px-Tf for submit@debbugs.gnu.org; Tue, 19 Oct 2021 01:16:21 -0400 Original-Received: from mail-pg1-f175.google.com ([209.85.215.175]:45658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mchU1-0003pJ-EV for 51262@debbugs.gnu.org; Tue, 19 Oct 2021 01:16:17 -0400 Original-Received: by mail-pg1-f175.google.com with SMTP id f5so18262161pgc.12 for <51262@debbugs.gnu.org>; Mon, 18 Oct 2021 22:16:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc :content-transfer-encoding; bh=jMyyBk1Vc4UZpozWoI7YkG0ybOhQRJiiqEfqPT+yJ+M=; b=F08g4gw7Pz3uNpZ+1vOfm1dFxQdH5cWxhM19H7O3av/CiQ6Du4dOw8hT54fJGtHZUk HbnW0HtvOza3Nmfc5M9FeuFwiZbxXOkg5V40WKfc0eXgRAk4TOErLpIVyG5Ci7KUeNk4 ZSjq9RYRKvTp17eVFGihy1XK5BENFCKRqum7Rit6IYwOytJBfZ/Sfm8h7na+U2uNTDKp MBKJNSmjNsR92YRkewEYQ+RZacxE0/2CBbB+23k96al4YtY/gOXmQPBb+X72AjUXMTOZ 4WHJZEgDAjV6JrXIEVRZlJd0Yi0UBLfQdMiSdZf38S1pDPIITIx11cYJpnlHWRAjEns8 ksuA== X-Gm-Message-State: AOAM532jciVpuV7TY0hfqdXbS7unuRYw78VnWNJ41OoPYOUBZR2pHyIz LdfOFwwv/d4EuFA5Jx+lhBRPt5qFlNr2kmN2xtgxTRmV X-Google-Smtp-Source: ABdhPJwBoyeMrNWcF/Ixu7Cd7xrMzFzsmZWReYhacTwaZC2GbFKQ5GonlhVg+7CbFtrgW76bS2GPI9NLD8KpXxhDcd4= X-Received: by 2002:a63:9d06:: with SMTP id i6mr27248207pgd.42.1634620571832; Mon, 18 Oct 2021 22:16:11 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 18 Oct 2021 22:16:11 -0700 In-Reply-To: ("Jan =?UTF-8?Q?Syn=C3=A1=C4=8Dek?="'s message of "Mon, 18 Oct 2021 12:45:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217542 Archived-At: Jan Syn=C3=A1=C4=8Dek writes: > From acbfec361709c5eebafb9a957e76f70500083cf0 Mon Sep 17 00:00:00 2001 > From: Jan Synacek > Date: Mon, 18 Oct 2021 12:34:38 +0200 > Subject: [PATCH] Don't use color escape sequences in > `vc-git-expanded-log-entry' > > * lisp/vc/vc-git.el (vc-git-expanded-log-entry): Use --no-color in git > invocation. > > Copyright-paperwork-exempt: yes > --- > lisp/vc/vc-git.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index 35c0838dd6..3f89fad235 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1323,7 +1323,7 @@ vc-git-show-log-entry > > (defun vc-git-expanded-log-entry (revision) > (with-temp-buffer > - (apply #'vc-git-command t nil nil (list "log" revision "-1" "--")) > + (apply #'vc-git-command t nil nil (list "log" revision "-1" "--no-c= olor" "--")) > (goto-char (point-min)) > (unless (eobp) > ;; Indent the expanded log entry. Thanks for the patch. Could you add some details here, such as what problem it is supposed to fix? How can I reproduce the issue here, starting from emacs -Q?