From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#21319: `package-install-file' fails with CRLF (Windows) line endings Date: Tue, 22 Oct 2019 16:50:44 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="87319"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 21319@debbugs.gnu.org To: steckerhalter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 22 16:52:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMvW7-000MZz-1l for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 16:52:11 +0200 Original-Received: from localhost ([::1]:59716 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMvW5-0001cR-N0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 10:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50724) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMvVz-0001bo-4t for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMvVy-000127-4Q for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51470) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMvVy-00011t-1D for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMvVx-0003Q6-Uq for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2019 14:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21319 X-GNU-PR-Package: emacs Original-Received: via spool by 21319-submit@debbugs.gnu.org id=B21319.157175586413075 (code B ref 21319); Tue, 22 Oct 2019 14:52:01 +0000 Original-Received: (at 21319) by debbugs.gnu.org; 22 Oct 2019 14:51:04 +0000 Original-Received: from localhost ([127.0.0.1]:60291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvV2-0003Op-CC for submit@debbugs.gnu.org; Tue, 22 Oct 2019 10:51:04 -0400 Original-Received: from mail-pg1-f177.google.com ([209.85.215.177]:45723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvUz-0003OH-Mz for 21319@debbugs.gnu.org; Tue, 22 Oct 2019 10:51:02 -0400 Original-Received: by mail-pg1-f177.google.com with SMTP id r1so10081360pgj.12 for <21319@debbugs.gnu.org>; Tue, 22 Oct 2019 07:51:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=32dlg6m5wQ2r+DUc5z9szRqTwBf6xlqhvgjTqUJWvo8=; b=iH69W1I4NkjtEG6nQJhPmlGWWg1fu1E6osdQOH7MLVCJ+/7X6qpakERX09EgUeeGl8 1y9/794i4UO3vJfdop2pM0c+7d5Sh12XXFHPY8F8KZbEHvWG+CmeSRKOdLpHhw0Uz1sI 2tkiBVNQlemz+P95gu/85O+ozGRoP14OlXIYOls59kxQDbWdA60QR3cHJibKU6f5s/Ad fAE7LEKFVlcEuL69YQ+QHY8ecm41fbgA+TPUNRZEGKLvW0vgHKHJHsVUuhYCiW6Ii0V0 COSK5ycmSfqqq1QTkA6aT/zZLPI63Xh849z0OSan9C0ZeblIOaWnv3hcY3qnOv7o+gt0 iJfQ== X-Gm-Message-State: APjAAAVJSvFUtj+ow8d6Zprzn9ObEI6SAKcc6O5shAnFjJyPR+fu9nyE zf6lY4/r30IKNt1Zb6wSwlaYPYsu0zc+ZEnNqPE= X-Google-Smtp-Source: APXvYqy/HAYOiGSQwewiGO2yocjLRrXzY00i/jN+Vq6ehP2S3lqFzKl4nwk6VnTRtaMC4jX+idJ6iSHEBnGOLZHdSas= X-Received: by 2002:a17:90a:f491:: with SMTP id bx17mr5311348pjb.106.1571755855617; Tue, 22 Oct 2019 07:50:55 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169982 Archived-At: Stefan Kangas writes: > steckerhalter writes: > > > package.el contains this code: > > > > (defun package-install-file (file) > > "Install a package from a file. > > The file can either be a tar file or an Emacs Lisp file." > > (interactive "fPackage file name: ") > > (with-temp-buffer > > (insert-file-contents-literally file) > > (when (string-match "\\.tar\\'" file) (tar-mode)) > > (package-install-from-buffer))) > > > > Since `insert-file-contents-literally' does not do any conversion > > `package-buffer-info' fails to parse the info if the file is .el and > > contains CRLF line endings. It then errors out with: > > > > Debugger entered--Lisp error: (error "Package lacks a \"Version\" or > > \"Package-Version\" header") > > signal(error ("Package lacks a \"Version\" or \"Package-Version\" header")) > > error("Package lacks a \"Version\" or \"Package-Version\" header") > > package-buffer-info() > > > > This affects all recent Emacs versions (including trunk). > > This was reported 4 years ago, but unfortunately never got a reply at > the time. > > Are you still seeing this on a recent version of Emacs? If yes, could > you please provide a minimal example file which fails to install? > > Also, why does your file have these line endings in the first place? > Was this file written in Emacs? I'm trying to understand if this is > an important use case or the common scenario for users of MS-Windows, > since I don't use it myself. This was merged with Bug#20309, which was closed. I suspect that the bugs are most probably different, so I've unmerged this bug and reopened it. Please disregard any message saying that this bug is closed for now. Best regards, Stefan Kangas