From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#30085: 25.2: Documentation for cua-rectangle-mark-mode Date: Mon, 26 Oct 2020 18:50:35 -0700 Message-ID: References: <20180112071426.uq2x3nlcs6jo57hm@E15-2016.optimum.net> <83mv1j2zz4.fsf@gnu.org> <0e8d20ba-84c9-1509-0f52-b8b4b649e00a@cua.dk> <834lnq3o4i.fsf@gnu.org> <20180321124836.puwmknqvo6zketnk@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000e9fb8605b29d4559" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23858"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 30085@debbugs.gnu.org, Kim Storm To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 27 02:51:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXE8p-00065A-8E for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Oct 2020 02:51:15 +0100 Original-Received: from localhost ([::1]:44568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXE8n-0001TV-Rz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Oct 2020 21:51:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXE8d-0001T9-4x for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 21:51:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58898) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXE8c-0000B2-0q for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 21:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXE8b-0007Ne-Vg for bug-gnu-emacs@gnu.org; Mon, 26 Oct 2020 21:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Oct 2020 01:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30085 X-GNU-PR-Package: emacs Original-Received: via spool by 30085-submit@debbugs.gnu.org id=B30085.160376344328342 (code B ref 30085); Tue, 27 Oct 2020 01:51:01 +0000 Original-Received: (at 30085) by debbugs.gnu.org; 27 Oct 2020 01:50:43 +0000 Original-Received: from localhost ([127.0.0.1]:42211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXE8J-0007N4-5w for submit@debbugs.gnu.org; Mon, 26 Oct 2020 21:50:43 -0400 Original-Received: from mail-ed1-f65.google.com ([209.85.208.65]:40001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXE8H-0007Mp-VI for 30085@debbugs.gnu.org; Mon, 26 Oct 2020 21:50:42 -0400 Original-Received: by mail-ed1-f65.google.com with SMTP id p93so1633008edd.7 for <30085@debbugs.gnu.org>; Mon, 26 Oct 2020 18:50:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=aTEzPcMXMYxlakKGRjZxvJWS/XGAcClIv3WYfGCXufw=; b=Xl0fWZzyW9MIEWHxRs4piPWhpnviXJeLsbkoVWvSsbrA60wXLzv394cTa5LtBrOM6c 0vmQSJLyV5+4ZaVbPcjhhES21skqdLP88Le4zlZamWESrnS192EogaJaeBKy+V7VB5mq 2NxwJZ9G2+wZ00+YTtiw/2Y3XLxY/dNH/pTdQ2sSG6+jZnOXK6BCAnwfwFd0i5iuOIAh DAf+qzJQ9yl6uhUCdQXhIYYo4PkNCFzObHZ/EHitT/wMSlC93IHW9gvyWKn8Fj6Hawq8 HPr4SuknYMjDOzKO5I74TdBEI/y0F723aTKgrpzloPFNXwUXk0cgt+OR5O8ZqRiJh27L v0xg== X-Gm-Message-State: AOAM532FPfugTTgkTlGDZ37eDrnl8djrmtox6CYpvxDKkVCAjwDeuYgJ CuCYqKsKzahMgOOgWQyjf66vLb7sPH2ixmLVmAU= X-Google-Smtp-Source: ABdhPJyLws1ujQRjyiKFVjjv96XEbTs3pPKaN0FbiFkLezU1E8kwufY2TC93IRUxNlSGBRUegQcrFg5bHL7d7VO4moM= X-Received: by 2002:aa7:c694:: with SMTP id n20mr19219074edq.160.1603763436112; Mon, 26 Oct 2020 18:50:36 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 26 Oct 2020 18:50:35 -0700 In-Reply-To: <20180321124836.puwmknqvo6zketnk@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 21 Mar 2018 08:48:36 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191695 Archived-At: --000000000000e9fb8605b29d4559 Content-Type: text/plain; charset="UTF-8" Boruch Baum writes: > 1. The docstring issue, until I realized I should ask. Thanks, I've pushed that part to master in your name with some touch-ups. I also added a ChangeLog entry. See commit cfc70e51c2 on the master branch. > 2. @Kim: At the end of the first diff block, I noted an issue about the > `cua--last-killed-rectangle' data structure. Could you set me right > about it? I left this as a FIXME comment, since it doesn't seem like anyone knows the answer. Hopefully someone so inclined will take a closer look at some point. > 3. I noticed that `M-m' was bound to `cua-copy-rectangle-as-text' > instead of `back-to-indentation', so I took the liberty of writing a > function `cua-resize-rectangle-back-to-indentation' and binding it to > `M-m', which is what most users would expect. If this approved, to > what should be bound `cua-copy-rectangle-as-text' > > 4. Function `cua-resize-rectangle-bot' had a bug in that it always > placed point at the actual (point-max) even though the rectangle > corner would not be there. This would occur when (point-max) was at a > column number smaller than the left edge of the rectangle. The patch > file includes the fix. > > 5. Two commonly used navigation functions, normally bound to `C-a' and > `C-e' were not remapped. (DONE) Could you please provide instructions for how to test the above parts? I don't use this mode and it's not clear to me what to do. Also, could you perhaps split the patch up and make it clear which parts of your code belong to which of the above points? Ideally, if possible, you would also add ChangeLog entries as per etc/CONTRIBUTE. > 6. The help message is remapped from `C-?' to `M-?' for the sanity of > people like me who use emacs-nox and can only perform a `C-?' by > typing `C-x @ c ?'. I don't understand which part of your patch this refers to, or how to test it. Could you please clarify? > 7. The current keybindings are made using an old method of keystroke > definition that I find a bit scary. Is it OK / desirable to change > the method uniformly to use `kbd'? I have no strong opinion on this, but it seems relatively minor. Perhaps it's not worth the code churn. > First slow steps. I've attached a diff with the parts of your patch that I didn't yet push to master. Thanks. --000000000000e9fb8605b29d4559 Content-Type: text/x-diff; charset="US-ASCII"; name="bug30085-left-out.diff" Content-Disposition: attachment; filename="bug30085-left-out.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: 51ce2a77c7be4879_0.1 ZGlmZiAtLWdpdCBhL2xpc3AvZW11bGF0aW9uL2N1YS1yZWN0LmVsIGIvbGlzcC9lbXVsYXRpb24v Y3VhLXJlY3QuZWwKaW5kZXggN2NhOWRjMWFmMS4uNTJjZGNkOTc2NyAxMDA2NDQKLS0tIGEvbGlz cC9lbXVsYXRpb24vY3VhLXJlY3QuZWwKKysrIGIvbGlzcC9lbXVsYXRpb24vY3VhLXJlY3QuZWwK QEAgLTQyMywxMCArNDIzLDIzIEBAIGN1YS1yZXNpemUtcmVjdGFuZ2xlLWJvbAogICAgICAgICAo Y3VhLS1yZWN0YW5nbGUtY29ybmVyIC0xKSkKICAgICAoY3VhLS1yZWN0YW5nbGUtcmVzaXplZCkp KQogCisoZGVmdW4gY3VhLXJlc2l6ZS1yZWN0YW5nbGUtYmFjay10by1pbmRlbnRhdGlvbiAoKQor ICAiUmVzaXplIHJlY3RhbmdsZSB0byBmaXJzdCBub24td2hpdGVzcGFjZSBjaGFyYWN0ZXIgb24g dGhlIGxlZnQuIgorICAoaW50ZXJhY3RpdmUpCisgICh1bmxlc3MgKGJvbHApCisgICAgKGJhY2st dG8taW5kZW50YXRpb24pCisgICAgKGN1YS0tcmVjdGFuZ2xlLWxlZnQgKGN1cnJlbnQtY29sdW1u KSkKKyAgICAoaWYgKGN1YS0tcmVjdGFuZ2xlLXJpZ2h0LXNpZGUpCisgICAgICAgIChjdWEtLXJl Y3RhbmdsZS1jb3JuZXIgLTEpKQorICAgIChjdWEtLXJlY3RhbmdsZS1yZXNpemVkKSkpCisKIChk ZWZ1biBjdWEtcmVzaXplLXJlY3RhbmdsZS1ib3QgKCkKICAgIlJlc2l6ZSByZWN0YW5nbGUgdG8g Ym90dG9tIG9mIGJ1ZmZlci4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKGdvdG8tY2hhciAocG9pbnQt bWF4KSkKKyAgKGxldCAoKGNvbCAoY3VhLS1yZWN0YW5nbGUtY29sdW1uKSkpCisgICAgKHdoZW4g KDwgKGN1cnJlbnQtY29sdW1uKSBjb2wpCisgICAgICAoY3VhLS1mb3J3YXJkLWxpbmUgLTEpKSkK ICAgKG1vdmUtdG8tY29sdW1uIChjdWEtLXJlY3RhbmdsZS1jb2x1bW4pKQogICAoY3VhLS1yZWN0 YW5nbGUtYm90IHQpCiAgIChjdWEtLXJlY3RhbmdsZS1yZXNpemVkKSkKQEAgLTE1MDMsNiArMTUx Niw4IEBAIGN1YS0taW5pdC1yZWN0YW5nbGVzCiAgIChkZWZpbmUta2V5IGN1YS0tcmVjdGFuZ2xl LWtleW1hcCBbcmVtYXAgcHJldmlvdXMtbGluZV0gICAgICAgJ2N1YS1yZXNpemUtcmVjdGFuZ2xl LXVwKQogICAoZGVmaW5lLWtleSBjdWEtLXJlY3RhbmdsZS1rZXltYXAgW3JlbWFwIGVuZC1vZi1s aW5lXSAgICAgICAgICdjdWEtcmVzaXplLXJlY3RhbmdsZS1lb2wpCiAgIChkZWZpbmUta2V5IGN1 YS0tcmVjdGFuZ2xlLWtleW1hcCBbcmVtYXAgYmVnaW5uaW5nLW9mLWxpbmVdICAgJ2N1YS1yZXNp emUtcmVjdGFuZ2xlLWJvbCkKKyAgKGRlZmluZS1rZXkgY3VhLS1yZWN0YW5nbGUta2V5bWFwIFty ZW1hcCBtb3ZlLWVuZC1vZi1saW5lXSAgICAgICAnY3VhLXJlc2l6ZS1yZWN0YW5nbGUtZW9sKQor ICAoZGVmaW5lLWtleSBjdWEtLXJlY3RhbmdsZS1rZXltYXAgW3JlbWFwIG1vdmUtYmVnaW5uaW5n LW9mLWxpbmVdICdjdWEtcmVzaXplLXJlY3RhbmdsZS1ib2wpCiAgIChkZWZpbmUta2V5IGN1YS0t cmVjdGFuZ2xlLWtleW1hcCBbcmVtYXAgZW5kLW9mLWJ1ZmZlcl0gICAgICAgJ2N1YS1yZXNpemUt cmVjdGFuZ2xlLWJvdCkKICAgKGRlZmluZS1rZXkgY3VhLS1yZWN0YW5nbGUta2V5bWFwIFtyZW1h cCBiZWdpbm5pbmctb2YtYnVmZmVyXSAnY3VhLXJlc2l6ZS1yZWN0YW5nbGUtdG9wKQogICAoZGVm aW5lLWtleSBjdWEtLXJlY3RhbmdsZS1rZXltYXAgW3JlbWFwIHNjcm9sbC1kb3duXSAgICAgICAg ICdjdWEtcmVzaXplLXJlY3RhbmdsZS1wYWdlLXVwKQpAQCAtMTUyMiw3ICsxNTM3LDcgQEAgY3Vh LS1pbml0LXJlY3RhbmdsZXMKICAgKGRlZmluZS1rZXkgY3VhLS1yZWN0YW5nbGUta2V5bWFwICJc ciIgICAgICdjdWEtcm90YXRlLXJlY3RhbmdsZSkKICAgKGRlZmluZS1rZXkgY3VhLS1yZWN0YW5n bGUta2V5bWFwICJcdCIgICAgICdjdWEtaW5kZW50LXJlY3RhbmdsZSkKIAotICAoZGVmaW5lLWtl eSBjdWEtLXJlY3RhbmdsZS1rZXltYXAgWyhjb250cm9sID8/KV0gJ2N1YS1oZWxwLWZvci1yZWN0 YW5nbGUpCisgIChkZWZpbmUta2V5IGN1YS0tcmVjdGFuZ2xlLWtleW1hcCAoa2JkICJNLT8iKSAn Y3VhLWhlbHAtZm9yLXJlY3RhbmdsZSkKIAogICAoZGVmaW5lLWtleSBjdWEtLXJlY3RhbmdsZS1r ZXltYXAgW21vdXNlLTFdCSAgICdjdWEtbW91c2Utc2V0LXJlY3RhbmdsZS1tYXJrKQogICAoZGVm aW5lLWtleSBjdWEtLXJlY3RhbmdsZS1rZXltYXAgW2Rvd24tbW91c2UtMV0gJ2N1YS0tbW91c2Ut aWdub3JlKQpAQCAtMTU0Nyw2ICsxNTYyLDkgQEAgY3VhLS1pbml0LXJlY3RhbmdsZXMKICAgKGN1 YS0tcmVjdC1NL0gta2V5ID9rCSdjdWEtY3V0LXJlY3RhbmdsZS1hcy10ZXh0KQogICAoY3VhLS1y ZWN0LU0vSC1rZXkgP2wJJ2N1YS1kb3duY2FzZS1yZWN0YW5nbGUpCiAgIChjdWEtLXJlY3QtTS9I LWtleSA/bQknY3VhLWNvcHktcmVjdGFuZ2xlLWFzLXRleHQpCis7IChjdWEtLXJlY3QtTS9ILWtl eSA/bQknY3VhLWNvcHktcmVjdGFuZ2xlLWFzLXRleHQpIDs7IFRCRAorICAoZGVmaW5lLWtleSBj dWEtLXJlY3RhbmdsZS1rZXltYXAgW3JlbWFwIGJhY2stdG8taW5kZW50YXRpb25dICdjdWEtcmVz aXplLXJlY3RhbmdsZS1iYWNrLXRvLWluZGVudGF0aW9uKQorCiAgIChjdWEtLXJlY3QtTS9ILWtl eSA/bgknY3VhLXNlcXVlbmNlLXJlY3RhbmdsZSkKICAgKGN1YS0tcmVjdC1NL0gta2V5ID9vCSdj dWEtb3Blbi1yZWN0YW5nbGUpCiAgIChjdWEtLXJlY3QtTS9ILWtleSA/cAknY3VhLXRvZ2dsZS1y ZWN0YW5nbGUtdmlydHVhbC1lZGdlcykK --000000000000e9fb8605b29d4559--