From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 050b830 3/3: Do interactive mode tagging for finder.el
Date: Fri, 19 Mar 2021 11:23:25 -0500 [thread overview]
Message-ID: <CADwFkmm3=NeC_WDAQ4+owdGh86CDxmQ83+U4OhHUxnkveVoJ0g@mail.gmail.com> (raw)
In-Reply-To: <83v99nedze.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> It's a command that is applicable only to finder-mode buffers, so I
>> think the tagging is correct?
>
> It depends on what we do with the tag.
>
> "Applicable only to finder-mode buffers" doesn't tell how we use this
> information. We use it to filter out commands as irrelevant in
> certain contexts. But this command _is_ relevant even when the major
> mode of the current buffer is something other than finder-mode,
> because the user can click on text in a non-selected window.
Currently we use it to filter commands in `M-x', where you anyways can't
use it (it will signal an error as EVENT is not bound). So this change
doesn't break anything. What am I missing?
If the above is correct, then that also means that there is no point to
show such commands even in `finder-mode'. So it would be even better to
add some form that marks a command as only relevant to the mouse and
then never show those commands in `M-x'. ISTR we discussed something
like that but I'm not sure if we reached any conclusion.
next prev parent reply other threads:[~2021-03-19 16:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 8:15 master 050b830 3/3: Do interactive mode tagging for finder.el Eli Zaretskii
2021-03-19 8:28 ` Lars Ingebrigtsen
2021-03-19 8:37 ` Eli Zaretskii
2021-03-19 16:23 ` Stefan Kangas [this message]
2021-03-19 16:35 ` Eli Zaretskii
2021-03-19 17:08 ` Stefan Kangas
2021-03-19 19:39 ` Eli Zaretskii
2021-03-19 19:55 ` [External] : " Drew Adams
2021-03-20 7:51 ` Lars Ingebrigtsen
2021-03-20 8:15 ` Lars Ingebrigtsen
2021-03-20 9:02 ` Eli Zaretskii
2021-03-20 9:05 ` Lars Ingebrigtsen
2021-03-20 9:23 ` Eli Zaretskii
2021-03-21 7:47 ` Lars Ingebrigtsen
2021-03-19 17:22 ` Dmitry Gutov
2021-03-19 17:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmm3=NeC_WDAQ4+owdGh86CDxmQ83+U4OhHUxnkveVoJ0g@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.