From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#43682: 28.0.50; Clean up nnimap server buffers? Date: Mon, 11 Oct 2021 05:53:26 -0700 Message-ID: References: <87eemlh3ro.fsf@ericabrahamsen.net> <87d024bpqc.fsf@gnus.org> <87mu18qw3g.fsf@ericabrahamsen.net> <87k0wc9i4k.fsf@gnus.org> <87tuvfc4ur.fsf@ericabrahamsen.net> <87d022wx5y.fsf@gnus.org> <871rii7cso.fsf@ericabrahamsen.net> <87o8lmq6k4.fsf@gnus.org> <87sgax6eqb.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14625"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: Lars Ingebrigtsen , 43682@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 11 14:54:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZuoq-0003aF-61 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 14:54:16 +0200 Original-Received: from localhost ([::1]:56078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZuoo-0007H0-TP for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 08:54:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZuoc-0007Fz-I5 for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 08:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45510) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZuoc-00045s-9e for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 08:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZuoc-00016B-3d for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 08:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Oct 2021 12:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43682 X-GNU-PR-Package: emacs Original-Received: via spool by 43682-submit@debbugs.gnu.org id=B43682.16339568164163 (code B ref 43682); Mon, 11 Oct 2021 12:54:02 +0000 Original-Received: (at 43682) by debbugs.gnu.org; 11 Oct 2021 12:53:36 +0000 Original-Received: from localhost ([127.0.0.1]:57050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuoC-000155-9H for submit@debbugs.gnu.org; Mon, 11 Oct 2021 08:53:36 -0400 Original-Received: from mail-pl1-f173.google.com ([209.85.214.173]:43819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZuo9-00014X-0I for 43682@debbugs.gnu.org; Mon, 11 Oct 2021 08:53:33 -0400 Original-Received: by mail-pl1-f173.google.com with SMTP id y1so11223293plk.10 for <43682@debbugs.gnu.org>; Mon, 11 Oct 2021 05:53:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=8YcX6MEYSjNwICgImANKnrxfRbMJHcbSGJ5jNwGyJOM=; b=jSIocXQRViK8kA/2wRSuDaP7PpfW+7cTQpigmsv8hrpKBaFplbcELyafBo+wZtbmMg H9XIr5p4TeET7FtzrhX+IT9rR7AJsgSxuAD6E1Ybyxq3sijYxcb86pPr6vxSSCL4ItEG Kytz3FKG2ps0cWFxqoATbgFUzkGn/g3UQR7qLuxpRRqtO6/9x+oglV+87A6u3Kb6jAw4 C5Q0K1o/TW69TcEQeJpOE49MeKOTgpjdRfKz7G1HoCDP0FmcOgXW9TAk6k/V1h/sH+es eLffHFN1zyxFi+saQ7+msiHRr6wUX1Ao/82Jfqbka75rz9yInz/eNMIQms4MfLpxNA9H yxuw== X-Gm-Message-State: AOAM531c6x8SJIqunFi6deILJQ4e+5Pu4FdcxycIwDVWnDFXbF8WKZwx RlVQpiA28nADZcUheNiAVmqAsPPeHzu9K8VJCW1pXVff X-Google-Smtp-Source: ABdhPJzjjcHWrDoQF3YjB7/5gtDjkynqWLzrvWZKT5g8R/eu0OcA2GzVHX+aihTjrXqqELmjlvOxAXgJOjTZJQ9iL68= X-Received: by 2002:a17:90a:5583:: with SMTP id c3mr29249919pji.133.1633956807350; Mon, 11 Oct 2021 05:53:27 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Oct 2021 05:53:26 -0700 In-Reply-To: <87sgax6eqb.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 01 Oct 2020 10:25:00 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216902 Archived-At: Eric Abrahamsen writes: > On 10/01/20 18:01 PM, Lars Ingebrigtsen wrote: >> Eric Abrahamsen writes: >> >>> It's possible (I'm not claiming to understand all the code) that all we >>> would need to do is fix `gnus-async-wait-for-article' to replace its >>> calls to `nntp-find-connection' and `nntp-accept-process-output' with >>> something generalized. Those two functions deal with directly with >>> `nntp-connection-alist', so we'd need something that would do the >>> equivalent with `nnimap-connection-alist'. >> >> Yup. > > This is something I wouldn't want to tackle until we have generic > functions. > >>> Anyway, in the interest of completing this far less ambitious patch: if >>> the nnimap connection has timed out, we should remove this connection >>> from `nnimap-connection-alist', so this version of the patch does that. >>> If async has opened a second connection, I guess we should leave that >>> alone, though I don't have too much confidence that the whole process >>> will recover gracefully from the main connection dying... >> >> Well, the connections are separate, and there's all kinds of reasons for >> the server to close a connection, so... >> >>> + (unless (memq (process-status (get-buffer-process buffer)) >>> + '(open run)) >> >> Aka `process-live-p'. > > I forgot we have that! > >> Otherwise looks fine to me (but I haven't tested the code). > > Okay, I'll run this for a bit, as well. Any news here? Should the fix be installed?