From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs,gmane.mail.mh-e.devel Subject: bug#51056: 29.0.50; Making `gnus-define-keys' obsolete Date: Mon, 11 Oct 2021 12:46:41 -0700 Message-ID: References: <2156237.1633574888@tigger3.sg.gildea.net> <1178966.1633978812@olgas.newt.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40825"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51056@debbugs.gnu.org, Lars Ingebrigtsen , mh-e-devel@lists.sourceforge.net To: Bill Wohler , Stephen Gildea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 11 21:47:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ma1Ga-000ANE-Pr for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 21:47:20 +0200 Original-Received: from localhost ([::1]:56892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ma1GY-0001AJ-Nf for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Oct 2021 15:47:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ma1GM-00016q-LY for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 15:47:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ma1GI-0004O6-7U for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 15:47:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ma1GI-0002at-1T for bug-gnu-emacs@gnu.org; Mon, 11 Oct 2021 15:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Oct 2021 19:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51056 X-GNU-PR-Package: emacs Original-Received: via spool by 51056-submit@debbugs.gnu.org id=B51056.16339816099951 (code B ref 51056); Mon, 11 Oct 2021 19:47:01 +0000 Original-Received: (at 51056) by debbugs.gnu.org; 11 Oct 2021 19:46:49 +0000 Original-Received: from localhost ([127.0.0.1]:60977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma1G4-0002aR-VB for submit@debbugs.gnu.org; Mon, 11 Oct 2021 15:46:49 -0400 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:55862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ma1G3-0002aE-KN for 51056@debbugs.gnu.org; Mon, 11 Oct 2021 15:46:48 -0400 Original-Received: by mail-pj1-f49.google.com with SMTP id om14so2141719pjb.5 for <51056@debbugs.gnu.org>; Mon, 11 Oct 2021 12:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=pE5Wkp/Lmof983iJqj0TQGM8QEMg1T6y1G3kh0agi88=; b=w91WSFnRHKeBNdgoFHn+t1x5BDqiAvKPVX4CwT1UxbvjqHApi7BwX4VD8k0+61vw6V E3Lnz8pxf3Up8aodbJ/Np3LInu1cC19GL2DP/YDaXV4gfdB5sGJttUapQMBDQNIaWjRH 0b2yPLTg32tEVQlovd/H4PD7ut7b1iYqmNQx0Yxll+IPmV2GPO3yu7PMYl2Jxj/otS5Q 3eeX9NQoo+i+QyrCB/PYG4fzxo3kGJX/o5CKmiBMbNsEs3t55akAi2y8ivULorg4Vkno GMIR1E6rDJwfuzrfNWFnKa7bDXR9Ttg9cAkb7cbdlKcscZprg8MDiLue36v+CZqyexNl aJKw== X-Gm-Message-State: AOAM530EqBks+Gcz5pKgI1PlZQ/MTyvfjOIrgW1O9GQIabYrmI5RHH3x 6YL6oseBReUWPKCMoj7d2Qzb8xHnccAdqunYlwY= X-Google-Smtp-Source: ABdhPJyhhzC17UdDsN6q/kpdP5wNM/D1nxKiYroYuYu1i723oFJhGBnivd8vIM51bdt/ogpwEVgaM2fikkEfPe5eYSs= X-Received: by 2002:a17:902:e74a:b0:13f:3538:fca0 with SMTP id p10-20020a170902e74a00b0013f3538fca0mr8473050plf.22.1633981601777; Mon, 11 Oct 2021 12:46:41 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Oct 2021 12:46:41 -0700 In-Reply-To: <1178966.1633978812@olgas.newt.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216957 gmane.mail.mh-e.devel:14192 Archived-At: Bill Wohler writes: > Thanks so much for the MH-E clean-ups! They are very much appreciated. > So far, I haven't noticed any issues with your updates. Thank you, that is an encouraging report. If we do break something, we can always back those commits out for further investigation, as I already had to do in one case. The culprit was this change, but I can't say that I understand why: diff --git a/lisp/mh-e/mh-tool-bar.el b/lisp/mh-e/mh-tool-bar.el index 805408cfc7..7cc0a1e83c 100644 --- a/lisp/mh-e/mh-tool-bar.el +++ b/lisp/mh-e/mh-tool-bar.el @@ -27,8 +27,7 @@ ;;; Code: (require 'mh-e) -(mh-do-in-gnu-emacs - (require 'tool-bar)) +(require 'tool-bar) ;;; Tool Bar Commands So this innocent looking change leads to this: In mh-tool-bar-define: mh-e/mh-tool-bar.el:180:62: Warning: reference to free variable =E2=80=98fo= lder-docs=E2=80=99 mh-e/mh-tool-bar.el:222:36: Warning: reference to free variable =E2=80=98folder-button-setter=E2=80=99 mh-e/mh-tool-bar.el:226:36: Warning: reference to free variable =E2=80=98sequence-button-setter=E2=80=99 mh-e/mh-tool-bar.el:191:34: Warning: reference to free variable =E2=80=98sh= ow-buttons=E2=80=99 mh-e/mh-tool-bar.el:230:36: Warning: reference to free variable =E2=80=98show-button-setter=E2=80=99 mh-e/mh-tool-bar.el:234:36: Warning: reference to free variable =E2=80=98show-seq-button-setter=E2=80=99 mh-e/mh-tool-bar.el:295:41: Warning: reference to free variable =E2=80=98letter-buttons=E2=80=99 mh-e/mh-tool-bar.el:296:41: Warning: reference to free variable =E2=80=98le= tter-docs=E2=80=99 mh-e/mh-tool-bar.el:245:36: Warning: reference to free variable =E2=80=98letter-button-setter=E2=80=99 mh-e/mh-tool-bar.el:280:51: Warning: reference to free variable =E2=80=98folder-defaults=E2=80=99 mh-e/mh-tool-bar.el:291:51: Warning: reference to free variable =E2=80=98letter-defaults=E2=80=99 mh-e/mh-tool-bar.el:194:36: Warning: reference to free variable =E2=80=98folder-vectors=E2=80=99 mh-e/mh-tool-bar.el:195:11: Warning: reference to free variable =E2=80=98sh= ow-vectors=E2=80=99 mh-e/mh-tool-bar.el:196:11: Warning: reference to free variable =E2=80=98letter-vectors=E2=80=99 mh-e/mh-tool-bar.el:197:14: Warning: assignment to free variable =E2=80=98folder-defaults=E2=80=99 mh-e/mh-tool-bar.el:199:61: Warning: assignment to free variable =E2=80=98letter-defaults=E2=80=99 mh-e/mh-tool-bar.el:189:11: Warning: reference to free variable =E2=80=98folder-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98folder-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98letter-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98show-buttons=E2=80=99 mh-e/mh-tool-bar.el:189:36: Warning: assignment to free variable =E2=80=98l= etter-docs=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98f= older-docs=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98folder-vectors=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98show-vectors=E2=80=99 mh-e/mh-tool-bar.el:285:41: Warning: assignment to free variable =E2=80=98letter-vectors=E2=80=99 mh-e/mh-tool-bar.el:301:1: Error: Symbol=E2=80=99s value as variable is voi= d: folder-docs ELC mh-e/mh-xface.elc make[2]: *** [Makefile:316: mh-e/mh-tool-bar.elc] Error 1 Any ideas here are welcome.