From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Sat, 6 Jan 2024 01:18:19 -0800 Message-ID: References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> <87le9297ei.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14089"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Po Lu , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 06 10:19:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rM2pk-0003Vm-0M for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jan 2024 10:19:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rM2oz-0004HK-JF; Sat, 06 Jan 2024 04:18:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM2oy-0004H6-6W for emacs-devel@gnu.org; Sat, 06 Jan 2024 04:18:24 -0500 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rM2ow-0001l6-Jz; Sat, 06 Jan 2024 04:18:23 -0500 Original-Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5574feb7958so315996a12.3; Sat, 06 Jan 2024 01:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704532700; x=1705137500; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=eavGXca5ofXW1CbSRuBKHl2XHtTDYxb0N+OUA4nTi8c=; b=UoKs77pkUJF4GscOTJ+jn85LygipnCHFEwOf8/4l7wAniLJZIznYUQVwpooH23heHE XXrwZEdGe6K88o7swD8eDMDTeC3FE17+B6hIGpA0VBQzhHUWqvj/yVq5lZ1FH046PLLv BUFKW8vBO0XJ2fGVSyMIPFmHZV3bhaCd1BK8T8naJ7AOM5kGNFGHF3x3Kabr0z/5Rez6 UL7jPmh6xHmbkq/jy2dzwFgDCp9NAtIWOC/jBqFt1wfkHkQZXYmq+Er2DJIL+tGBkkPD gYUWeO10Ac0+ASw+uiq0ZyLTRgHXS9LMflKR/zdSGd23ws7PEG7N9cAlqTmwzqexZxQy /rXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704532700; x=1705137500; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eavGXca5ofXW1CbSRuBKHl2XHtTDYxb0N+OUA4nTi8c=; b=TDHv8n5PIqWI3FGGaw6O3dyrPukjgyCXGA51ZPJT4EAzvrUTro4npGJ/Fv6Lz58Upe ip6Y0NoCriDZzcgTRmZmV1MsWSSQ6rLYYx47WXcVRe0LoLIAoXDK6jioZAF6DZGJgSbq u6inClOhOJeNkNOMHw6iIQ1bL4mG35bbuSmUhYnlFhbJa0eVY9B/KAgYzUM8q7YyZ6db DGrgf2mox3sppWwWfC/ocJpyryMfCq7VF0FJlrM+LZGo2dbhBwc609gKCOndmoWTiR67 /8pkgCtiK68eTyJtgF9AxBtdCsczwidfwGCntkif45NGyIqojspjP7t/fTDMrkZ7z4uA GoHg== X-Gm-Message-State: AOJu0YyUyClQYOnlFe2oXnzsNUVxozybXujJj3PuV6y7yVlrMCpMLZrV o+Lt1KIFwrGRRbCr/EB9oqcY/3zUnV26C/rCwtg= X-Google-Smtp-Source: AGHT+IE7ILfO40lxxtooLuwRSM3QNb4mHk7sJW+/8p1tfUyuEEWkiZmSAJjXEjH3Oy+3qnYqZewtjpWJf6uJzGsqSqI= X-Received: by 2002:a50:d516:0:b0:556:68ad:b511 with SMTP id u22-20020a50d516000000b0055668adb511mr344737edi.16.1704532700528; Sat, 06 Jan 2024 01:18:20 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 6 Jan 2024 01:18:19 -0800 In-Reply-To: <87le9297ei.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314600 Archived-At: Po Lu writes: > Eli Zaretskii writes: > >> Regardless of portability issues, I think the macro should be called >> SWAP, upper-case, to avoid clashes with functions. > > I reverted the change for being impossible to build with compilers > besides GCC and others implementing its extensions. Thanks, but whether or not that revert was justified, please stop reverting patches before people have time to react, or while discussions are still ongoing. It is perceived as uncollaborative at best. If you need to compile the latest changes on master on some unusual compiler this very morning, you can revert it locally. So there is no rush here. Premature reverts only serve to mess up our git history, in case we need to re-apply the changes later, and is just a bad way of doing things. Please see the patch I sent separately, and let me know if you have any thoughts.