From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#6847: 23.2; ibuffer-filter-by-filename ignores buffer directory names Date: Sun, 4 Aug 2019 19:41:16 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000f7ef19058f4e19aa" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="169877"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 6847@debbugs.gnu.org To: Damyan Pepper Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 04 19:42:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huKWM-000i4B-40 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 19:42:14 +0200 Original-Received: from localhost ([::1]:49006 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huKWK-0003pT-3M for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Aug 2019 13:42:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38583) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huKWC-0003ld-Ll for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 13:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huKWA-0000kN-Oq for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 13:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huKWA-0000jV-8U for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 13:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huKWA-0000oi-5i for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2019 13:42:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2019 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6847 X-GNU-PR-Package: emacs Original-Received: via spool by 6847-submit@debbugs.gnu.org id=B6847.15649404973078 (code B ref 6847); Sun, 04 Aug 2019 17:42:02 +0000 Original-Received: (at 6847) by debbugs.gnu.org; 4 Aug 2019 17:41:37 +0000 Original-Received: from localhost ([127.0.0.1]:34200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huKVl-0000nZ-4y for submit@debbugs.gnu.org; Sun, 04 Aug 2019 13:41:37 -0400 Original-Received: from mail-pg1-f170.google.com ([209.85.215.170]:34642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1huKVj-0000nE-CC for 6847@debbugs.gnu.org; Sun, 04 Aug 2019 13:41:35 -0400 Original-Received: by mail-pg1-f170.google.com with SMTP id n9so32247840pgc.1 for <6847@debbugs.gnu.org>; Sun, 04 Aug 2019 10:41:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=sWCEgz/SCBC9QcE5OxjDqSlMoXFgpq3xUGlyYCjjXsE=; b=dHbkeM/wozQ6TCkGxKZR0sYdkIGBx0iJS/bdhWbuyo5a5MFUBJU8MBciUKXByRAw2E 9Gh39qrXCGHY0BKdEqPeyUgasn/hgQ0ioB7fYkRCqUDQZkzVfs+dvCZK8BR7UnFh3sIm eUqaXcdl79mjKDCKpBzYsRvsTFXi6oEWSUbkTENkJ1UBjWY5ojnyywywUI0pWVG5PuZJ L2vn+p208PD7k9ePlyn0P/viDdmth0riN7hbv60v4ZPQKs0I9aR+yClAyAD56jBIzyYj MVyobwrJGMIcIFyoIxCAkT4xf8aV2tFNczPrjw0DG2lHF+TqYKSHuiXf84wil10s2ECd b1iQ== X-Gm-Message-State: APjAAAWUygb8fywEI6so7gB1tCV4JJuGEM2KQX5z4Mt01ZKDMnMo2mJ7 MdZpJ0rj3iXOYjUZ5rxQdPbQtCrtS4q7vNeG1pU= X-Google-Smtp-Source: APXvYqyfREpy1hiZixA1sOJjItZuuXfsSXNLjwbOxxh8Lh6o+qOwB6Xw2PnKEKZTg2tfz2RfD5wSpkz8odcFKvZysXM= X-Received: by 2002:a17:90a:17ab:: with SMTP id q40mr14581833pja.106.1564940489442; Sun, 04 Aug 2019 10:41:29 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164585 Archived-At: --000000000000f7ef19058f4e19aa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 6847 + patch quit Damyan Pepper writes: > When using ibuffer.el if I set it to filter by filename then dired > buffers visiting directories are not included in the filter. This is > inconsistent with the way that ibuffer displays the buffers. > > For example, if I start with emacs -Q, open a few buffers and run M-x ibu= ffer: > > MR Name Size Mode Filename/Process > -- ---- ---- ---- ---------------- > [ Default ] > README 5276 Fundamental c:/emacs-23.2/README > % emacs-23.2 857 Dired by name c:/emacs-23.2/ > % etc 5627 Dired by name c:/emacs-23.2/etc/ > % bin 1299 Dired by name c:/emacs-23.2/bin/ > *scratch* 191 Lisp Interaction > * *Messages* 131 Fundamental > > 6 buffers 13381 4 files, no processes > > and then press "/ f emacs" I get: > > MR Name Size Mode Filename/Process > -- ---- ---- ---- ---------------- > [ Default ] > README 5276 Fundamental c:/emacs-23.2/README > > 1 buffer 5276 1 file, no processes > > > Note that the emacs-23.2, etc and bin buffers all have an entry in the > "Filename/Process" column that is ignored by the filter. I think this use case should be mostly covered by the recently added ibuffer-filter-by-directory command: commit 35aaa6b6aa9a2e7b42465603fb32355a009c510f Author: Christopher Genovese Date: Tue Dec 20 17:41:56 2016 +0900 ibuffer: New filters and commands But it would seem that this command never got a key binding. This is an excerpt from C-h f ibuffer-mode: Filtering commands: =E2=80=98M-x ibuffer-filter-chosen-by-completion=E2=80=99 - Select an= d apply filter chosen by completion. =E2=80=98/ RET=E2=80=99 - Add a filter by any major mode. =E2=80=98/ m=E2=80=99 - Add a filter by a major mode now in use. =E2=80=98/ M=E2=80=99 - Add a filter by derived mode. =E2=80=98/ n=E2=80=99 - Add a filter by buffer name. =E2=80=98/ c=E2=80=99 - Add a filter by buffer content. =E2=80=98/ b=E2=80=99 - Add a filter by basename. =E2=80=98M-x ibuffer-filter-by-directory=E2=80=99 - Add a filter by d= irectory name. =E2=80=98/ f=E2=80=99 - Add a filter by filename. =E2=80=98/ .=E2=80=99 - Add a filter by file extension. I suggest to add the keybinding "/ F" for ibuffer-filter-by-directory and "/ SPC" for ibuffer-filter-chosen-by-completion. Perhaps "/ d" or "/ D" would be more natural for the directory case, but alas they are already taken. Please see the attached patch. Thanks, Stefan Kangas --000000000000f7ef19058f4e19aa Content-Type: application/x-patch; name="0001-Add-key-bindings-for-ibuffer-filter-commands.patch" Content-Disposition: attachment; filename="0001-Add-key-bindings-for-ibuffer-filter-commands.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jyx92p7z0 RnJvbSA1ZDczM2YxMWZjM2IyNTczYzFlNzhkYThkYzlmMzk5Y2IyZTZmOWQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDQgQXVnIDIwMTkgMTk6MzQ6MDEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBB ZGQga2V5IGJpbmRpbmdzIGZvciBpYnVmZmVyIGZpbHRlciBjb21tYW5kcwoKKiBsaXNwL2lidWZm ZXIuZWwgKGlidWZmZXItLWZpbHRlci1tYXApOiBBZGQga2V5YmluZGluZyBmb3IKJ2lidWZmZXIt ZmlsdGVyLWNob3Nlbi1ieS1jb21wbGV0aW9uJyBhbmQKJ2lidWZmZXItZmlsdGVyLWJ5LWRpcmVj dG9yeScuICAoQnVnIzY4NDcpCi0tLQogbGlzcC9pYnVmZmVyLmVsIHwgMiArKwogMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpc3AvaWJ1ZmZlci5lbCBiL2xp c3AvaWJ1ZmZlci5lbAppbmRleCAyM2Y3YTJhOGU0Li4zYWYwNmViYTk3IDEwMDY0NAotLS0gYS9s aXNwL2lidWZmZXIuZWwKKysrIGIvbGlzcC9pYnVmZmVyLmVsCkBAIC00MjQsMTIgKzQyNCwxNCBA QCBpYnVmZmVyLW1vZGUtZ3JvdXBzLXBvcHVwCiAoZGVmdmFyIGlidWZmZXItLWZpbHRlci1tYXAK ICAgKGxldCAoKG1hcCAobWFrZS1zcGFyc2Uta2V5bWFwKSkpCiAgICAgKGRlZmluZS1rZXkgbWFw IChrYmQgIlJFVCIpICdpYnVmZmVyLWZpbHRlci1ieS1tb2RlKQorICAgIChkZWZpbmUta2V5IG1h cCAoa2JkICJTUEMiKSAnaWJ1ZmZlci1maWx0ZXItY2hvc2VuLWJ5LWNvbXBsZXRpb24pCiAgICAg KGRlZmluZS1rZXkgbWFwIChrYmQgIm0iKSAnaWJ1ZmZlci1maWx0ZXItYnktdXNlZC1tb2RlKQog ICAgIChkZWZpbmUta2V5IG1hcCAoa2JkICJNIikgJ2lidWZmZXItZmlsdGVyLWJ5LWRlcml2ZWQt bW9kZSkKICAgICAoZGVmaW5lLWtleSBtYXAgKGtiZCAibiIpICdpYnVmZmVyLWZpbHRlci1ieS1u YW1lKQogICAgIChkZWZpbmUta2V5IG1hcCAoa2JkICJFIikgJ2lidWZmZXItZmlsdGVyLWJ5LXBy b2Nlc3MpCiAgICAgKGRlZmluZS1rZXkgbWFwIChrYmQgIioiKSAnaWJ1ZmZlci1maWx0ZXItYnkt c3RhcnJlZC1uYW1lKQogICAgIChkZWZpbmUta2V5IG1hcCAoa2JkICJmIikgJ2lidWZmZXItZmls dGVyLWJ5LWZpbGVuYW1lKQorICAgIChkZWZpbmUta2V5IG1hcCAoa2JkICJGIikgJ2lidWZmZXIt ZmlsdGVyLWJ5LWRpcmVjdG9yeSkKICAgICAoZGVmaW5lLWtleSBtYXAgKGtiZCAiYiIpICdpYnVm ZmVyLWZpbHRlci1ieS1iYXNlbmFtZSkKICAgICAoZGVmaW5lLWtleSBtYXAgKGtiZCAiLiIpICdp YnVmZmVyLWZpbHRlci1ieS1maWxlLWV4dGVuc2lvbikKICAgICAoZGVmaW5lLWtleSBtYXAgKGti ZCAiPCIpICdpYnVmZmVyLWZpbHRlci1ieS1zaXplLWx0KQotLSAKMi4yMi4wCgo= --000000000000f7ef19058f4e19aa--