From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#70105: 30.0.50; Emacs should support EditorConfig out of the box Date: Sun, 9 Jun 2024 04:49:31 -0700 Message-ID: References: <867chibhqi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12722"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jen-Chieh Shen , =?UTF-8?Q?Bj=C3=B6rn?= Bidar , 10sr <8slashes+git@gmail.com>, 70105@debbugs.gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 14:00:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGHDS-00036m-GP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 14:00:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGHDC-00042V-1S; Sun, 09 Jun 2024 07:59:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGHD9-00041o-3a for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 07:59:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGHD8-0006la-Qp for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 07:59:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGHDO-0006K9-PO for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 08:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70105 X-GNU-PR-Package: emacs Original-Received: via spool by 70105-submit@debbugs.gnu.org id=B70105.171793438724244 (code B ref 70105); Sun, 09 Jun 2024 12:00:02 +0000 Original-Received: (at 70105) by debbugs.gnu.org; 9 Jun 2024 11:59:47 +0000 Original-Received: from localhost ([127.0.0.1]:33619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGHD8-0006Ix-Td for submit@debbugs.gnu.org; Sun, 09 Jun 2024 07:59:47 -0400 Original-Received: from mail-lf1-f41.google.com ([209.85.167.41]:43081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGHD6-0006Ic-7a for 70105@debbugs.gnu.org; Sun, 09 Jun 2024 07:59:45 -0400 Original-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52b78ef397bso4255611e87.0 for <70105@debbugs.gnu.org>; Sun, 09 Jun 2024 04:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717934302; x=1718539102; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=Feb/FJFg2nNrMw/zgFmhnxzczMB64CpUi4MdMHhYCIM=; b=CX4VFt+2syKDfVTQkut/FuE+BohKuqibpAP/Mn29x4x6t6GNdVv+yb7j5H2q/yM9uw vzZhJPyFNK+68tpEB8mup54ScC5qS2OWSEtYVjtZo+efdqQPXQvlmX3kjTl8y98OGV7+ RjuwJdoMQH+K1TpRr4Guk69Ki5tpUXS4wqM8iTze+AyPObYjl9XCbgGY/7r0cr7cL4er 27sLYDWzNtINs5tCR7hchsvUsFQv0ybveGY/eYZjjy8ZfdMrSbThbWoRMwjh8uETbNql CZYDdIEhZqcw3Q1zOT4uapnjJXpOO9FBDZxw2UYO33OxCTvXmqTtMpNhiyHX+4fCrlb+ 95rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717934302; x=1718539102; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Feb/FJFg2nNrMw/zgFmhnxzczMB64CpUi4MdMHhYCIM=; b=lXDUHzgfW6tA5SItg2zrKheCcoFP7wFbOXbef9XStd8ppv/zv54Dn73YYa1/Vrh5bk cDXGj+NgI30ZWKhQA8+ulYEZUSoRe0Kg9pRc8nOO9/1t0Ecay0HvwxVfVA5cD0/gWBON 62Nm4iE3SU+tPBePpCrzG8JlIhwb51SGxGKQeCsPi1Jt4VcW+LiLE3bo+OV+ibPV4MJb SC3WE13xzpFIPJiQrgpB+UW0sR1cmZJV05nZ5e/RfHHY1V7SDEcdVbu1wIiQdX3hCtom BqKAW1pA+h4fnSefnxnTUMl7X2MCphThbYmRBSJwvpaZRphmzKKXLRpT233LaNgtZXTB 9+pA== X-Forwarded-Encrypted: i=1; AJvYcCXVgirmqXlNipzCStJnjfnA5G/X8O5bZxE+6cwID5rkYD58ap+ei3r6uyv/OKr0RtG5hev8WCGStdx4El8JWroBhDg/jUA= X-Gm-Message-State: AOJu0YwqvEv7voPkgcUuoFKjz02A3Kn4EyH4qbBj/XDupF5sS5X1XNui 1AaGrmvZyFofw3YnASGQYlCXBTKqkhsfqDx9iNDLoMBWMVf3UxL6PK6BXKgqZQ27drCnZ2zMi+J /0VSbQbZjbOOxR3UVkAgyMYsWzJvU1FRK X-Google-Smtp-Source: AGHT+IEXiw8XpP+2QHuqo7z42rlAYanHX6+iu/n7ZQaeiS/Lw464gLuYu5MHVxi429NtpCDzkR6iaqLiIpdKwzYqR8o= X-Received: by 2002:aa7:d982:0:b0:57c:739c:b5bc with SMTP id 4fb4d7f45d1cf-57c739cb714mr1480561a12.13.1717933772085; Sun, 09 Jun 2024 04:49:32 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 9 Jun 2024 04:49:31 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286931 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > I'm hoping this can get into Emacs-30. > Comments/objections? Thanks for working on this. Your patches LGTM with Eli's comments. > (defun find-auto-coding (filename size) > + ;; FIXME: Shouldn't we use nil rather than "" to mean that there's no file? > + ;; FIXME: Clarify what the SOURCE is for in the return value? BTW, shouldn't this sentence now end with a "."? :-)