From: Stefan Kangas <stefan@marxist.se>
To: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO.
Date: Mon, 21 Sep 2020 18:23:24 +0000 [thread overview]
Message-ID: <CADwFkmkuvR5p-GZjHsXDmpvEPVpEK1WCmBrrcT4_=5PXz7q+bw@mail.gmail.com> (raw)
In-Reply-To: <aec49af5-b0c0-32a7-f919-ca92fbefca42@yandex.ru>
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 21.09.2020 17:46, Stefan Kangas wrote:
>> +;; TODO: Convert these into unit proper tests instead of using an
>> +;; external file.
>
> I wonder: did we ever decide to switch from manual/indent tests to ERT
> tests wholesale?
I was working under the assumption that these tests existed in their
current form only for historical reasons. So here I am, wreaking
general havoc.
> I'm asking as a developer from started with the latter and then switched
> mostly to the former, due to the ease of debugging.
>
> The manual/indent tests also have an automated runner, which uses the
> 'diff' program.
I think that the manual tests fail on at least two accounts:
1. There is no automated verification of success.
2. They don't run with "make check".
That said, please feel free to revert any commits you disagree with or
that gets in the way of your work. I think it goes without saying that
I don't want to make debugging harder for you or anyone else.
But if there are limitations in debugging with ert, perhaps we should
work on improving its capabilities?
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-09-21 18:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200921144653.9320.23809@vcs0.savannah.gnu.org>
[not found] ` <20200921144656.3E99C206ED@vcs0.savannah.gnu.org>
2020-09-21 17:54 ` master 12ca463 1/4: ; * test/lisp/textmodes/css-mode-tests.el: Add TODO Dmitry Gutov
2020-09-21 18:23 ` Stefan Kangas [this message]
2020-09-22 13:33 ` Lars Ingebrigtsen
2020-09-22 13:54 ` Stefan Kangas
2020-09-22 15:06 ` Lars Ingebrigtsen
2020-09-22 18:34 ` Dmitry Gutov
2020-09-22 16:22 ` Stefan Monnier
2020-09-23 13:56 ` Stefan Kangas
2020-09-23 14:28 ` Stefan Monnier
2020-09-23 15:44 ` Stefan Kangas
2020-09-22 19:32 ` Dmitry Gutov
2020-09-23 14:06 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkuvR5p-GZjHsXDmpvEPVpEK1WCmBrrcT4_=5PXz7q+bw@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.