From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#63385: 30.0.50; [DRAFT PATCH v1] Update eshell defcustom definitions Date: Fri, 1 Sep 2023 21:33:21 +0200 Message-ID: References: <1750da77-a6c2-dc6d-53ef-fba3e0f68034@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10135"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ruijie Yu , 63385@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 01 21:34:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qc9uH-0002Qm-B1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Sep 2023 21:34:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qc9ty-0003dq-MA; Fri, 01 Sep 2023 15:33:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc9tx-0003dh-70 for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 15:33:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qc9tw-00067H-Vh for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 15:33:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qc9u5-000163-VT for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 15:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63385-submit@debbugs.gnu.org id=B63385.16935968304195 (code B ref 63385); Fri, 01 Sep 2023 19:34:01 +0000 Original-Received: (at 63385) by debbugs.gnu.org; 1 Sep 2023 19:33:50 +0000 Original-Received: from localhost ([127.0.0.1]:33981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc9tt-00015b-Ln for submit@debbugs.gnu.org; Fri, 01 Sep 2023 15:33:49 -0400 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:55368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc9ts-00015P-4O for 63385@debbugs.gnu.org; Fri, 01 Sep 2023 15:33:48 -0400 Original-Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-500c63c9625so4262380e87.2 for <63385@debbugs.gnu.org>; Fri, 01 Sep 2023 12:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693596813; x=1694201613; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=yhjUSqWLq4qiOJFri8GPBG22AMpg09JxiJZQuY/YYn8=; b=hT4pIa5PwLLFO7a0qKgX7ebNqFAz7awsfE9g2VXjfNUKpjko2eAh+TNCknSNUY1DRf doUb65zXTScPXBOG1ezy62ednKfGqjRj5iOo6TL+iMeYnx4Slx2WB/y697RtPQHVuzaf oJvNrGCoRKNswKrVjd+bAYYYySzsIbeNG1FrkjFEYMu73QMtxasRiM9bCP1eEXKgXfxT usZ1xe4j5xaw80scFRzQGNH8hCbnZw+7ehIxZciBPxGXN2/O0ydeJSEPnVz2xAj0pcgw 5Y7slsRgeY6Nezp1xN2du7P/Ipk7HWiaK9zA0tGdkPeIN6Xur6IX2xAW76kqS/5RDhgi ybWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693596813; x=1694201613; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yhjUSqWLq4qiOJFri8GPBG22AMpg09JxiJZQuY/YYn8=; b=OSfliCx2hPxElcFxtFOsRyidD7Wi9h2Z7m9lNj4bTHaTM3tlleCaxSyW64BgzoxT80 D+/Zfj5SugvGHUQrPFhTUaBPJWjrgEX/Og5ghQQQEbNUWSi8gagptB11agN6G4kBw2tl klEfrlzN6AE57ptcmvYiXyFDQd3R3XkF4LAwvEGflMzer5murLPJjZeTKZW5ojJRND2I qo1N+8SMT1BBdOeUwAHNsvDFd75h2MgJJoqxe+yUgDK2Jm+jQQqaBLq1lpv5lpo58kW4 1q/SPOxcQexTY0wRCZnHT22/+QIx5FFwGAuRJjtmJP5TiMIe8TREg511a45rkl+W5u8k 73Pg== X-Gm-Message-State: AOJu0YxdCZQD6CntdjL6EhYc4+7RhgHKDaAzlf4eiG1fieWA+r0RVNDt aIcxqYRof4nH/d6zIB1X177kx0iB0kCUOfszPGuMSHz/ X-Google-Smtp-Source: AGHT+IFsvDIPwfALDiHgPXhiBQRFtb/aOfLzwCnUv0Wxo5Pi4j6DSRXNgYWLZL5n5hspDDv8NE1CjFde8pyeOJm+bwk= X-Received: by 2002:a05:6512:1143:b0:4fd:faa5:64ed with SMTP id m3-20020a056512114300b004fdfaa564edmr2207174lfg.11.1693596812558; Fri, 01 Sep 2023 12:33:32 -0700 (PDT) In-Reply-To: <1750da77-a6c2-dc6d-53ef-fba3e0f68034@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268911 Archived-At: Jim Porter writes: > > On 5/8/2023 9:47 PM, Ruijie Yu via Bug reports for GNU Emacs, the Swiss > army knife of text editors wrote: > > Here attached is a draft patch to update eshell defcustoms. The commit > > message contains a long [TODO] section outlining all my ideas on how to > > change a given portion, but these ideas probably need more input. > > Thanks, I think most of these make sense. I'm not too sure what to do > about the parts you marked with "TODO" though; it'll take some thought > for each of them. (For example, I feel like there's a better way to let > users customize the keys in em-rebind.el and elsewhere.) > > How about removing them from the patch, and then we can merge the remainder? Sounds good to me.