From: Stefan Kangas <stefankangas@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: 72255-done@debbugs.gnu.org
Subject: bug#72255: 30.0.60; Crash on macOS with malformed XPM image file
Date: Tue, 23 Jul 2024 20:51:06 -0700 [thread overview]
Message-ID: <CADwFkmktHUDGTM=_XWZCZBi19f22LKZYu4hLyuZHbLPPJZ4R7Q@mail.gmail.com> (raw)
In-Reply-To: <871q3jxxra.fsf@yahoo.com>
Version: 30.1
Po Lu <luangruo@yahoo.com> writes:
> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Severity: normal
>>
>> Emacs crashes on macOS when opening a malformed XPM image file.
>>
>> I'm attaching an example image with the file extension ".xpm.txt" below;
>> to reproduce, simply rename the file to ".xpm" and open it in Emacs.
>> (This bad file is an edited version of back-arrow.xpm in emacs.git.)
>>
>> I've included an lldb backtrace below. Note that I reproduced this on
>> master, but the code has not changed from emacs-30.
>>
>> The crash happens in nsterm.m:601:5, but I can't figure out why we're
>> trying to access some other address than the pointer that was passed to
>> that function. Maybe this is trivial to someone that knows Objective-C.
>
> Please test the emacs-30 branch. It was a double free on NS affecting
> not only XPM, but all image loading functions in varying measures.
That seems to have fixed the crash. Closing the bug, thanks!
prev parent reply other threads:[~2024-07-24 3:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 13:37 bug#72255: 30.0.60; Crash on macOS with malformed XPM image file Stefan Kangas
2024-07-24 3:41 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-24 3:51 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmktHUDGTM=_XWZCZBi19f22LKZYu4hLyuZHbLPPJZ4R7Q@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=72255-done@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.