From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andrea Corallo <akrl@sdf.org>, angelo.g0@libero.it, emacs-devel@gnu.org
Subject: Re: About the new frame title
Date: Sat, 14 Nov 2020 06:47:30 -0800 [thread overview]
Message-ID: <CADwFkmksooX=OQUZHfAJJXLR6VYApzG1uEkfS3i6QPYL98e2ww@mail.gmail.com> (raw)
In-Reply-To: <83eekwwga8.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 473 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks. In addition to comments from Andrea, I have a few minor nits
> below.
Thank you Andrea and Eli for your comments.
I have attached an updated patch that fixes your comments. I have only
tested it on GNU/Linux.
If someone wants to test this on Windows, make sure to test also using
"--no-build-details". To be able to spot the title before it changes,
make sure to load a long-running init file, i.e. don't use emacs -Q.
[-- Attachment #2: 0001-Make-initial-frame-match-frame-title-format.patch --]
[-- Type: text/x-diff, Size: 3089 bytes --]
From b598f9c06b631949225a4e7c797ee17f75ca1ba2 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Sat, 14 Nov 2020 00:08:17 +0100
Subject: [PATCH] Make initial frame match frame-title-format
* src/xterm.c (x_term_init):
* src/w32term.c (w32_initialize_display_info): Sync initial frame
title with new value of Vframe_title_format.
Problem reported by Angelo Graziosi <angelo.g0@libero.it>.
---
src/w32term.c | 16 +++++++++++-----
src/xterm.c | 24 ++++++++++++++----------
2 files changed, 25 insertions(+), 15 deletions(-)
diff --git a/src/w32term.c b/src/w32term.c
index e0618e4f52..23cb380040 100644
--- a/src/w32term.c
+++ b/src/w32term.c
@@ -7165,15 +7165,21 @@ w32_initialize_display_info (Lisp_Object display_name)
memset (dpyinfo, 0, sizeof (*dpyinfo));
dpyinfo->name_list_element = Fcons (display_name, Qnil);
+ static char const title[] = "GNU Emacs";
if (STRINGP (Vsystem_name))
{
- dpyinfo->w32_id_name = xmalloc (SCHARS (Vinvocation_name)
- + SCHARS (Vsystem_name) + 2);
- sprintf (dpyinfo->w32_id_name, "%s@%s",
- SDATA (Vinvocation_name), SDATA (Vsystem_name));
+ static char const at[] = " at ";
+ ptrdiff_t nbytes = sizeof (title) + sizeof (at);
+ if (INT_ADD_WRAPV (nbytes, SCHARS (Vsystem_name), &nbytes))
+ memory_full (SIZE_MAX);
+ dpyinfo->w32_id_name = xmalloc (nbytes);
+ sprintf (dpyinfo->w32_id_name, "%s%s%s", title, at, SDATA (Vsystem_name));
}
else
- dpyinfo->w32_id_name = xlispstrdup (Vinvocation_name);
+ {
+ dpyinfo->w32_id_name = xmalloc (sizeof (title));
+ strcpy (dpyinfo->w32_id_name, title);
+ }
/* Default Console mode values - overridden when running in GUI mode
with values obtained from system metrics. */
diff --git a/src/xterm.c b/src/xterm.c
index 98bb0ea891..0d2452de92 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -12928,19 +12928,23 @@ #define NUM_ARGV 10
#endif
Lisp_Object system_name = Fsystem_name ();
-
- ptrdiff_t nbytes = SBYTES (Vinvocation_name) + 1;
- if (STRINGP (system_name)
- && INT_ADD_WRAPV (nbytes, SBYTES (system_name) + 1, &nbytes))
- memory_full (SIZE_MAX);
- dpyinfo->x_id = ++x_display_id;
- dpyinfo->x_id_name = xmalloc (nbytes);
- char *nametail = lispstpcpy (dpyinfo->x_id_name, Vinvocation_name);
+ static char const title[] = "GNU Emacs";
if (STRINGP (system_name))
{
- *nametail++ = '@';
- lispstpcpy (nametail, system_name);
+ static char const at[] = " at ";
+ ptrdiff_t nbytes = sizeof (title) + sizeof (at);
+ if (INT_ADD_WRAPV (nbytes, SBYTES (system_name), &nbytes))
+ memory_full (SIZE_MAX);
+ dpyinfo->x_id_name = xmalloc (nbytes);
+ sprintf (dpyinfo->x_id_name, "%s%s%s", title, at, SDATA (system_name));
}
+ else
+ {
+ dpyinfo->x_id_name = xmalloc (sizeof (title));
+ strcpy (dpyinfo->x_id_name, title);
+ }
+
+ dpyinfo->x_id = ++x_display_id;
/* Figure out which modifier bits mean what. */
x_find_modifier_meanings (dpyinfo);
--
2.29.2
next prev parent reply other threads:[~2020-11-14 14:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:27 About the new frame title Angelo Graziosi
2020-09-14 15:17 ` Eli Zaretskii
2020-09-14 15:52 ` Angelo Graziosi
2020-09-19 13:21 ` Stefan Kangas
2020-09-19 14:39 ` Eli Zaretskii
2020-09-24 8:57 ` Stefan Kangas
2020-09-24 14:46 ` Eli Zaretskii
2020-09-25 12:38 ` Angelo Graziosi
2020-09-25 12:41 ` Eli Zaretskii
2020-09-25 13:31 ` Angelo Graziosi
2020-09-25 13:42 ` Eli Zaretskii
2020-11-13 23:10 ` Stefan Kangas
2020-11-13 23:51 ` Andrea Corallo via Emacs development discussions.
2020-11-14 7:26 ` Eli Zaretskii
2020-11-14 14:47 ` Stefan Kangas [this message]
2020-11-14 15:10 ` Eli Zaretskii
2020-11-15 1:44 ` Stefan Kangas
2020-09-19 21:22 ` Angelo Graziosi
2020-09-24 8:37 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmksooX=OQUZHfAJJXLR6VYApzG1uEkfS3i6QPYL98e2ww@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=akrl@sdf.org \
--cc=angelo.g0@libero.it \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.