From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format Date: Fri, 30 Oct 2020 23:51:21 +0000 Message-ID: References: <87imb7e242.fsf@gmx.net> <83zh4ipbli.fsf@gnu.org> <877drm13j3.fsf@gmx.net> <831rhuoy36.fsf@gnu.org> <87y2k2yqqb.fsf@gmx.net> <87h7qori97.fsf@gmx.net> <874kmcfy2h.fsf@rub.de> <875z6rmlrj.fsf@rub.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2711"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44068@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 31 00:52:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYeBp-0000bz-Bm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 31 Oct 2020 00:52:13 +0100 Original-Received: from localhost ([::1]:41320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYeBo-00044s-BM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 19:52:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYeBe-00044i-5e for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 19:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYeBd-0007l9-S3 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 19:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYeBd-0005cR-R6 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 19:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 23:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44068 X-GNU-PR-Package: emacs Original-Received: via spool by 44068-submit@debbugs.gnu.org id=B44068.160410189021541 (code B ref 44068); Fri, 30 Oct 2020 23:52:01 +0000 Original-Received: (at 44068) by debbugs.gnu.org; 30 Oct 2020 23:51:30 +0000 Original-Received: from localhost ([127.0.0.1]:60155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYeB8-0005bN-Cy for submit@debbugs.gnu.org; Fri, 30 Oct 2020 19:51:30 -0400 Original-Received: from mail-ed1-f54.google.com ([209.85.208.54]:46914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYeB6-0005b9-Bw for 44068@debbugs.gnu.org; Fri, 30 Oct 2020 19:51:28 -0400 Original-Received: by mail-ed1-f54.google.com with SMTP id t11so8314933edj.13 for <44068@debbugs.gnu.org>; Fri, 30 Oct 2020 16:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=LLRQiTEKbb+pRS5VSXw3X/xQgusIQrOTAr1LY41jci0=; b=unBTWOsBP1XJJrhPdBpairccT+PJFa1aXRfFR8aD6jLWTW2BsYeQt/ORcKTjNY6nEt Da9DkogHf23LWolL0XBwbbszSjBFF8zL3/8heJ1dTPCAXEXbKQBTMPVLOvjXOmZk4Axg BXUp6UVc8M7MNmr3Uhk8/rCAtXa4V1BrT3ROw0sjYI58TFBJ8bgGmxE1tsop8hK5Q6LU nCimXwzS3r8Gi8rH0ib/bS3meg107hSiYUvmGua8U1yMBH5/KR8MTpQR56J1P+KsJqzy aAPEpGcNpCJ48DM2ayk8OoQ+DHEZ0p5+DLlshLXCia//iKgYmsQSeAJ4W0PJX7fIuY4B 5uIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=LLRQiTEKbb+pRS5VSXw3X/xQgusIQrOTAr1LY41jci0=; b=Zfh8ox8F8ZKL57gY7HEmC8mvGxQML3FzgV9D+j5upEtYALXxEZi5DUuvG993w+pmOC pb1bfEhBJ/mfKtliZtc0Cpti7BQLlxMfnrT6Hv2mafsHruLx8Uy4qI2wY7IJK1rwA2O6 toDiiJ9r4IDgVyiMU7sxwRbmxLf+np1AeQ753Ri72cWnERQrHHilagpkBtHQhIprNjDI JCf/Mn9rxVbuKGAiUM4OMfOT+11jZv6NmCUr3cbsbhcFwWMAMyUXqukRzhyaF/VfbUd0 K9Lp4smDKPOhr0vofcsU3nY4AVfC+kCb0NH44kodg3Y2Huxkp25BAm9OrWmKqil/CsHy jzbw== X-Gm-Message-State: AOAM530IR+xSqW+DRl9B56j4hNZWOeE+N0+mBz++UYhyxzociuMq2xKn e4IpJl9UF/rEvJ3mtUzBwhT/Fr+VQoVB0S1oh7k= X-Google-Smtp-Source: ABdhPJz77T18YH282+X5oAoyed1hPPCOkxJiHhz+8X+EusNTgAJzfBOghzong/p6BNZ0Q4Jakizd4JsXQWp2NSdFyf8= X-Received: by 2002:aa7:d28c:: with SMTP id w12mr5341620edq.282.1604101882233; Fri, 30 Oct 2020 16:51:22 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 30 Oct 2020 23:51:21 +0000 In-Reply-To: <875z6rmlrj.fsf@rub.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192222 Archived-At: Stephen Berman writes: > It seems to. I did experiment a bit with the width when I made the > patch just for the selected column and thought the length I used there > gave the best results, but maybe that was too cautious. Does this patch > give better results (it differs from the previous one only in the > lengths checked and used for truncating): I think this looks very good, yes. It works fully as I would expect, at least: it seems to always correctly show the sorting indicator and the ellipsis. (I tested using list-buffers, list-bookmarks, list-packages, list-processes, list-dynamic-libraries, org-lint and flymake-diagnostics-buffer-mode.) Perhaps we could just go over the list above as you did in your first patch and make sure that there is enough space for all of these to show a sorting indicator without it touching the next column label. > It might be better to take more width parameters into account, as > tabulated-list-print-col does, but that seems rather more complicated > and I currently don't have time to pursue it. I imagine we can come back to and improve on this later. > I wish I had more time for it but at the moment I don't. What you have here is already a big improvement, thank you. I would recommend to push this to master.