From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#71736: Small cleanup patches for lua-ts-mode Date: Fri, 28 Jun 2024 12:56:09 -0700 Message-ID: References: <87ikxzafi5.fsf@pub.pink> <877cefaeoc.fsf@pub.pink> <87bk3r8wpm.fsf@pub.pink> <86msn669o1.fsf@gnu.org> <871q4h3tfi.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2293"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71736-done@debbugs.gnu.org, Eli Zaretskii To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 28 21:58:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNHjp-0000Im-Sr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jun 2024 21:58:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNHjU-0005fg-UA; Fri, 28 Jun 2024 15:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNHjO-0005ch-Ji for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 15:58:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNHjO-0005mW-Bk for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 15:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNHjO-0000B8-GM for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 15:58:02 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jun 2024 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71736 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 71736@debbugs.gnu.org, stefankangas@gmail.com, jm@pub.pink Original-Received: via spool by 71736-done@debbugs.gnu.org id=D71736.1719604638625 (code D ref 71736); Fri, 28 Jun 2024 19:58:02 +0000 Original-Received: (at 71736-done) by debbugs.gnu.org; 28 Jun 2024 19:57:18 +0000 Original-Received: from localhost ([127.0.0.1]:46497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNHig-0000A1-FC for submit@debbugs.gnu.org; Fri, 28 Jun 2024 15:57:18 -0400 Original-Received: from mail-ed1-f53.google.com ([209.85.208.53]:53699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNHie-00009l-R4 for 71736-done@debbugs.gnu.org; Fri, 28 Jun 2024 15:57:17 -0400 Original-Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-57ccd1111b0so646953a12.3 for <71736-done@debbugs.gnu.org>; Fri, 28 Jun 2024 12:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719604571; x=1720209371; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=4KMY/UWt0cp3RMMYbNQH6ciCao+RZZMvK0GyG0clQK4=; b=kXDBSRoKLdUh29gGcGJBONIL6MHGm2uDZaK0iHSMPGi516ORctdMK1ljUIOf92BI1C 6DXtc5kMXLfOK45g2qWJXRSlgHE1jpG3vohjvnMijK88/Sx6tq2dNXHNNnBarnVpO2Xr w5Vef0HoDFIyJZayYBVDAel5Jj65wp8ptXMmJNeu3f0dfY645JMssPOncEiAp3klt1HF Vs9aiCMo+omSmwKYuU4bZBKF6GuHOmZnKMcBs1aFakQp9/hokuiwC6pQY2SgO4hVhvkR UsEt6GhQMSBPTwdnGTyB7qB3t53I6jPCVa+vtpQXTGbBtPN4Sk3ljKoMjBWLPPIaQSiY SXKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719604571; x=1720209371; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4KMY/UWt0cp3RMMYbNQH6ciCao+RZZMvK0GyG0clQK4=; b=ZYSJANcK5WoKRdSZLU+9O6xTKgkrOTSLQJF4RBZMcwsAQNS36euQT7T9grT+CuW7T7 yYOTASDHEbsgq9rRDJ7GJHuPREJX1AQ+yApRlnIQFoh0LoZsW/MnyFvt5EjUNt2WyBcK RBIphQM90YayYYxwUP8qcbpJNlJg5UudysTn9/RF6Fl2m+V0bUDqiQwJes6kUtUeTxWZ hO/HknafWdhLYlsN6ok9FhGc9G/188ZkNehGMEr3SS95Xeg2VV8AAvJHz7Ne+6Yx/eH3 tSmciFipyCLUSkpQ+kxoPknMzTI48LU9hjdV5crnnRviLy0mcch3XZ4o0h4Yi9Sb1C86 Zn0w== X-Forwarded-Encrypted: i=1; AJvYcCXD7FzNzLTMCUe9UndiJ3tEPK7EWS17EzQcTq7rqlH+r4wsyRt+pzOe1KrF6Z8ov29XplPEVn9vpTUCpXd1cNPTdrO4Kj/O3osEYQ== X-Gm-Message-State: AOJu0YzgR0suLWuVwAn+m5VpKQC520mRG+Aa9L93fF1onNNEF9HLWKf9 iqfL3ZtOCmgMZLKotIp5UJmeKzKdVBJVJXOoi3qRYq0NGuf9yh03XBOBXvgxH8wuR7hcXe5Octp rw519P/DClfusLPuV/kjvsWJ5dQU= X-Google-Smtp-Source: AGHT+IFa8sgHteftNpluTVVzQPi6qDVj++qv3VDr7E9/PBKN6fBaBisiSSFhxqGUQp6q48qMWE4lWkDQKAulYVzbiJ4= X-Received: by 2002:a50:c35b:0:b0:57a:3046:1cd8 with SMTP id 4fb4d7f45d1cf-57d4bd5a0ddmr12994530a12.7.1719604570434; Fri, 28 Jun 2024 12:56:10 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Jun 2024 12:56:09 -0700 In-Reply-To: <871q4h3tfi.fsf@pub.pink> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288082 Archived-At: Version: 30.1 john muhl writes: > Stefan Kangas writes: > >> I think patch 2 should go to master, but it doesn't apply cleanly. >> John, could you please rebase it and resend? > > Oops, I see now it included a bit of unrelated local changes. > > Here=E2=80=99s another try. I rebased it and checked that it applies to > emacs-30 and master. Thanks! > Out of curiousity, what makes it unfit for the emacs-30 branch? We prefer not to put code cleanups on the release branch. So I've now pushed it to `master`, and I'm closing this bug report. BTW, is there any reason not to use `defvar-keymap' in lua-ts-mode.el? Does it need to be compatible with Emacs 28?