From: Stefan Kangas <stefan@marxist.se>
To: Drew Adams <drew.adams@oracle.com>
Cc: 35916@debbugs.gnu.org
Subject: bug#35916: [PATCH] checkdoc fixes in bookmark.el
Date: Mon, 27 May 2019 23:36:00 +0200 [thread overview]
Message-ID: <CADwFkmkn3JaJDbjsxvfJ5cmb_v_PZH5hBi=Yf9tBBruM=q8EhA@mail.gmail.com> (raw)
In-Reply-To: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default>
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
Drew Adams <drew.adams@oracle.com> writes:
> (Minor feedback.)
Fixed all your comments in the attached patch.
> All the other changes look like improvements, to me. Thx.
Thank you for providing this feedback.
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Checkdoc-fixes-in-bookmark.el.patch --]
[-- Type: text/x-patch, Size: 5851 bytes --]
From 5deabc350a553a41e379399335aeeacb8bb6628b Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Sun, 26 May 2019 12:48:26 +0200
Subject: [PATCH] Checkdoc fixes in bookmark.el
* bookmark.el (bookmark-bmenu-inline-header-height)
(bookmark-bmenu-marks-width, bookmark-map, bookmark-quit-flag)
(bookmark-name-from-full-record, bookmark-set-internal)
(bookmark-insert-annotation, bookmark--jump-via)
(bookmark-bmenu-set-header, bookmark-show-annotation)
(bookmark-bmenu-other-window-with-mouse, bookmark-bmenu-relocate):
Checkdoc docstring fixes.
---
lisp/bookmark.el | 38 +++++++++++++++++++++-----------------
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index b1fe690dac..c3899bcfc0 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -136,12 +136,13 @@ bookmark-bmenu-use-header-line
:group 'bookmark)
(defconst bookmark-bmenu-inline-header-height 2
- "Number of lines used for the *Bookmark List* header
-\(only significant when `bookmark-bmenu-use-header-line' is nil).")
+ "Number of lines used for the *Bookmark List* header.
+\(This is only significant when `bookmark-bmenu-use-header-line'
+is nil.)")
(defconst bookmark-bmenu-marks-width 2
- "Number of columns (chars) used for the *Bookmark List* marks column,
-including the annotations column.")
+ "Number of columns (chars) used for the *Bookmark List* marks column.
+This includes the annotations column.")
(defcustom bookmark-bmenu-file-column 30
"Column at which to display filenames in a buffer listing bookmarks.
@@ -221,7 +222,7 @@ bookmark-map
"Keymap containing bindings to bookmark functions.
It is not bound to any key by default: to bind it
so that you have a bookmark prefix, just use `global-set-key' and bind a
-key of your choice to `bookmark-map'. All interactive bookmark
+key of your choice to variable `bookmark-map'. All interactive bookmark
functions have a binding in this keymap.")
;;;###autoload (fset 'bookmark-map bookmark-map)
@@ -301,7 +302,7 @@ bookmark-yank-point
(defvar bookmark-quit-flag nil
- "Non nil make `bookmark-bmenu-search' quit immediately.")
+ "Non-nil means `bookmark-bmenu-search' quits immediately.")
\f
;; Helper functions and macros.
@@ -318,8 +319,8 @@ with-buffer-modified-unmodified
;; Everyone else should go through them.
(defun bookmark-name-from-full-record (bookmark-record)
- "Return the name of BOOKMARK-RECORD. BOOKMARK-RECORD is, e.g.,
-one element from `bookmark-alist'."
+ "Return the name of BOOKMARK-RECORD.
+BOOKMARK-RECORD is, e.g., one element from `bookmark-alist'."
(car bookmark-record))
@@ -811,7 +812,7 @@ bookmark-set-internal
(cond
((eq overwrite-or-push nil)
(if (bookmark-get-bookmark str t)
- (error "A bookmark named \"%s\" already exists." str)
+ (error "A bookmark named \"%s\" already exists" str)
(bookmark-store str (cdr record) nil)))
((eq overwrite-or-push 'overwrite)
(bookmark-store str (cdr record) nil))
@@ -936,6 +937,7 @@ bookmark-edit-annotation-mode-map
"Keymap for editing an annotation of a bookmark.")
(defun bookmark-insert-annotation (bookmark-name-or-record)
+ "Insert annotation for BOOKMARK-NAME-OR-RECORD at point."
(insert (funcall bookmark-edit-annotation-text-func bookmark-name-or-record))
(let ((annotation (bookmark-get-annotation bookmark-name-or-record)))
(if (and annotation (not (string-equal annotation "")))
@@ -1065,8 +1067,8 @@ bookmark-after-jump-hook
Useful for example to unhide text in `outline-mode'.")
(defun bookmark--jump-via (bookmark-name-or-record display-function)
- "Handle BOOKMARK-NAME-OR-RECORD, then call DISPLAY-FUNCTION with
-current buffer as argument.
+ "Handle BOOKMARK-NAME-OR-RECORD, then call DISPLAY-FUNCTION.
+DISPLAY-FUNCTION is called with the current buffer as argument.
After calling DISPLAY-FUNCTION, set window point to the point specified
by BOOKMARK-NAME-OR-RECORD, if necessary, run `bookmark-after-jump-hook',
@@ -1675,7 +1677,7 @@ 'list-bookmarks
(defalias 'edit-bookmarks 'bookmark-bmenu-list)
(defun bookmark-bmenu-set-header ()
- "Sets the immutable header line."
+ "Set the immutable header line."
(let ((header (concat "%% " "Bookmark")))
(when bookmark-bmenu-toggle-filenames
(setq header (concat header
@@ -1835,8 +1837,8 @@ bookmark-bmenu-bookmark
(defun bookmark-show-annotation (bookmark-name-or-record)
- "Display the annotation for BOOKMARK-NAME-OR-RECORD in a buffer,
-if an annotation exists."
+ "Display the annotation for BOOKMARK-NAME-OR-RECORD in a buffer.
+If the annotation does not exist, do nothing."
(let ((annotation (bookmark-get-annotation bookmark-name-or-record)))
(when (and annotation (not (string-equal annotation "")))
(save-excursion
@@ -1997,7 +1999,9 @@ bookmark-bmenu-switch-other-window
(bookmark--jump-via bookmark fun)))
(defun bookmark-bmenu-other-window-with-mouse (event)
- "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible."
+ "Select bookmark at the mouse pointer in other window.
+Move point to the position of EVENT, and leave bookmark menu
+visible."
(interactive "e")
(with-current-buffer (window-buffer (posn-window (event-end event)))
(save-excursion
@@ -2123,8 +2127,8 @@ bookmark-bmenu-locate
(message "%s" (bookmark-location bmrk))))
(defun bookmark-bmenu-relocate ()
- "Change the file path of the bookmark on the current line,
- prompting with completion for the new path."
+ "Change the absolute file name of the bookmark on the current line.
+Prompt with completion for the new path."
(interactive)
(let ((bmrk (bookmark-bmenu-bookmark))
(thispoint (point)))
--
2.11.0
next prev parent reply other threads:[~2019-05-27 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 10:59 bug#35916: [PATCH] checkdoc fixes in bookmark.el Stefan Kangas
2019-05-27 3:52 ` Drew Adams
2019-05-27 21:36 ` Stefan Kangas [this message]
2019-05-30 17:53 ` Stefan Kangas
2019-06-08 8:37 ` Eli Zaretskii
2019-06-08 17:22 ` Stefan Kangas
2019-06-09 6:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkmkn3JaJDbjsxvfJ5cmb_v_PZH5hBi=Yf9tBBruM=q8EhA@mail.gmail.com' \
--to=stefan@marxist.se \
--cc=35916@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.