From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris Date: Sat, 12 Oct 2024 08:20:52 -0500 Message-ID: References: <20241008210227.27362-2-alan.coopersmith@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33249"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ali Bahrami , Eli Zaretskii To: Alan Coopersmith , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 12 15:21:59 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szc4E-0008Rw-0i for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Oct 2024 15:21:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szc3M-00040s-EI; Sat, 12 Oct 2024 09:21:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szc3H-0003zu-Rh for emacs-devel@gnu.org; Sat, 12 Oct 2024 09:21:00 -0400 Original-Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szc3E-0001C9-GF; Sat, 12 Oct 2024 09:20:58 -0400 Original-Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-5c9625cfe4dso496184a12.0; Sat, 12 Oct 2024 06:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728739253; x=1729344053; darn=gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=uA6oKoPrnCPlTaKhdCZnS7jnvbRBOsqS8D0OkrMuFYo=; b=d2fwNvDGpqHPNBkQp7Rw4FcJsM4anWqumbMu3aAg7E6VsUj107cTCQhRNLvMNki3PI oQ15xQkfxodJ/eqYM+N1lk9iz/7AYyaS8Vzu2zqTT6gEUtd6LzWAORDwF+JbnJysV9sx 0Ah/ysEnF6Fo0OiwbyiBtzgQdB52LeHScErs3s9KoFTvRnb/qYBUBwfHBXRBt2F1MKPZ TG0DrZou8OmB4w65smC4eJt+LIl/OMNb2VRKRktjKLSRaOGfRZv/E7wwcGDjoQND3A1O FjwEmaZm68Z8l8gct7UvsQturFQiP0K8nYEnvngXTqBBl4bdfx4uRhECn9FzUrxga+yt abeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728739253; x=1729344053; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uA6oKoPrnCPlTaKhdCZnS7jnvbRBOsqS8D0OkrMuFYo=; b=ukIyyLkZz/fTJlfQmvZdfP6pewuHKDcR/NRcRUmcf8bCv2tsSYVXTYsQU4p2iHX6OY 5/ngIsVnS8QOnXxR427Y5+m0MdIGjduBFy4VWryq0tsZqnOWehWiSNxXvwt4zYbhpa5+ fjN25c+u9uv0/JI4irTJOVA6BwIF/XmuZ8D1OPYppzOyjIfesPCEvvzhu0jGGlWadn/V nWDyBabDIf64atDcjtqKBv9ITpmvjNKVLDyPw+CbCClXFbhJcBVORgIZABla2D+vxjI6 /XJodN3rLoiGCb8wcoZkzHlrm08GDda1xTyIdcWQ5EutAZD2Z4uoMZlP7KDiKE804mOW 05MA== X-Forwarded-Encrypted: i=1; AJvYcCVTjY847bMzA5RqBILhPf2UWl+bUTp4JBa/miaJMuLxzSw0RO2FR6r0pVDp9kak/xi7V7o2@gnu.org, AJvYcCVWae7XBstuHuvrektTFj9SuXAIJTwgPDWHlYJA1St0G1vsypNGDel1JZKOENmby9mA7cK+i4Nqm60dWl4=@gnu.org X-Gm-Message-State: AOJu0YzYpj/+RGgiVdiS5rRjabuTb3v31U/a5l+E05O1u0zWqLRtWtBj rqUXFlHhIrsf10TmUKsRHW1Eg2GkYlgJUY66dcqT8115+NjXwloArK63usp+reLek4RNGA5+kuI bNvxvRTfyG3HtA56WNP/oDZwIoBI= X-Google-Smtp-Source: AGHT+IEnZpNV0+0vfTm0RmUwq/7Wd/b7FPQUE+xdBwyvWXX1u1+mqCviw4+yfA7DBin+CnYcQfqUtJOfjKB+WDxJC2A= X-Received: by 2002:a05:6402:35d3:b0:5c8:bb09:b417 with SMTP id 4fb4d7f45d1cf-5c95aae07bdmr1560443a12.0.1728739253136; Sat, 12 Oct 2024 06:20:53 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Oct 2024 08:20:52 -0500 In-Reply-To: <20241008210227.27362-2-alan.coopersmith@oracle.com> Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=stefankangas@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324514 Archived-At: Alan Coopersmith writes: > Before this fix, it would fail to build with gcc-14 with the error: > conftest.c: In function 'main': > conftest.c:265:11: error: implicit declaration of function 'ioctl' > [-Wimplicit-function-declaration] > 265 | int foo = ioctl (0, FIONREAD, &foo); > | ^~~~~ > > Solaris documents ioctl() as being defined in > --- > configure.ac | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 8a5ba7db3d1..947c2827b8e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -7117,6 +7117,9 @@ AC_DEFUN > #ifdef USG5_4 > # include > #endif > + #ifdef HAVE_UNISTD_H > + # include /* defines ioctl() on Solaris */ > + #endif > ]], > [[int foo = ioctl (0, FIONREAD, &foo);]])], > [emacs_cv_usable_FIONREAD=yes], > -- > 2.45.2 I guess this should be installed on emacs-30. Eli, WDYT?