From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65621: [PATCH] `dired-next-line' go to meaningful line Date: Thu, 31 Aug 2023 23:35:26 +0200 Message-ID: References: <834jkghcu1.fsf@gnu.org> <83y1hsfw83.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20719"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Drew Adams , "65621@debbugs.gnu.org" <65621@debbugs.gnu.org> To: Shynur Xie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 31 23:36:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbpKi-00057b-4F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Aug 2023 23:36:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbpKW-0004AR-7D; Thu, 31 Aug 2023 17:35:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbpKT-0004A9-Mq for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:35:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbpKT-0000Rm-Ef for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:35:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbpKc-0007Aq-68 for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 21:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65621 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65621-submit@debbugs.gnu.org id=B65621.169351775527550 (code B ref 65621); Thu, 31 Aug 2023 21:36:02 +0000 Original-Received: (at 65621) by debbugs.gnu.org; 31 Aug 2023 21:35:55 +0000 Original-Received: from localhost ([127.0.0.1]:59380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpKV-0007AG-2r for submit@debbugs.gnu.org; Thu, 31 Aug 2023 17:35:55 -0400 Original-Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]:42108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpKS-00079o-Qo for 65621@debbugs.gnu.org; Thu, 31 Aug 2023 17:35:53 -0400 Original-Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-500760b296aso1540465e87.0 for <65621@debbugs.gnu.org>; Thu, 31 Aug 2023 14:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693517738; x=1694122538; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cN7Hhy/dsVNxzcMs+GiR4cjnW7CyXzI2nlq8OY2FlLM=; b=DpY0eUxaUTEtE7sFmmhuXXkOrIYnEl1fsoJwQyVHQ88Z04hFp1Ha/haBa/MdItMmXq lRdRkTLFynvnkFzRgA0pR0g6LzfCoaliVtW6YF09iGA8econYGxmWP/gLCTo+h1aPtRN YRBx9LYAlSpzBsp1NuenDryWryUeda2yRT82c0vSyVECTtN+ETOc7+yv5BET4zT4floX TnfINckhuSaaK4UTfGD9NpyFKKVli2lQm2xbxL0Ndf2Y2BiPra8/0uz7N1FN1QDrREFe RGjXJ6q3uI9S2FSaiRmlcwgwUPEq8hFbDgO4kEie617UeBfwaydREgBUxWt0yshFwRd9 4Jzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693517738; x=1694122538; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cN7Hhy/dsVNxzcMs+GiR4cjnW7CyXzI2nlq8OY2FlLM=; b=jLlr+tADzU1PIOa0MAxq/x46zxzLcLXzR9ncTYyZUFMdYuWnQue7P/TiFMKspY+2+t tINR9mrfW54tBVnC1EzP23UZbnNde2PwfqL3azQ9R3DKYZYD+/PJDwaQgFpWgya4wSCz u9RjdMag2UxEwZmtgw+hjgk+vWlHcGrtOgc9LjznhMnYMDEO/MJ02vkkDcQJ5sMB3RlR mtqMiX77g5lVwDOXAaUWiG8uK9Hz5klybDUlHIlAtXWi5tWnaFXYNx9eTvvukhAMBWXg Y7gBikWXnImrqa3a17Xb4MGoaZRTXofJGEPf02iUWb+BzzjGhNywe7xcOEzsBvXeFfoX kQYg== X-Gm-Message-State: AOJu0Yx7ybLEtYVpVYyY7goFJ3fgK9bg3xDJDNvZ29KuGWVX2/loO+oy fGyyv2i4epNy0VCCs1jLjf1eJxPGGDh02Jl7x1g= X-Google-Smtp-Source: AGHT+IEeu/Umr1+c5IV7D+wTodKlR99mQwBuQdDolDanSwTUNC6idBa7PlU0FcbAmvALEFyEbYt8hyzX48r2lFYWpOI= X-Received: by 2002:a05:6512:3f1a:b0:4fb:8aca:6bb4 with SMTP id y26-20020a0565123f1a00b004fb8aca6bb4mr1275889lfa.20.1693517738061; Thu, 31 Aug 2023 14:35:38 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268847 Archived-At: Shynur Xie writes: > The final patch is attached. (See the end for how to test it.) Thanks. > There is totally 4 (not 6) kinds of combinations of the 2 new options: > > 1. (setq dired-cursor-goto-meaningful-line 'bounded > dired-headerline-is-meaningful nil) > 2. (setq dired-cursor-goto-meaningful-line 'cycle > dired-headerline-is-meaningful nil) > 3. (setq dired-cursor-goto-meaningful-line 'bounded > dired-headerline-is-meaningful t) > 4. (setq dired-cursor-goto-meaningful-line 'cycle > dired-headerline-is-meaningful t) I'll review your patch in detail as soon as I can find some time. Just two initial comments: I like the option `dired-cursor-goto-meaningful-line', which seems to both add wrap-around and make the feature as a whole optional. But in Emacs, we say "point" rather than "cursor", so we'd have to change that. I suggest naming it `dired-movement-style', or something along those lines. But is `dired-headerline-is-meaningful' really needed? It seems like an unnecessary complication.