From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: Delete variables obsolete since Emacs 23 Date: Wed, 26 Aug 2020 20:51:50 -0700 Message-ID: References: <20200515175844.18941.61355@vcs0.savannah.gnu.org> <20200515175845.997EC20999@vcs0.savannah.gnu.org> <20083fc0-59ca-444b-b18d-69e2f79d8c57@default> <87sgcknqz0.fsf@gnus.org> <8dacbc9d-def9-4d38-8f73-11de3884d927@default> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10068"; mail-complaints-to="usenet@ciao.gmane.io" Cc: ghe@sdf.org, larsi@gnus.org, monnier@iro.umontreal.ca, drew.adams@oracle.com, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 27 05:52:32 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kB8xj-0002Wq-P1 for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Aug 2020 05:52:31 +0200 Original-Received: from localhost ([::1]:52672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kB8xi-0005Kb-SE for ged-emacs-devel@m.gmane-mx.org; Wed, 26 Aug 2020 23:52:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB8x8-0004sd-NU for emacs-devel@gnu.org; Wed, 26 Aug 2020 23:51:54 -0400 Original-Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:38631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kB8x7-0003kV-1i; Wed, 26 Aug 2020 23:51:54 -0400 Original-Received: by mail-yb1-xb2a.google.com with SMTP id e187so2187474ybc.5; Wed, 26 Aug 2020 20:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=zlMozpRlr7jueAFmFZlO9l43IYlsHN6Icg0IPjrHumc=; b=sNoWnMgXnuPcJA6U8+tV0B1cwFCKzSHvsWdosBVXB3aOw25Our3Pu8KrkNkZjaW2am HOunELliJKX9oZh2uasPGaDz8xlIcM+FSGbAONfnp1NWBDTGchBJp7ugvLN2JZB0PDOo dgnRqc4S4E+zkQzFTQeAVgcAEcUpesvd5gOz8F3ztv8a5f5dWZc5dcprv2LOY7YcEqRH SvM34BJ919mnN5ltapnct/e1OYIGvn9ZnLNNR2DmWJ2IIOKkdFJdKjOqkFqFPY9mrEgd Bheo0NhdH7Szn1kc7vfVG71h0La3NAsXPj6MqtH/rXpgwxpVgx135zdkGuOrwNpXbsyz D3kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=zlMozpRlr7jueAFmFZlO9l43IYlsHN6Icg0IPjrHumc=; b=BC/ngFlT+tcPyPYWE36II/c8SdyFQHdOQ4ze5Pi9oyCDdkZvYnZWVo5bNJPvE14tcA 3gti3UtLgt9T0JkIQWVNAyjhJgNEa8JkcqDzhHi7g5SsqkZB4GVMbvPJeJMEccO2PYds woMFeLPXYQCBEkt52nkqiQl3DTk/xm66BwVcuac4quKXKEOAf1XFPI25FVrw3TIOgjA9 cKqqrEwBK54bqpYwNLoZpmsr9iPDl3KwEDBOy1Q2vsIDrNpOu0VMG0JK3yvQ3wLYOWzQ A2jVBGupNr/Dab/pAPXCbnQHh/+Dj1Cs7YZY2WNIDtLWwD7s37Az6Wvjc6Du0/3V0lcw VXMw== X-Gm-Message-State: AOAM531qwH6IgzZ47aS0H4aBPfGfFLiWP0+SdBq71roQOKq65VEVr+qK 4IeoOmjbbwEyA2HV7B0H4GHU+70Bl/5YJes7aEkfaV9n X-Google-Smtp-Source: ABdhPJwPisjndZ8k2CQDeo3hKjahjnb+ZoHnAedtmz2qwc8Bww4ftKrh6O9PzeIirTzD+GBmlhNKBHoTIRtynolHZrk= X-Received: by 2002:a5b:410:: with SMTP id m16mr25034552ybp.309.1598500311326; Wed, 26 Aug 2020 20:51:51 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 Aug 2020 20:51:50 -0700 In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b2a; envelope-from=stefankangas@gmail.com; helo=mail-yb1-xb2a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254270 Archived-At: Richard Stallman writes: > > My commit bc5da2c3fb does basically the following: > > > - (help-setup-xref (list 'describe-symbols pattern) (interactive-p= )) > > + (help-setup-xref (list 'describe-symbols pattern) > > + (called-interactively-p 'interactive)) > > That is not the recommend way to fix these calls. > called-interactively-p does not give the correct results in all > situations. The right way is to make the optional argument. This was simply to not use the old deprecated name, which AFAIU is being considered for removal. Perhaps we could also expand the section in the Manual that explains why using an optional argument is better, and make the wording stronger. Here's what I read in `(info "(elisp) Distinguish Interactive")': The above method with the additional argument is usually best, because it allows callers to say =E2=80=9Ctreat this call as interactiv= e=E2=80=9D. But you can also do the job by testing =E2=80=98called-interactively-p=E2= =80=99.