bug#40823: Test threads-join-error fails in test/src/thread-tests.log

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Stefan Kangas]

When running 'make check-all' on master, I get this unexpected result:

Test threads-join-error backtrace:
  signal(ert-test-failed (((should-error (thread-join thread)) :form (
  ert-fail(((should-error (thread-join thread)) :form (thread-join #<t
  (if errorp106 nil (ert-fail (append (funcall form-description-fn-107
  (let ((errorp106 nil) (form-description-fn-107 #'(lambda nil form-de
  (let (form-description-105) (let ((errorp106 nil) (form-description-
  (let ((value-103 'ert-form-evaluation-aborted-104)) (let (form-descr
  (let* ((fn-101 #'thread-join) (args-102 (condition-case err (let ((s
  (let ((thread (make-thread #'threads-call-error))) (while (thread-li
  (lambda nil (let* ((fn-96 #'featurep) (args-97 (condition-case err (
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name threads-join-error :documentation "Te
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(t)
  ert-run-tests-batch-and-exit(t)
  eval((ert-run-tests-batch-and-exit 't) t)
  command-line-1(("-L" ":." "-l" "ert" "-l" "src/thread-tests.el" "--e
  command-line()
  normal-top-level()
Test threads-join-error condition:
    (ert-test-failed
     ((should-error
       (thread-join thread))
      :form
      (thread-join #<thread 0x55c379595b60>)
      :value nil :fail-reason "did not signal an error"))
   FAILED  14/32  threads-join-error (0.000154 sec)

In GNU Emacs 28.0.50 (build 16, x86_64-pc-linux-gnu, GTK+ Version
3.24.18, cairo version 1.16.0)
 of 2020-04-24 built on joffe
Repository revision: 367b55980f9c0c927dce2ba93ab6f626cec6b1fc
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Fri, 24 Apr 2020 18:27:33 +0200
> 
> When running 'make check-all' on master, I get this unexpected result:
> 
> Test threads-join-error backtrace:
>   signal(ert-test-failed (((should-error (thread-join thread)) :form (

Can't reproduce this here, neither on MS-Windows nor on GNU/Linux.

Maybe it's related to the fine details of the build configuration?

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> When running 'make check-all' on master, I get this unexpected result:
>> 
>> Test threads-join-error backtrace:
>>   signal(ert-test-failed (((should-error (thread-join thread)) :form (
>
> Can't reproduce this here, neither on MS-Windows nor on GNU/Linux.
>
> Maybe it's related to the fine details of the build configuration?

I tried "./configure ; make -j9 bootstrap ; make -j9 check-all" and
can reproduce this consistently.  I'm running Debian testing (also
known as "bullseye").

Here are my full build details:


In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.18, cairo version 1.16.0)
 of 2020-04-26 built on joffe
Repository revision: 763df4bc171c9742cf04b029ddfe495d52461bcf
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Debian GNU/Linux bullseye/sid

Configured using:
 'configure
 PKG_CONFIG_PATH=/home/skangas/usr/lib/pkgconfig:/home/skangas/usr/lib/pkgconfig:'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD
PDUMPER LCMS2 GMP

Important settings:
  value of $LC_COLLATE: C
  value of $LC_CTYPE: sv_SE.UTF-8
  value of $LC_TIME: C
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core term/tty-colors frame minibuffer cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 45091 5646)
 (symbols 48 5987 1)
 (strings 32 15682 1523)
 (string-bytes 1 510229)
 (vectors 16 9991)
 (vector-slots 8 130513 10832)
 (floats 8 19 43)
 (intervals 56 191 0)
 (buffers 992 10))

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Cc: 40823@debbugs.gnu.org
> Date: Sun, 26 Apr 2020 16:56:23 +0200
> 
> I tried "./configure ; make -j9 bootstrap ; make -j9 check-all" and
> can reproduce this consistently.

What about just "cd test && make src/thread-tests"?

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Stefan Kangas <stefan@marxist.se>
>> Cc: 40823@debbugs.gnu.org
>> Date: Sun, 26 Apr 2020 16:56:23 +0200
>> 
>> I tried "./configure ; make -j9 bootstrap ; make -j9 check-all" and
>> can reproduce this consistently.
>
> What about just "cd test && make src/thread-tests"?

That works as expected:

    Ran 31 tests, 31 results as expected, 0 unexpected (2020-04-26 17:49:31+0200, 3.324151 sec)

But AFAICT that method of running the tests doesn't run the failing
test from "make check-all":

       FAILED  14/32  threads-join-error (0.000285 sec)

The summary for "make check-all" reads:

    Ran 32 tests, 31 results as expected, 1 unexpected (2020-04-26 17:33:58+0200, 3.489824 sec)

(Note that there are 32 tests here instead of the 31 from above.)

Best regards,
Stefan Kangas

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Cc: 40823@debbugs.gnu.org
> Date: Sun, 26 Apr 2020 17:55:09 +0200
> 
> > What about just "cd test && make src/thread-tests"?
> 
> That works as expected:
> 
>     Ran 31 tests, 31 results as expected, 0 unexpected (2020-04-26 17:49:31+0200, 3.324151 sec)
> 
> But AFAICT that method of running the tests doesn't run the failing
> test from "make check-all":
> 
>        FAILED  14/32  threads-join-error (0.000285 sec)

Why doesn't it run that test?

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> That works as expected:
>> 
>>     Ran 31 tests, 31 results as expected, 0 unexpected (2020-04-26 17:49:31+0200, 3.324151 sec)
>> 
>> But AFAICT that method of running the tests doesn't run the failing
>> test from "make check-all":
>> 
>>        FAILED  14/32  threads-join-error (0.000285 sec)
>
> Why doesn't it run that test?

It was tagged "unstable".  The test/README file says "unstable" means:
"The test is under development.  It shall run on demand only."

And, according to the same file, "check-all" is one way to demand that
even "unstable" tests are run.

So I guess then that this is all expected, and I should just be using
"check-expensive" instead of "check-all" if I don't want to see this
failure?

Best regards,
Stefan Kangas

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Cc: 40823@debbugs.gnu.org
> Date: Sun, 26 Apr 2020 22:34:05 +0200
> 
> >>        FAILED  14/32  threads-join-error (0.000285 sec)
> >
> > Why doesn't it run that test?
> 
> It was tagged "unstable".  The test/README file says "unstable" means:
> "The test is under development.  It shall run on demand only."
> 
> And, according to the same file, "check-all" is one way to demand that
> even "unstable" tests are run.
> 
> So I guess then that this is all expected, and I should just be using
> "check-expensive" instead of "check-all" if I don't want to see this
> failure?

Sounds like that, yes.

bug#40823: Test threads-join-error fails in test/src/thread-tests.log

[Stefan Kangas]

tags 40823 + notabug
close 40823
thanks

Eli Zaretskii <eliz@gnu.org> writes:

>> So I guess then that this is all expected, and I should just be using
>> "check-expensive" instead of "check-all" if I don't want to see this
>> failure?
>
> Sounds like that, yes.

Thanks Eli for walking me through this.  Closing the bug now.

Best regards,
Stefan Kangas