From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44673: [PATCH] Use lexical-binding in time-stamp.el Date: Sun, 15 Nov 2020 16:57:00 -0800 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000230e2305b42edb95" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stepheng+emacs@gildea.com To: 44673@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 16 01:58:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1keSqV-0000TM-D2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 01:58:15 +0100 Original-Received: from localhost ([::1]:44416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keSqT-00086d-Sk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Nov 2020 19:58:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keSqI-00086C-UZ for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 19:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keSqI-0008Ma-Li for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 19:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1keSqI-0005Iq-Lh for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 19:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Nov 2020 00:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44673 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160548822720317 (code B ref -1); Mon, 16 Nov 2020 00:58:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Nov 2020 00:57:07 +0000 Original-Received: from localhost ([127.0.0.1]:54634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keSpO-0005Hd-SN for submit@debbugs.gnu.org; Sun, 15 Nov 2020 19:57:07 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:33116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keSpN-0005HW-9a for submit@debbugs.gnu.org; Sun, 15 Nov 2020 19:57:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keSpN-00081H-1A for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 19:57:05 -0500 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:34367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1keSpL-0008ID-Co for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2020 19:57:04 -0500 Original-Received: by mail-ed1-f46.google.com with SMTP id a15so17049878edy.1 for ; Sun, 15 Nov 2020 16:57:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to:cc; bh=VBk7uysqWwCoYxRJPaGIrFThXINJV3PAH1wxnyyAWbc=; b=qP38S2tEJ4S9IB7kLn7cO8kRRX2MSFw/FQelj2QUXl54OJrjw5TuQ1z/0Czvm0OZt7 Bufe6S9ZDGGbs1ql91rie932lx1Y9a5fyOTXb9L4yHIn8X/XV+mhr6zx8ETyx/7gLEbK vSWNDcDJhfmBEuOvFEmTjwPwkdxX+u9Sn7CTihO02zCDN1msWCP8y6TvQw5byKzW5jGk nkHw3KrN6tRem74qiQohNVK/wMUhiOhev9B8RSbNYkPy63o3xx6CtKwvsefl3Y0gZ9Xq 31a0/qNIequkgVOuvneMMBvxMG619wWXEr/Fc9LrptJ5kKpWT963EMU8C4tX4G+dt3SQ shDw== X-Gm-Message-State: AOAM531+HMyTUhCoA9ANZGtfd8oxbiqYTp4+UlHesdOVNCkdd7tLMzN0 xIvf71it+V2OHLfQL07ekjfJVbCgtQ63nSgE1fo07D3a X-Google-Smtp-Source: ABdhPJzi5Nt2CZzxel2DpfHX4mFBpzN06Xv/qFMJjDHANEKUWN8N2nwIVSvdLjcMHhD/Vy77JiUnInPRmWTV832pBX0= X-Received: by 2002:a50:bb25:: with SMTP id y34mr13014364ede.249.1605488221544; Sun, 15 Nov 2020 16:57:01 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Nov 2020 16:57:00 -0800 Received-SPF: pass client-ip=209.85.208.46; envelope-from=stefankangas@gmail.com; helo=mail-ed1-f46.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 19:57:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193398 Archived-At: --000000000000230e2305b42edb95 Content-Type: text/plain; charset="UTF-8" Severity: wishlist Hi Stephen, I see that you have put a lot of work into building a test suite for time-stamp.el - thanks! Do you think we could safely enable lexical-binding in time-stamp.el? I ran the test suite with the attached patch and all tests are still passing. Thanks in advance. --000000000000230e2305b42edb95 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Use-lexical-binding-in-time-stamp.el.patch" Content-Disposition: attachment; filename="0001-Use-lexical-binding-in-time-stamp.el.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 15454585a5753f30_0.1 RnJvbSBlNGM4OWM4ODRlM2IyZDlhYjhjMjJkYzhjZmE3ZTgzNzJjZDFjMGE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogU3VuLCAxNSBOb3YgMjAyMCAyMDoxMjo0NSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFVzZSBs ZXhpY2FsLWJpbmRpbmcgaW4gdGltZS1zdGFtcC5lbAoKKiBsaXNwL3RpbWUtc3RhbXAuZWw6IFVz ZSBsZXhpY2FsLWJpbmRpbmcuICBSZW1vdmUgcmVkdW5kYW50IDpncm91cAphcmdzLgotLS0KIGxp c3AvdGltZS1zdGFtcC5lbCB8IDggKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90aW1lLXN0YW1wLmVsIGIv bGlzcC90aW1lLXN0YW1wLmVsCmluZGV4IDdjNjRmMjkwM2IuLmM1MGQ2OGI2MGEgMTAwNjQ0Ci0t LSBhL2xpc3AvdGltZS1zdGFtcC5lbAorKysgYi9saXNwL3RpbWUtc3RhbXAuZWwKQEAgLTEsNCAr MSw0IEBACi07OzsgdGltZS1zdGFtcC5lbCAtLS0gTWFpbnRhaW4gbGFzdCBjaGFuZ2UgdGltZSBz dGFtcHMgaW4gZmlsZXMgZWRpdGVkIGJ5IEVtYWNzCis7OzsgdGltZS1zdGFtcC5lbCAtLS0gTWFp bnRhaW4gbGFzdCBjaGFuZ2UgdGltZSBzdGFtcHMgaW4gZmlsZXMgZWRpdGVkIGJ5IEVtYWNzICAt Ki0gbGV4aWNhbC1iaW5kaW5nOiB0IC0qLQogCiA7OyBDb3B5cmlnaHQgKEMpIDE5ODksIDE5OTMt MTk5NSwgMTk5NywgMjAwMC0yMDIwIEZyZWUgU29mdHdhcmUKIDs7IEZvdW5kYXRpb24sIEluYy4K QEAgLTg3LDcgKzg3LDYgQEAgdGltZS1zdGFtcC1mb3JtYXQKIFRoZSBiZWhhdmlvciBvZiBgJTV6 JyBpcyBuZXcgaW4gRW1hY3MgMjcuICBJZiB5b3VyIGZpbGVzIG1pZ2h0IGJlCiBlZGl0ZWQgYnkg b2xkZXIgdmVyc2lvbnMgb2YgRW1hY3MgYWxzbywgZG8gbm90IHVzZSB0aGlzIGZvcm1hdCB5ZXQu IgogICA6dHlwZSAnc3RyaW5nCi0gIDpncm91cCAndGltZS1zdGFtcAogICA6dmVyc2lvbiAiMjcu MSIpCiA7OzsjIyNhdXRvbG9hZChwdXQgJ3RpbWUtc3RhbXAtZm9ybWF0ICdzYWZlLWxvY2FsLXZh cmlhYmxlICdzdHJpbmdwKQogCkBAIC0xMDIsOCArMTAxLDcgQEAgdGltZS1zdGFtcC1hY3RpdmUK IG9yIGN1c3RvbWl6ZSBvcHRpb24gYGJlZm9yZS1zYXZlLWhvb2snLgogCiBTZWUgYWxzbyB0aGUg dmFyaWFibGUgYHRpbWUtc3RhbXAtd2Fybi1pbmFjdGl2ZScuIgotICA6dHlwZSAnYm9vbGVhbgot ICA6Z3JvdXAgJ3RpbWUtc3RhbXApCisgIDp0eXBlICdib29sZWFuKQogCiAoZGVmY3VzdG9tIHRp bWUtc3RhbXAtd2Fybi1pbmFjdGl2ZSB0CiAgICJIYXZlIFxcW3RpbWUtc3RhbXBdIHdhcm4gaWYg YSBidWZmZXIgZGlkIG5vdCBnZXQgdGltZS1zdGFtcGVkLgpAQCAtMTExLDcgKzEwOSw2IEBAIHRp bWUtc3RhbXAtd2Fybi1pbmFjdGl2ZQogZGVhY3RpdmF0ZWQgdGltZSBzdGFtcGluZyBhbmQgdGhl IGJ1ZmZlciBjb250YWlucyBhIHRlbXBsYXRlIHRoYXQKIG90aGVyd2lzZSB3b3VsZCBoYXZlIGJl ZW4gdXBkYXRlZC4iCiAgIDp0eXBlICdib29sZWFuCi0gIDpncm91cCAndGltZS1zdGFtcAogICA6 dmVyc2lvbiAiMTkuMjkiKQogCiAoZGVmY3VzdG9tIHRpbWUtc3RhbXAtdGltZS16b25lIG5pbApA QCAtMTI1LDcgKzEyMiw2IEBAIHRpbWUtc3RhbXAtdGltZS16b25lCiAgICAgICAgICAgICAgICAg ICAgICAgIChpbnRlZ2VyIDp0YWcgIk9mZnNldCAoc2Vjb25kcyBlYXN0IG9mIFVUQykiKQogICAg ICAgICAgICAgICAgICAgICAgICAoc3RyaW5nIDp0YWcgIlRpbWUgem9uZSBhYmJyZXZpYXRpb24i KSkKICAgICAgICAgICAgICAgICAgKGludGVnZXIgOnRhZyAiT2Zmc2V0IChzZWNvbmRzIGVhc3Qg b2YgVVRDKSIpKQotICA6Z3JvdXAgJ3RpbWUtc3RhbXAKICAgOnZlcnNpb24gIjIwLjEiKQogOzs7 IyMjYXV0b2xvYWQocHV0ICd0aW1lLXN0YW1wLXRpbWUtem9uZSAnc2FmZS1sb2NhbC12YXJpYWJs ZSAndGltZS1zdGFtcC16b25lLXR5cGUtcCkKIAotLSAKMi4yOS4yCgo= --000000000000230e2305b42edb95--