From: Stefan Kangas <stefan@marxist.se>
To: 44673@debbugs.gnu.org
Cc: stepheng+emacs@gildea.com
Subject: bug#44673: [PATCH] Use lexical-binding in time-stamp.el
Date: Sun, 15 Nov 2020 16:57:00 -0800 [thread overview]
Message-ID: <CADwFkmkfmJaH4XVud_3yXp6oz-PDRKipXe5AFWfMi7f5G+80qg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
Severity: wishlist
Hi Stephen,
I see that you have put a lot of work into building a test suite for
time-stamp.el - thanks!
Do you think we could safely enable lexical-binding in time-stamp.el?
I ran the test suite with the attached patch and all tests are still
passing.
Thanks in advance.
[-- Attachment #2: 0001-Use-lexical-binding-in-time-stamp.el.patch --]
[-- Type: text/x-diff, Size: 2036 bytes --]
From e4c89c884e3b2d9ab8c22dc8cfa7e8372cd1c0a7 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefan@marxist.se>
Date: Sun, 15 Nov 2020 20:12:45 +0100
Subject: [PATCH] Use lexical-binding in time-stamp.el
* lisp/time-stamp.el: Use lexical-binding. Remove redundant :group
args.
---
lisp/time-stamp.el | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lisp/time-stamp.el b/lisp/time-stamp.el
index 7c64f2903b..c50d68b60a 100644
--- a/lisp/time-stamp.el
+++ b/lisp/time-stamp.el
@@ -1,4 +1,4 @@
-;;; time-stamp.el --- Maintain last change time stamps in files edited by Emacs
+;;; time-stamp.el --- Maintain last change time stamps in files edited by Emacs -*- lexical-binding: t -*-
;; Copyright (C) 1989, 1993-1995, 1997, 2000-2020 Free Software
;; Foundation, Inc.
@@ -87,7 +87,6 @@ time-stamp-format
The behavior of `%5z' is new in Emacs 27. If your files might be
edited by older versions of Emacs also, do not use this format yet."
:type 'string
- :group 'time-stamp
:version "27.1")
;;;###autoload(put 'time-stamp-format 'safe-local-variable 'stringp)
@@ -102,8 +101,7 @@ time-stamp-active
or customize option `before-save-hook'.
See also the variable `time-stamp-warn-inactive'."
- :type 'boolean
- :group 'time-stamp)
+ :type 'boolean)
(defcustom time-stamp-warn-inactive t
"Have \\[time-stamp] warn if a buffer did not get time-stamped.
@@ -111,7 +109,6 @@ time-stamp-warn-inactive
deactivated time stamping and the buffer contains a template that
otherwise would have been updated."
:type 'boolean
- :group 'time-stamp
:version "19.29")
(defcustom time-stamp-time-zone nil
@@ -125,7 +122,6 @@ time-stamp-time-zone
(integer :tag "Offset (seconds east of UTC)")
(string :tag "Time zone abbreviation"))
(integer :tag "Offset (seconds east of UTC)"))
- :group 'time-stamp
:version "20.1")
;;;###autoload(put 'time-stamp-time-zone 'safe-local-variable 'time-stamp-zone-type-p)
--
2.29.2
next reply other threads:[~2020-11-16 0:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 0:57 Stefan Kangas [this message]
2020-11-16 17:33 ` bug#44673: [PATCH] Use lexical-binding in time-stamp.el Stephen Gildea
2020-11-16 18:49 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkfmJaH4XVud_3yXp6oz-PDRKipXe5AFWfMi7f5G+80qg@mail.gmail.com \
--to=stefan@marxist.se \
--cc=44673@debbugs.gnu.org \
--cc=stepheng+emacs@gildea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.