From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59443: 29.0.50; [PATCH] Allow goto-address-at-point to use secondary browser Date: Mon, 21 Nov 2022 05:52:41 -0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39072"; mail-complaints-to="usenet@ciao.gmane.io" To: Gabriel , 59443@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 21 14:53:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ox7EV-0009ym-1N for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Nov 2022 14:53:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox7EO-000706-Cg; Mon, 21 Nov 2022 08:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox7EN-0006zu-0L for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 08:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ox7EM-00037v-Np for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 08:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ox7EM-0001EA-CK for bug-gnu-emacs@gnu.org; Mon, 21 Nov 2022 08:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Nov 2022 13:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59443 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59443-submit@debbugs.gnu.org id=B59443.16690387724698 (code B ref 59443); Mon, 21 Nov 2022 13:53:02 +0000 Original-Received: (at 59443) by debbugs.gnu.org; 21 Nov 2022 13:52:52 +0000 Original-Received: from localhost ([127.0.0.1]:45827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox7EC-0001Dh-0D for submit@debbugs.gnu.org; Mon, 21 Nov 2022 08:52:52 -0500 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:39495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ox7E7-0001DR-MP for 59443@debbugs.gnu.org; Mon, 21 Nov 2022 08:52:50 -0500 Original-Received: by mail-oi1-f180.google.com with SMTP id m204so12568106oib.6 for <59443@debbugs.gnu.org>; Mon, 21 Nov 2022 05:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=oeENKQ4r2OzJDJvBFuXB+LEJdA9MHMqUbZgKN6wb068=; b=KkGBYBm1XHC7yD+VbPkuKNU5zi70eLOIq9wMopZjS8kzuyG9TjruZ5H9IDeExaRNLF eCq/KIu0CfxRLbd7fYdXv8WebpxAVNwIw43WsMysp0eEKARXz4eNbi2LHUGrkteFmbzC 9cVVyBCgKeq1jwyEvpoRlyZI382/oBM+SAYPvyYJSVPp9V3j0CZ76PZnHD4ZSp63v+K/ HWFs+JtfPNzLIt1GyE3kOABCyHzsZL/U4oearh6aopdN8hOrismZ4+0yU3At3ph67iYx nwYYQDogEmgUuC07Md5lLRcJEG9LV1RXJ9ueP8P8qi1qGwqO0xk6kvI9oRvkB+JLXfpj DCjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oeENKQ4r2OzJDJvBFuXB+LEJdA9MHMqUbZgKN6wb068=; b=tIkCoel0JKVlU6XlJqTNBGceBlM6xTa6VoKMZoErH7filwarrSPAcqabSC41HzopQK T6FN2yJAYrpGPUssEC6U8zPcyHcDIfmKcbOYnJeRDEebNXko44ImcwEX0JbJrNUqw0jv k/B5n3iHy67+++6tJnhkY2/5yeRwSej5oPNEWMl8Esx1lnmEOg3FWh82Hk5oZYUhmHHe EVg4Qy7nablC+Xher8sg5gPmKlhrxqzJ3A7iWJvNOsgQkLyT0oB3JSvX+6zgdW54V3xZ w7dktVB7knhqCWu98UHvTHidGcnfwh/5D+ju7fSLu+mu5wo67xSPRxjrO9xnxhwm06RJ /xOg== X-Gm-Message-State: ANoB5pk8XzbNGBPlkWcrFL0Nsz+jo3pMJ1/MPKGzkI7m0Yb4ChL+R3DP 5WfqRxAR3ia4BS6I9u+G/GNfDjxeBd95SFjVmGQ= X-Google-Smtp-Source: AA0mqf5rkNnViFNnWL2fJaGSS8NVuVIUw1nSZKO7dbDOc8a4eeWWDCzYlwHYti5yGj9fHHAsu3+eNyJuxL8/xt+05tI= X-Received: by 2002:a05:6808:1287:b0:359:dc32:4f9e with SMTP id a7-20020a056808128700b00359dc324f9emr1002834oiw.92.1669038761784; Mon, 21 Nov 2022 05:52:41 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 21 Nov 2022 05:52:41 -0800 In-Reply-To: X-Hashcash: 1:20:221121:gabriel376@hotmail.com::qK5u74PyiLBAxhIn:6Hsa X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248532 Archived-At: I didn't really study the patch or the issue, but here are two nits. Gabriel writes: > * lisp/net/dictionary.el (goto-address-at-point): Call > `browse-url-button-open-url', so a prefix argument uses > `browse-url-secondary-browser-function'. ^^ We do not indent the commit message like this. It should start at column 0. > ;;;###autoload > (defun goto-address-at-point (&optional event) > - "Send to the e-mail address or load the URL at point. > -Send mail to address at point. See documentation for > -`goto-address-find-address-at-point'. If no address is found > -there, then load the URL at or before point." > + "Compose a new message to the e-mail address or browse the URL at > +point. The first line of a docstring should be a complete sentence (for e.g. eldoc and apropos).