From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC spec Date: Thu, 25 Jul 2024 00:06:28 -0700 Message-ID: References: <83bkd1sjr1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25162"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Pettersson , 66144@debbugs.gnu.org, Eli Zaretskii , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Javier Olaechea Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 25 09:08:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWsaM-0006Sj-R1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jul 2024 09:08:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWsZz-0002ii-67; Thu, 25 Jul 2024 03:07:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWsZw-0002ZO-Oe for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 03:07:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWsZw-0005A1-3v for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 03:07:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWsa1-0004ag-R4 for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 03:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2024 07:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66144 X-GNU-PR-Package: emacs Original-Received: via spool by 66144-submit@debbugs.gnu.org id=B66144.172189126617618 (code B ref 66144); Thu, 25 Jul 2024 07:08:01 +0000 Original-Received: (at 66144) by debbugs.gnu.org; 25 Jul 2024 07:07:46 +0000 Original-Received: from localhost ([127.0.0.1]:35227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWsZl-0004a4-Lx for submit@debbugs.gnu.org; Thu, 25 Jul 2024 03:07:45 -0400 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:45242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWsZi-0004Zn-8u for 66144@debbugs.gnu.org; Thu, 25 Jul 2024 03:07:44 -0400 Original-Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5a2ffc34677so743967a12.2 for <66144@debbugs.gnu.org>; Thu, 25 Jul 2024 00:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721891189; x=1722495989; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=QkSeutF8PYzX0CO6dTqUJ9n8c1Tq/mgNXYpbB3bH12U=; b=SG5iG6YyfJLGpXyfyNcyer44vwQVC6Atiql8Lll4njS+f0lBZMAGalGxVkSJ6yVJjQ Yny/KI2lq5Goh4HUVUwdxPnT+6wpPl1p+iud/fzCicddlCRrd1FS8Pkx0STCNxr7tqjV sPYeLV/HMwLyYwt1DkDIfazA15PA24YW7kFB0H+3TVZoWN1Jo50MyA58e4XPl0yITmTe CfSHro4NUHBlFGMV80mEhCZO2GbZM2wfB616cJab9wZuI9ido2l2i6ytma+kOxNASVix wo3QYj3nGxC+bo/JAYPNhFRunTY1XPIavX5Yn6znfkB27ivvEjEit9f3RTN5ZkomXis7 kuoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721891189; x=1722495989; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QkSeutF8PYzX0CO6dTqUJ9n8c1Tq/mgNXYpbB3bH12U=; b=PneW0ZeIwlRVm1q86rf8rTJCucUMYS693ODog4yNvUGU5fOm0V+HrqwXLX2YWkVrQP OkZumHHi1S+bZXpYF5g9krzFFctoI+c3f7Fr3hJkMnhziXYj9ikrc6puVdW9hDD6+cCE UlCEqkQKuJ+M4IX+RmpVQFaCxzH/ge/wDkZV4LA1yTjodpAiUwZ1wU5xYbNpXy1JFo5f KhtGGdixusmeH/KqfxCfE7eGZ3vpzOzsrQszxk++CNP4fF3auVlWQ0699S60ZtTCk9Ig Jom17TXMsJsFjvwVdpfHgT45NzNq2a6iuV0xofFTf+3eqcMn8FG/otMO01kwXuLQ3q8N 9MIQ== X-Gm-Message-State: AOJu0Yyhf8TC1DYtzWwodvQ7W4a+3LPVaitbr5dXis16IMaiBxEOVtnC d55SpUIr4hDMwzgSSVHi8wHTPEEOSnsu+5yTPY0Khd1pAjx2wJQgu8AuQOzJmlEYaQ2Qmzn/hJ7 +n9TaqLvgJuf+uxJI6cKK1d0D4Mw= X-Google-Smtp-Source: AGHT+IFBLWeLLUXXY6wNjiwj2b3L3hb74zDuwsSim1PRb2tshMWFWBu578B8SpgYfnpAagiXjDgYBghNDvlbJTsZF4E= X-Received: by 2002:a05:6402:5216:b0:5a1:f74d:2d58 with SMTP id 4fb4d7f45d1cf-5ac2c1c443cmr1289927a12.24.1721891189173; Thu, 25 Jul 2024 00:06:29 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 25 Jul 2024 00:06:28 -0700 In-Reply-To: (Javier Olaechea's message of "Sat, 3 Feb 2024 23:15:18 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289275 Archived-At: Javier Olaechea writes: > I did sit down twice to read the jsonrpc.el code and understand what I need to do to make the > change I hoped to. But unfortunately I can't even say I understood jsonrpc--async-request-1 well > enough.Or even, if that is indeed the function we need to change so that we don't seed a params > attribute when params is nil. It seems that we are passing the params down in multiple arms? Daniel, can you help answer Javier's questions in this bug thread?