From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#36485: [PATCH] Improve some menus with separators and better wording Date: Fri, 13 Sep 2019 20:57:24 +0200 Message-ID: References: <83zhlvbduq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="29673"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36485@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 13 20:58:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i8qln-0007ZU-1S for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 20:58:11 +0200 Original-Received: from localhost ([::1]:46898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8qll-0000xb-NE for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Sep 2019 14:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55759) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8qle-0000uv-Oz for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 14:58:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8qld-0007O3-Py for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 14:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36784) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8qld-0007Nw-Mq for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 14:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i8qld-0000Hi-L1 for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2019 14:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Sep 2019 18:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36485 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36485-submit@debbugs.gnu.org id=B36485.15684010621052 (code B ref 36485); Fri, 13 Sep 2019 18:58:01 +0000 Original-Received: (at 36485) by debbugs.gnu.org; 13 Sep 2019 18:57:42 +0000 Original-Received: from localhost ([127.0.0.1]:45603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8qlK-0000Gs-5Z for submit@debbugs.gnu.org; Fri, 13 Sep 2019 14:57:42 -0400 Original-Received: from mail-pl1-f178.google.com ([209.85.214.178]:35442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i8qlJ-0000GW-2T for 36485@debbugs.gnu.org; Fri, 13 Sep 2019 14:57:41 -0400 Original-Received: by mail-pl1-f178.google.com with SMTP id s17so8705945plp.2 for <36485@debbugs.gnu.org>; Fri, 13 Sep 2019 11:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yyvB3gVhC1ot83ZOsgYQmMAfeLVOoacOxrGQzit06JI=; b=e4isODtUfDjpffXNXTNsJI8gzh1ycC02qgzHEDRmr5jYDD6zWkjKwWjqccUlwAg+Jy jgaO0rrfP2YkaGJVym8ieAeQWEuuhDyY264KIiQHiOiAm5Pp5rA5b4CLdwRRiFtv4NGI LbpE1n8rYCQscLc0bk+2ijky6yl2fMPFWfcDNb/5hLh9cwmoWdWZ+2z8F2qMH3Uexgcd t7dvdrCvMIUEtvHeBUmCttpKqHauKiSSNHIn+oy8tY2W87lP6eAEOK6y++K3qhBRylpE WZu3s1bvco7tC8F1hHEulJOsFuN7SuxGUS75YiVtufbEBiiUtGCw0alXp3PG9nhDaa5W Y2IA== X-Gm-Message-State: APjAAAUh4yDOOurkU1YbW2ScKUyRsMILWaR7suTmu1RDbaDUrHvzLmzn DZnJOgtS4rJrlsL2Jxpk1iV0/6nAFjMgZo6CgLs= X-Google-Smtp-Source: APXvYqwpAbo3nJBnrTBhC6fFf0p5La9UuayfQw2LH+/S/gnAcNMJrK/2Os6pfh28SNW0xFfWY7j1OF0Ei46XQRk/OVI= X-Received: by 2002:a17:902:326:: with SMTP id 35mr52267715pld.128.1568401055261; Fri, 13 Sep 2019 11:57:35 -0700 (PDT) In-Reply-To: <83zhlvbduq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166410 Archived-At: tags 36485 + fixed close 36485 27.1 close Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Wed, 3 Jul 2019 09:17:42 +0200 >> >> Just a small patch to add menu separators to some menus that are >> missing them. > > What were the criteria for determining that a separator is missing in > a particular place? > > Adding separators makes the menus longer, which could be a problem, > especially on TTY frames with a small number of lines (like 24). So > we need to add them judiciously. Thanks for reviewing the change. Looking back at the suggestion, my criteria were admittedly pretty ad hoc, and I had completely forgotten about the menu on the console. Taking another look now, I think the only important change here is a typo which I fixed in commit 224534ab8d. With that, I'm closing this bug report. Best regards, Stefan Kangas